proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-03 00:51:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,935 Commits 4 Branches 191 Tags 125 MiB
7012f1a38c
Commit Graph

11935 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Quentin Young
7012f1a38c zebra: remove asserts on task nullity 
While ZAPI I/O threads make a best effort to kill any scheduled tasks on
their threadmasters, after death another pthread can continue to
schedule onto the threadmaster. This isn't a problem per se since the
tasks will never run, but it also means that asserting that it hasn't
happened is pointless.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-07-02 18:07:28 +00:00
Quentin Young
36789dd4b5
Merge pull request #2533 from pguibert6WIND/doc_flowspec 
doc: add flowspec information from user point of view
 2018-07-02 11:42:22 -04:00
Philippe Guibert
53b758f3e2 doc: fix missing bgp keyword in debug bgp command 
Some debug bgp commands were missing bgp keyword.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2018-07-02 11:47:57 +02:00
Philippe Guibert
00458d014a doc: add flowspec information from user point of view 
Add some information for BGP flowspec.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2018-07-02 11:47:57 +02:00
Russ White
8d6d6b2581
Merge pull request #2475 from LabNConsulting/working/master/no_vrf_socket_4l3mdev 
Don't open per vrf sockets when net.ipv4.tcp|udp_l3mdev_accept != 0
 2018-07-01 23:06:22 -04:00
Donald Sharp
b9778ba7c2
Merge pull request #2593 from rtrlib/2018-07-01-master-bugfix 
bgpd: fix rpki segfault
 2018-07-01 19:40:57 -04:00
Marcel Röthke
92110aabe4 bgpd: fix rpki segfault 
If a cache server was added after rpki was started it's tr_socket would
not be initialized. This would lead to a segfault if the rtr manager
ever decides to switch to that socket or if rpki support is stopped.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
 2018-07-01 22:57:36 +02:00
Donald Sharp
c3555a6d12
Merge pull request #2592 from tigranmartirosyan/master 
fixed #2567: Json status of BGP peer is not updated properly
 2018-06-30 09:26:22 -04:00
Tigran Martirosyan
9199a725f4 fixed #2567: Json status of BGP peer is not updated properly 2018-06-30 16:27:25 +04:00
Russ White
04eb8905f9
Merge pull request #2574 from pacovn/Coverity_1399202_Copy-paste_error 
bgpd: copy-paste error (Coverity 1399202)
 2018-06-29 18:35:12 -04:00
Russ White
53792a0b72
Merge pull request #2582 from donaldsharp/work_smarter_not_slower 
bgpd: Remove HAVE_CUMULUS from evpn commands
 2018-06-29 18:18:34 -04:00
Russ White
6f7f19c4cf
Merge pull request #2588 from pacovn/Clang_dereference1 
bgpd isisd: null check (Clang scan)
 2018-06-29 18:12:48 -04:00
Quentin Young
bced989bf0
Merge pull request #2577 from pacovn/Coverity_1399377_Structurally_dead_code 
bgpd: dead code (Coverity 1399377)
 2018-06-29 17:08:58 -04:00
F. Aragon
77bfaef4eb
bgpd: dead code (Coverity 1399377) 
Replacing "continue" with "break" because the loop is a "while (0)"

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 20:21:22 +02:00
Russ White
1ad26882cb
Merge pull request #2517 from pguibert6WIND/flowspec_other_options 
Flowspec support other options
 2018-06-29 13:45:44 -04:00
Jafar Al-Gharaibeh
20e5fd7ab5
Merge pull request #2532 from donaldsharp/various_stuff 
Redistribution and some extra developer debug code
 2018-06-29 12:41:02 -05:00
Russ White
b46f306ed5
Merge pull request #2583 from donaldsharp/more_warnings 
zebra: Fix use of uninited variable
 2018-06-29 13:39:42 -04:00
Russ White
c29e9d23bf
Merge pull request #2581 from qlyoung/fix-vtysh-autocomplete 
vtysh: fix autocomplete garbage printouts
 2018-06-29 13:31:21 -04:00
Russ White
11f13d2333
Merge pull request #2578 from pacovn/Coverity_1453455_Dereference_null_return_value 
bgpd: null check (Coverity 1453455)
 2018-06-29 13:28:28 -04:00
Russ White
33bce37947
Merge pull request #2573 from pacovn/Coverity_23065_Explicit_null_dereferenced 
bgpd: null check (Coverity 23065)
 2018-06-29 13:27:04 -04:00
Russ White
42edc48606
Merge pull request #2514 from pacovn/Coverity_1462467_1465497_Control_flow_issues 
zebra: control flow issues (Coverity 1462467 1465497)
 2018-06-29 13:24:42 -04:00
Quentin Young
b723011d39
Merge pull request #2586 from pacovn/clang_scan_nhrpd_vici_initialization 
nhrpd: uninitialized variable (Clang scan)
 2018-06-29 12:55:55 -04:00
Quentin Young
df6e5a848e
Merge pull request #2587 from pacovn/Clang_scan_dead_code 
isisd zebra: dead code (Clang scan)
 2018-06-29 12:18:38 -04:00
F. Aragon
1230a82d5b
bgpd isisd: null check (Clang scan) 
This correction fixes three bugs detected by Clang scan:

Bug Group: Logic error
Bug Type: Dereference of null pointer

File: bgpd/bgp_evpn.c
Function: bgp_evpn_unconfigure_import_rt_for_vrf
Line: 4246

File: isisd/isis_spf.c
Function: isis_print_paths
Line: 69 (two bugs of same type in one line)

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 17:51:44 +02:00
Jafar Al-Gharaibeh
5b03d030d9
Merge pull request #2562 from pacovn/Coverity_1221444_1221446_Out-of-bounds_read 
ospf6d: OoB read (Coverity 1221444 1221446)
 2018-06-29 10:48:33 -05:00
F. Aragon
e36e5b569c
isisd zebra: dead code (Clang scan) 
This correction fixes two bugs detected by Clang scan:

Bug Group: Dead store

Bug Type: Dead assignment
File: zebra/kernel_netlink.c
Function: netlink_parse_extended_ack
Line: 548

Bug Type: Dead increment
File: isisd/isis_lsp.c
Function: lsp_bits2string
Line: 625

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 17:47:05 +02:00
F. Aragon
0a939f4f24
nhrpd: uninitialized variable (Clang scan) 
This correction fixes two bugs detected by Clang scan:

Bug Group: Logic error
Bug Type: Assigned value is garbage or undefined
File: nhrpd/vici.c
Function: vici_parse_message
Lines: 100, 105

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 17:40:45 +02:00
Donald Sharp
798ad23151
Merge pull request #2575 from pacovn/Coverity_1399219_Copy-paste_error 
bgpd: copy-paste error (Coverity 1399219)
 2018-06-29 11:17:52 -04:00
F. Aragon
0866cdaf3e
bgpd: null check (Coverity 1453455) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 11:03:06 +02:00
paco
d4f8b53750
bgpd: null check (Coverity 23065) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 10:48:31 +02:00
paco
b8ce0c3696
ospf6d: OoB read (Coverity 1221444 1221446) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 10:39:27 +02:00
Donald Sharp
b3a4db3dce bgpd: Add some asserts because of our linklist stuff 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-28 22:33:35 -04:00
Donald Sharp
ce4f1050ca zebra: Fix use of uninited variable 
Allow compiler to think the value is actually set to
something useful in an impossible case.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-28 21:06:23 -04:00
Donald Sharp
6a527b2fc1 bgpd: Fix some build issues from removing HAVE_CUMULUS 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-28 20:57:36 -04:00
Donald Sharp
f00ba69963 bgpd: Use correct data size 
a vni_t is 32 bit, so we only need to use a normal
integer for json commands.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-28 20:45:32 -04:00
Donald Sharp
e093d9d57b bgpd: Remove HAVE_CUMULUS from evpn commands 
In order to make EVPN behavior work without special casing
the code, bring the evpn commands under HAVE_CUMULUS into
the fold.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-28 20:18:17 -04:00
Jafar Al-Gharaibeh
d6076845b3
Merge pull request #2561 from pacovn/Coverity_1399231_Logically_dead_code 
lib ospf6d: dead code (Coverity 1399231)
 2018-06-28 14:48:17 -05:00
Quentin Young
8d70e7fe32 vtysh: fix autocomplete garbage printouts 
The semantics for suppressing output received from daemons changed
slightly when pipe actions were introduced, causing raw autocomplete
output to be printed where it shouldn't have been.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-28 18:37:01 +00:00
Quentin Young
d55c2456e8
Merge pull request #2576 from pacovn/Coverity_1399228_Logically_dead_code 
bgpd: dead code (Coverity 1399228)
 2018-06-28 12:55:25 -04:00
Quentin Young
1db6d24497
Merge pull request #2572 from pacovn/Coverity_1399203_Unchecked_return_value 
bgpd: return value (Coverity 1399203)
 2018-06-28 12:35:58 -04:00
Quentin Young
c2d64eacde
Merge pull request #2579 from pacovn/Coverity_1424370_Unchecked_return_value_from_library 
isisd: return check (Coverity 1424370)
 2018-06-28 12:25:45 -04:00
Quentin Young
2587508e87
Merge pull request #2580 from pacovn/Coverity_1424529_Dereference_after_null_check 
isisd: null check (Coverity 1424529)
 2018-06-28 12:23:56 -04:00
F. Aragon
c46df7876a
isisd: null check (Coverity 1424529) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 16:48:37 +02:00
F. Aragon
aa979109f2
isisd: return check (Coverity 1424370) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 16:31:37 +02:00
paco
b684aedac8
bgpd: dead code (Coverity 1399228) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:56:29 +02:00
paco
f86285ffef
bgpd: copy-paste error (Coverity 1399219) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:39:59 +02:00
paco
343cdb6143
bgpd: copy-paste error (Coverity 1399202) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:31:38 +02:00
paco
da3b87f8b0
bgpd: return value (Coverity 1399203) 
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 12:41:52 +02:00
paco
a35fb78f1c
ospf6d: dead code (Coverity 1399231) 
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 11:50:49 +02:00
Philippe Guibert
6e28881901 bgpd: rework enumerate function, handle not values 
The handling of reverse values is in a separate function.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2018-06-28 11:08:59 +02:00