Merge pull request #2514 from pacovn/Coverity_1462467_1465497_Control_flow_issues

zebra: control flow issues (Coverity 1462467 1465497)
This commit is contained in:
Russ White 2018-06-29 13:24:42 -04:00 committed by GitHub
commit 42edc48606
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 9 deletions

View File

@ -307,7 +307,7 @@ ns_id_t zebra_ns_id_get(const char *netnspath)
nlh = (struct nlmsghdr *)((char *)nlh
+ NETLINK_ALIGN(
nlh->nlmsg_len));
} while (len != 0 && return_nsid != NS_UNKNOWN && ret == 0);
} while (len != 0 && ret == 0);
}
close(fd);

View File

@ -1428,18 +1428,14 @@ static void rib_process_update_fib(struct zebra_vrf *zvrf,
if (new != old)
zlog_debug(
"%u:%s: Deleting route rn %p, re %p (type %d) "
"old %p (type %d) - %s",
"old %p (type %d) - nexthop inactive",
zvrf_id(zvrf), buf, rn, new,
new->type, old, old->type,
nh_active ? "install failed"
: "nexthop inactive");
new->type, old, old->type);
else
zlog_debug(
"%u:%s: Deleting route rn %p, re %p (type %d) - %s",
"%u:%s: Deleting route rn %p, re %p (type %d) - nexthop inactive",
zvrf_id(zvrf), buf, rn, new,
new->type,
nh_active ? "install failed"
: "nexthop inactive");
new->type);
}
/* If labeled-unicast route, uninstall transit LSP. */