proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-17 05:18:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

zebra: remove asserts on task nullity

Browse Source 
While ZAPI I/O threads make a best effort to kill any scheduled tasks on
their threadmasters, after death another pthread can continue to
schedule onto the threadmaster. This isn't a problem per se since the
tasks will never run, but it also means that asserting that it hasn't
happened is pointless.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
This commit is contained in:
Quentin Young 2018-07-02 18:07:28 +00:00
parent 36789dd4b5
commit 7012f1a38c
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zebra/zserv.c
View File

@ -618,14 +618,6 @@ static int zserv_handle_client_close(struct thread *thread)
{
struct zserv *client = THREAD_ARG(thread);
/*
* Ensure these have been nulled. This does not equate to the
* associated task(s) being scheduled or unscheduled on the client
* pthread's threadmaster.
*/
assert(!client->t_read);
assert(!client->t_write);
/* synchronously stop thread */
frr_pthread_stop(client->pthread, NULL);