proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-13 05:05:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,935 Commits 4 Branches 191 Tags 125 MiB
7012f1a38c
Commit Graph

11935 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
paco
32ac96b2ba
zebra: string null termination (Coverity 1465494) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 14:53:31 +02:00
Donald Sharp
9685abb492 lib: Remove special case code to use syslog 
Remove the special case code to use syslog for Cumulus.
They can specify this via startup now instead of having
a special compile flag for this option.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
ed74ddf403 doc: Add some documentation for cli logging 
Add some basic documentation for the new cli added to all daemons.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
f8507817cf lib: Add new cli to specify where to output logs on startup 
When we are starting a daemon, allow the user to specify:

--log <stdout|syslog|file:file_name>

This can be used on early startup to put the log files
where the end user wants them to show up.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
1f14323649 vtysh: Fix 'no log syslog ..' to be correct 
The vtysh version of `no log syslog...` was out
of sync with what is actually correct.  Fix.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
9124048d0e ldpd: Schedule application of config till after read-in 
With commit e94b38d94b5 we are now scheduling the read
of vty config until after the startup of main thread
processing.  It now becomes necessary to move the
application of the config until after the read
in of the config from a file if we are using a
non-integrated config.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
9e224e60db lib: Create a thread for reading in the cli 
The read in of cli was happening prior to thread
event handling for non-integrated configs.  This
is interesting for 2 reasons:

1) Read-in of integrated configs was after thread
event loop startup, so we had a difference of behavior

2) Read-in can cause a series of events that cause
us to attempt to communicate with zebra.  The zebra
zapi connection only happens after the thread event
loop has been started.  This can cause data that
is being written down to zebra to be lost and
no real way to notice that this has happened and
to recover gracefully.

Modify the code to create a thread event for read
in of client config.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
573de11fab lib: Add ability to retry if backup is specified 
If we fail to read in the config file and we have
specified a backup of the backup, attempt to
read that information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Donald Sharp
5ede5e4eed lib: Add ability to know if we have read anything in 
When reading the config file add an ability to know
if we have properly read in anything.  So that a daemon
can make fallback plans.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-19 08:43:59 -04:00
Russ White
05d7e026c8
Merge pull request #2445 from ppmathis/feature/bgp-pg-overrides 
bgpd: Improve peer-group override implementation
 2018-06-19 08:20:31 -04:00
Russ White
4a1f626570
Merge pull request #2450 from ppmathis/bugfix/bgp-filtered-routes 
bgpd: Fix crash when showing filtered routes
 2018-06-19 07:37:42 -04:00
Russ White
8fef257611
Merge pull request #2465 from qlyoung/fix-build-am-cppflags-warning 
tests: fixup minor autotools nit
 2018-06-19 07:31:43 -04:00
Russ White
35169b489d
Merge pull request #2468 from qlyoung/docuser 
doc: update workflow.rst
 2018-06-19 07:31:10 -04:00
Russ White
fc89ac9846
Merge pull request #2470 from chiragshah6/mdev 
zebra: Hide default vrf instance of l3vni cmd
 2018-06-19 07:29:13 -04:00
Russ White
efd1d76673
Merge pull request #2474 from donaldsharp/vty_thread_cancel_writes 
Add 'show thread poll'
 2018-06-19 07:28:18 -04:00
Russ White
e3ea4f7acb
Merge pull request #2478 from pacovn/Coverity_1408766_Dereference_after_null_check 
bgpd: null check (Coverity 1408766)
 2018-06-19 07:21:42 -04:00
Russ White
0ddc9a2d9d
Merge pull request #2479 from dslicenc/zebra-vrf-statics 
zebra: re-install static routes needed vrf when the vrf intf comes up
 2018-06-19 07:19:39 -04:00
Russ White
f071d8b36a
Merge pull request #2481 from pacovn/security_vpn_null_check 
bgpd: vpn null check
 2018-06-19 07:19:00 -04:00
Russ White
9635a16a36
Merge pull request #2483 from pacovn/clang_scan_bgpd_updgrp_deref 
bgpd: null check (Clang scan-build)
 2018-06-19 07:18:13 -04:00
Russ White
5e51ae9816
Merge pull request #2491 from pacovn/cppcheck_no_effect 
eigrpd, isisd, lib, ospfd: no effect (cppcheck)
 2018-06-19 07:15:07 -04:00
Russ White
aa13697bb0
Merge pull request #2492 from pacovn/cppcheck_security1 
eigrpd, lib, tests, vtysh: security (cppcheck)
 2018-06-19 07:14:19 -04:00
paco
6d10727ac1
eigrpd, lib, tests, vtysh: security (cppcheck) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 10:40:56 +02:00
paco
5f18adf01b
eigrpd, isisd, lib, ospfd: no effect (cppcheck) 
Assignment of function parameter has no effect outside the function.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-19 10:19:05 +02:00
Ruben Kerkhof
0cff191d5c redhat: fix else cases in spec file 
As pointed out during review, disable the options when the macros are
false.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
2d2ab69937 redhat: spec file: specify file only once 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
07a138ecab redhat: spec file: no need for custom attr for service file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
95624f7b34 redhat: add missing dependencies on chkconfig in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
c88a52f4df redhat: remove a few superfluous Requires from spec file 
rpm adds these automatically

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
ccb9b8f6c0 redhat: remove a few superfluous BuildRequires from spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
501c136231 redhat: depend on info package instead of binary in specfile 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
fadbc6e7fe redhat: install-info is not called from %pre in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
54c059f1cb redhat: remove wrong comment from spec file 
systemd support needs watchfrr

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
a999f98cc5 redhat: spec file: all supported Fedora versions use systemd 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
7ca1f62ca9 redhat: use default permissions for logrotate file in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
6ad17a64c1 redhat: spec file: we ship only one logrotate file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
c9cad8766e redhat: be consistent in adding ./configure options in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
c410a86130 redhat: use Github for SOURCE0 in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
e1ff824635 redhat: Use https for URL in spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
150e7c7eb3 redhat: remove trailing whitespace from spec file 
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:52 +02:00
Ruben Kerkhof
fe99b0153a redhat: fix tabs vs spaces in spec file 
rpmlint reports:
redhat/frr.spec:282: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 282)

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
 2018-06-19 09:57:45 +02:00
Lou Berger
ed892e530d
Merge pull request #2476 from pacovn/Coverity_1433544_Explicit_null_dereferenced 
bgpd: null check (Coverity 1433544, 1433543, 1433542)
 2018-06-18 16:59:26 -04:00
Donald Sharp
b5e3687b1d
Merge pull request #2482 from pacovn/clang_scan_bgpd_bgp_rpki_deref 
bgpd: null check (Clang scan-build)
 2018-06-18 16:09:56 -04:00
paco
d3e51db069
bgpd: null check (Clang scan-build) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-18 21:37:35 +02:00
Donald Sharp
e8609f7950
Merge pull request #2484 from pacovn/cppcheck_unused_vars 
eigrpd, lib: unused vars (cppcheck)
 2018-06-18 15:27:11 -04:00
Donald Sharp
6f32955ec3
Merge pull request #2486 from pacovn/cppcheck_fmt_validation 
babeld, lib, ospfd, tests: fmt fixes (cppcheck)
 2018-06-18 15:23:49 -04:00
Donald Sharp
2daa80f0c0
Merge pull request #2489 from pacovn/cppcheck_reduntant_pointer_op 
ldpd: redundant pointer operation (cppcheck)
 2018-06-18 15:16:55 -04:00
Donald Sharp
cfa38db146
Merge pull request #2488 from pacovn/cppcheck_nhrpd_limit_check 
nhrpd: array limit check (cppcheck)
 2018-06-18 15:16:34 -04:00
Donald Sharp
b49bc6b010
Merge pull request #2487 from pacovn/cppcheck_redundant_memset 
ospfd, pimd: redundant memset (cppcheck)
 2018-06-18 15:15:46 -04:00
Donald Sharp
162deb7dfb
Merge pull request #2490 from pacovn/cppcheck_unsigned_check 
babeld, eigrpd, ospfd: unsigned negative check (cppcheck, grouped)
 2018-06-18 15:14:07 -04:00
Donald Sharp
c0662bb478
Merge pull request #2417 from pacovn/Coverity_1399373_Structurally_dead_code 
bgpd: dead code (Coverity 1399373)
 2018-06-18 14:29:27 -04:00