split the long ternary operation into a common if/else, to make it
readable.
Also, remove the usb3field.isDisabled check as:
1. we do not disable it anywhere anymore
2. if we would, it makes sense to do this anyhow
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Instead of having two times the check if the USB3 setting needs to be
added to the config string it is now checked at one place only.
If USB3 is checked for a non USB3 device it will be attached to the USB2
root hub of the xhci controller.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
labelWidth: 'auto' is not valid since extjs simply
adds 'px' and sets it as width which would result in:
width: 'autopx';
which is not valid css. chrome/chromium had a change such that this now
produces the wrong height in the login bottom 'button bar'
250 should be enough for all translations and we do not have
any other element there
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
as else we change behavior for those who never set the new scaling
variable, or cleared the browser local store.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Add a setting to choose the scale mode of the noVNC pop-up as well as
the embedded console in the content panel to "My Settings". Having both
set to local scaling was the most important use-case for the users. One
setting for both places is the simplest solution making this possible.
The new section (fieldset) makes adding further options such as
"Local Cursor" easy.
Co-developed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
By default, all file types are shown, but the user now has the option of
filtering only by supported types in the file selector dialog.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Acked-by: Dominik Csapak <d.csapak@proxmox.com>
since commit 1ccb53ecdbd69a0e4c57a6d861da1918d3625e08 from widget
toolkit[0] we enforce by default that an entered value needs to be in
the backing data store, else the field is marked invalid.
But, for the firewall source/destination IP selector we do not care
if it's in the store, which is only loaded for convenience and to
allow selecting defined aliases/ipsets
[0]: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commit;h=1ccb53ecdbd69a0e4c57a6d861da1918d3625e08
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
It was intended that for partitioned disks, we create one and use it.
Instead the code died always when the disk was used and not of type 'LVM'
We now check correctly the 2 cases:
* used for partitions and has gpt
* used and lvm
The remaining api call handles those two cases correctly
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the api returns 'null' for a host that is in the crushmap, but
without actual version information, so just check for falsyness instead
of 'undefined', else we run later into javascript exceptions and no
content on the osd page
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
If you updated a job in "exclude" mode with some VMIDs specified to "pool" mode,
the backup job would retain the "exclude" section and thus not back up all VMs.
The GUI misrepresents this, showing that all VMs will be backed up or
straight up break and show "exclude" mode again, with the backend still
being on "pool" - to prevent this, we always delete a jobs "exclude" list
when it's switched to "pool".
Co-authored-by: Tim Marx <t.marx@proxmox.com>
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Iterate all (online) nodes client-side and call vzdump with the correct
parameters (according to the job selected) for each one.
Then, show a progress bar in a non-closeable modal-dialog, to ensure the
user stays on the Backup page during the /vzdump API calls. Any errors
that occurred will be displayed in a consolidated message box.
Includes a "confirm" dialog to not accidentally run a potentially large
backup job.
Curiously, the "pve-cluster-backup" data model seems to have been broken
entirely. I'm not sure how it was working before, but the changes in
this patch need it fixed, so include that as well (use "mode" instead of
individual flags + "compress" is not a boolean).
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
This was previously gated to CLI only, but it causes a vzdump job
started with the newly introduced "Run Now" button to fail if it
includes VMIDs on other nodes.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
since the content of the window is encoded with 'Ext.htmlEncode'
we have to decode it with 'Ext.String.htmlDecode' (Ext.htmlDecode is
a deprecated alias for it) before downloading the file
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
In case pvedaemon, pveproxy is not running or we get somehow else a
595 response (connection failure), we want to tell this to the user,
since "Login failed" doesn't help.
Handle all connection failures, leave the rest the same. We could go
into more detail (CONNECT_FAILURE, CLIENT_INVALID, LOAD_FAILURE and
SERVER_INVALID), but i didn't see any reason to make all these
distinctions now.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
