Commit Graph

4444 Commits

Author SHA1 Message Date
Thomas Lamprecht
83b4bfc314 ui: qemu/HWView: small code cleanup for remove dialog
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-17 13:27:35 +02:00
Thomas Lamprecht
03558174ef ui: qemu/HWView: only render icon when in grid
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-17 13:26:59 +02:00
Dominik Csapak
3098f188b3 gui: fix debug-mode error
setData on an 'empty' store does not work in extjs debug mode
setting store to '{}' here does create a store on component creation
so the store is not 'empty'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-17 13:01:31 +02:00
Fabian Grünbichler
b4cb37e057 ceph destroymon: actually die on errors
instead of silently ignoring them. since we are in a task worker here
this is especially important - otherwise the task status/result is also
wrong!

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-17 13:01:31 +02:00
Fabian Grünbichler
8e2b5110e5 ceph init: actually die on errors
instead of silently ignoring them

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-17 13:01:31 +02:00
Thomas Lamprecht
a4740d30ac ui: window/migrate: use space separator between type and VMID
Like previous to commit 9706707d2f
which broke this, we have some assumptions in our gui-test/screenshot
automation which lays assumptions on certain window titles, so try to
keep them stable.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-15 20:14:39 +02:00
Thomas Lamprecht
370ff47354 bump version to 6.0-4
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-15 18:48:57 +02:00
Dominik Csapak
8be1b3ba95 pve5to6: check for ceph-volume osds
do not warn in case there exist nautilus osds
since the upgrade has to be done by the time a user should add new
osds, it does not make sense to warn in that case

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-15 17:09:27 +02:00
Tim Marx
994f647edc gui: ceph installer: fix typo
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-07-15 11:18:07 +02:00
Thomas Lamprecht
7c9f66d036 followup code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-15 10:57:00 +02:00
Dominik Csapak
199aa9efb7 ceph: mon list: show only as running when monitor is quorate
nautilus puts non running monitors also in the monmap, so only show
as running when it has quorum

this is also not 100% correct, but the only 'correct' alternative is
to try and get/parse the systemd status of the units and broadcast it
to the pmxcfs

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-15 10:56:14 +02:00
Thomas Lamprecht
2bf285d643 ui: cephfs: also add new tooltip like pool create
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-15 07:47:31 +02:00
Thomas Lamprecht
1d8d2307a6 ui: dc/Cluster: rename ring columns to link
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-15 07:43:04 +02:00
Thomas Lamprecht
bd9537d735 followup coide cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-12 14:07:25 +02:00
Dominik Csapak
f932cffa89 ui: improve console fallback logic if default is not available
instead of instantly defaulting to novnc when the chosen
default is not available, try the other (better variant)
before falling back to novnc

e.g. having no default set is equivalent to having it set
to xtermjs, and having a vm with spice then previously
defaulted to novnc, now to spice (the reverse is also true)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-12 14:00:51 +02:00
Dominik Csapak
54453c3873 ui: fix wrong defaultConsole fallback in tree
having spice does not mean it can also have xtermjs, and
we get the information in the status call already
so give the correct parameters to openDefaultConsoleWindow

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-12 14:00:33 +02:00
Thomas Lamprecht
a482a83614 bump version to 6.0-3
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-12 12:31:04 +02:00
Oguz Bektas
1780a64476 filter unusable lxc mountoptions for rootfs
disable nodev and noexec per thomas' suggestion[0].

[0]: https://pve.proxmox.com/pipermail/pve-devel/2019-July/037994.html

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-07-12 12:26:44 +02:00
Thomas Lamprecht
7a8653ceaa Revert "add beta text with link to bugtracker"
This reverts commit 1e12b31791.
2019-07-11 21:59:05 +02:00
Thomas Lamprecht
0fc9ceb052 ui: node/disks: retune column width and hide vendor by defauöt
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 21:37:10 +02:00
Thomas Lamprecht
3f4dc60408 ui: node/disks: reuse Utils.format_boolean for GPT column
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 21:33:37 +02:00
Thomas Lamprecht
b3b889ffb8 pveam: add mail to sections
it includes the PMG

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 21:22:57 +02:00
Thomas Lamprecht
c35f40b1f9 bump version to 6.0-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 20:42:02 +02:00
Thomas Lamprecht
fd7374b656 ui: dc/cluster: enforce second link if in join info
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 20:41:09 +02:00
Thomas Lamprecht
9c464cebb8 ui: dc/cluster: join: s/ring/link/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 20:40:51 +02:00
Thomas Lamprecht
e20eda8954 ui: dc/cluster: allow to create cluster with second link
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 20:16:20 +02:00
Thomas Lamprecht
c459433417 ui: dc/cluster: add onlineHelp reference to create call
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 20:12:00 +02:00
Dominik Csapak
cdb828c788 gui: ceph configdb: fix store load
instead of using API2Request, use the proper grid store load

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-11 15:14:57 +02:00
Thomas Lamprecht
59e330805d ui: ceph/pool: enable add_storages by default and add tooltip
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:55:26 +02:00
Thomas Lamprecht
ee099a5fdc ui: ceph/service list: re-do column widths with flex
this way we see thew full status of a MDS, and for our minimal
resolution of 720p and targeted resolution of 1080p it works good.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:47:10 +02:00
Thomas Lamprecht
5b7b4b7623 ui: ceph/pool: rework status grid a bit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:21:51 +02:00
Thomas Lamprecht
fad28c95b1 ui: remove notify calls on viewmodel
They should not be required and result in exceptions thrown if this
component is used in combination with ExtJS debug sources

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
a9e23b28ae ui: ceph/osd: merge apply + commit latency columns
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
cfb103131f ui: ceph/osd: split out used% and total avail column
as "used -> total" is just confusing

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
413ada0fbb ui: ceph/osd: hide Type column by default
this column shows what type the current row is (host, osd, root),
nowadays that's quite visible through the tree view + icons, so just
hide it by default to make this interface a bit less noisier.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
a336875216 ui: ceph/osd: only show at max 5 digits after decimal point for weight
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
3b0ae6b2f0 ui: ceph/osd: rename Action to More
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
a3f146fcc1 ui: ceph OSD: tweak default column width a bit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
35c9c3d6da ui: ceph/osd: reintroduce Used column
previous commit 76235ae132c69898048c1f7579e7da40adbd7a6e accidentally
removed this column during refactoring, let's reintroduce it again.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Dominik Csapak
3982a21441 gui: ceph osd: rewrite osd panel and add scrub button
this rewrite of the osd panel converts it to a static declaration of
the layout with a controller/viewmodel logic

while doing this, add icons to buttons, and add a scrub/deep scrub entry

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-11 14:16:11 +02:00
Thomas Lamprecht
9cc5ac9e75 api/ceph: code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-11 14:16:11 +02:00
Dominik Csapak
b7701301a8 api/ceph: add osd scrub api call
can be called to (deep) scrub a specific osd

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-11 14:16:06 +02:00
Alwin Antreich
ea60e3b72e keyring: use ckeyring_path variable in chown cmd
A fixed path for the ceph.client.admin.keyring was used in the chown
command. This patch uses the ckeyring_path variable instead, to minimize
changes should the path change.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2019-07-10 15:42:49 +02:00
Alwin Antreich
177095661b Fix: typo in ckeyring_path
pveceph init failed, as the copy used a wrong path with typo as
target and then the chown tried to operate on the correct keyring
path, which was then non-existing.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2019-07-10 15:41:20 +02:00
Thomas Lamprecht
8144a0ddc7 ui: dc/options: minor followup cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 14:58:19 +02:00
Thomas Lamprecht
6de2baee56 ui/Parser: printPropertyString: sort non-defaultKey parts for stability
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 14:57:40 +02:00
Thomas Lamprecht
6619af8d4f ui: dc/options: use proxmoxNetworkSelector for network
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 14:38:49 +02:00
Thomas Lamprecht
c195a3c2d6 pveproxy: allow to request debug sources directly over GET parameter
Avoids the need to stop the current pveproxy and restart it in debug
mode, if one wants to get the debug un-minified sources for ExtJS,
for example.

For a local PVE instance the following URL would ensure you load the
debug sources:
https://localhost:8006/?debug#v1:0:18:4:25:19::8:20:28

For convenience allow to omit the parameters value, and default to
true, iow, ?debug and ?debug=1 are the same, one could force it off -
even if the server was started in debug mode - by using ?debug=0

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-09 15:07:41 +02:00
Thomas Lamprecht
77a8d952e0 followup: code cleanup to arrow functions
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-08 19:26:13 +02:00
Dominik Csapak
088fff5fa4 gui: show 0 for max_relocate/restart correctly
0 || '1' will always return '1'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-08 19:21:53 +02:00