Commit Graph

11991 Commits

Author SHA1 Message Date
Quentin Young
dad87073aa
Merge pull request #2568 from pguibert6WIND/doc_mpls
doc: add MPLS configuration commands
2018-07-05 14:56:34 -04:00
Jafar Al-Gharaibeh
262c829d7e
Merge pull request #2624 from donaldsharp/PIM_ZOMILY_ZOM
pimd: Use generated interface name
2018-07-04 18:42:51 -05:00
Philippe Guibert
b03d34322d doc: add MPLS configuration commands
Add MPLS information to statically handle label from zebra.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-07-04 19:11:20 +02:00
Donald Sharp
db20e34f09 pimd: Use generated interface name
When we have a generated interface name, use it instead of the actual
pointer.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-07-03 21:31:11 -04:00
Donald Sharp
732c8da348
Merge pull request #2614 from rtrlib/2018-07-02-master-bugfix
bgpd: fix rpki validation for ipv6 (master)
2018-07-03 20:32:30 -04:00
Quentin Young
4adc8f6852
Merge pull request #2620 from pacovn/PVS-Studio_null_check_2
bgpd lib ospfd pimd ripngd: null chk (PVS-Studio)
2018-07-03 17:38:09 -04:00
Jafar Al-Gharaibeh
94adf8d33e
Merge pull request #2610 from qlyoung/fix-zebra-pthread-crash-shutdown-min
zebra: remove asserts on task nullity
2018-07-03 15:47:23 -05:00
Jafar Al-Gharaibeh
7f04893904
Merge pull request #2619 from pguibert6WIND/show_ipv6_bgp_wrong
doc: bgp wrong command displayed
2018-07-03 10:47:27 -05:00
Lou Berger
3ebe5e5091
Merge pull request #2615 from chiragshah6/evpn_dev
bgpd: l3vni del to free ip prefix routes from vrf
2018-07-03 11:45:53 -04:00
Quentin Young
9c8726a33e doc: clean up flowspec.rst
* Fix broken citations
* Remove trailing whitespace
* Rewrap to 80 lines
* Tweak capitalization of section headers
* Clean up a few indented blocks

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-07-03 17:42:41 +02:00
Lou Berger
b0b3080e0f
Merge pull request #2598 from dslicenc/cm21429-vrf-dup
zebra: duplicate nexthops for cross-vrf static routes on vrf bounce
2018-07-03 11:39:38 -04:00
Lou Berger
b99af60a40
Merge pull request #2599 from pacovn/PVS-Studio_Array_overrun
ospfd zebra: array overrun fixes (PVS-Studio)
2018-07-03 11:37:34 -04:00
Marcel Röthke
e42346020e bgpd: fix rpki validation for ipv6
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
2018-07-03 16:19:21 +02:00
F. Aragon
b575a12c87
bgpd lib ospfd pimd ripngd: null chk (PVS-Studio)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-03 15:39:50 +02:00
Philippe Guibert
a69601ac33 doc: bgp wrong command displayed
This command does not exist. Move it to the right one.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-07-03 15:01:21 +02:00
F. Aragon
e1fa928d22
ospfd zebra: array overrun fixes (PVS-Studio)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-03 11:34:40 +02:00
Martin Winter
6f68fba107
Merge pull request #2516 from rubenk/more-spec-cleanups
More spec cleanups
2018-07-03 00:32:57 -07:00
Donald Sharp
9e79ccf3dc
Merge pull request #2609 from pacovn/clang_scan_nhrpd_vici_initialization
nhrpd: uninitialized variable (Clang scan)
2018-07-02 18:49:49 -04:00
Chirag Shah
d846168d35 bgpd: l3vni del to free ip prefix routes from vrf
In Symmetric routing case, L3VNI stores evpn MAC_IP routes
as IP_PREFIX routes in associated bgp_vrf and fib.

When vxlan device for l3vni goes down, triggers l3vni delete
in bgp.
As part l3vni delete, evpn ip prefix routes associated
with the vni need to be withdrawn from zebra as well
bgpinfo needs to be freed.
bgp_delete does not free bgp_info associated
to evpn ip prefix routes (link to bgp_vrf).
Call to uninstall_evpn_route_entry_in_vrf() properly
cleanup bgp_info as well triggers appropriate updates.

Ticket:CM-21443
Testing Done:
On DUT, bringup symmetric routing configuration, learn
EVPN Type-2 and Type-3 Routes.
Type-2 MAC_IP routes will be stored as ip_prefix in vrf table
during l3vni bring up.

Remove L3vni, deletes all ip_prefix routes from the zebra, kernel
vrf route table and bgp_info is freed.

Check the show bgp memory stats for bgp_info post l3vni flap.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2018-07-02 14:48:33 -07:00
Quentin Young
6945779cec
Merge pull request #2604 from pacovn/PVS-Studio_odd_operator_usage
nhrpd: odd operator usage fix (PVS-Studio)
2018-07-02 14:18:26 -04:00
Quentin Young
cab3de7e27
Merge pull request #2603 from pacovn/PVS-Studio_format_warnings
eigrpd nhrpd ospfd pimd: fomat fixes (PVS-Studio)
2018-07-02 14:15:43 -04:00
F. Aragon
7ea5df54b6
nhrpd: uninitialized variable (Clang scan)
Fix over 0a939f4f24 (there was a case not
covered by previous fix)

Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-02 20:07:59 +02:00
Quentin Young
7012f1a38c zebra: remove asserts on task nullity
While ZAPI I/O threads make a best effort to kill any scheduled tasks on
their threadmasters, after death another pthread can continue to
schedule onto the threadmaster. This isn't a problem per se since the
tasks will never run, but it also means that asserting that it hasn't
happened is pointless.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-07-02 18:07:28 +00:00
Donald Sharp
a566aa95b3
Merge pull request #2601 from pacovn/PVS-Studio_scope_overlap
ripngd: variable scope overlap fix (PVS-Studio)
2018-07-02 12:44:10 -04:00
Quentin Young
feed25a9a5
Merge pull request #2600 from pacovn/PVS-Studio_sizeof_and_dead_code
eigrpd: sizeof() usage + dead code (PVS-Studio)
2018-07-02 12:41:34 -04:00
F. Aragon
0651460e00
eigrpd nhrpd ospfd pimd: fomat fixes (PVS-Studio)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-02 17:50:21 +02:00
Quentin Young
36789dd4b5
Merge pull request #2533 from pguibert6WIND/doc_flowspec
doc: add flowspec information from user point of view
2018-07-02 11:42:22 -04:00
F. Aragon
c4822682d1
nhrpd: odd operator usage fix (PVS-Studio)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-02 17:37:23 +02:00
F. Aragon
ee6f77577c
ripngd: variable scope overlap fix (PVS-Studio)
Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-02 16:53:16 +02:00
F. Aragon
885c8244cf
eigrpd: sizeof() usage + dead code (PVS-Studio)
Two issues:

1) Removed an unnecesary null check of 'ei'
2) Fixed the usage of sizeof(), as it was used the size of a pointer instead
   of the size of the structure

Signed-off-by: F. Aragon <paco@voltanet.io>
2018-07-02 16:44:46 +02:00
Don Slice
3b88f2e60a zebra: duplicate nexthops for cross-vrf static routes on vrf bounce
Problem created by the fix for cm-21306 (inactive cross-vrf static routes
when vrfs were bounced.)  Determined that in another case, that fix would
cause duplicate nexthops to appear in the table. Resolved the problem by
removing the vrf static route process from the zebra "add" process leaving
it in the zebra " if up" process as added in cm-21306 since that's the point
that the vrf device is now functional.

Ticket: CM-21429
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
2018-07-02 14:01:33 +00:00
Philippe Guibert
53b758f3e2 doc: fix missing bgp keyword in debug bgp command
Some debug bgp commands were missing bgp keyword.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-07-02 11:47:57 +02:00
Philippe Guibert
00458d014a doc: add flowspec information from user point of view
Add some information for BGP flowspec.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-07-02 11:47:57 +02:00
Russ White
8d6d6b2581
Merge pull request #2475 from LabNConsulting/working/master/no_vrf_socket_4l3mdev
Don't open per vrf sockets when net.ipv4.tcp|udp_l3mdev_accept != 0
2018-07-01 23:06:22 -04:00
Donald Sharp
b9778ba7c2
Merge pull request #2593 from rtrlib/2018-07-01-master-bugfix
bgpd: fix rpki segfault
2018-07-01 19:40:57 -04:00
Marcel Röthke
92110aabe4 bgpd: fix rpki segfault
If a cache server was added after rpki was started it's tr_socket would
not be initialized. This would lead to a segfault if the rtr manager
ever decides to switch to that socket or if rpki support is stopped.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
2018-07-01 22:57:36 +02:00
Donald Sharp
c3555a6d12
Merge pull request #2592 from tigranmartirosyan/master
fixed #2567: Json status of BGP peer is not updated properly
2018-06-30 09:26:22 -04:00
Tigran Martirosyan
9199a725f4 fixed #2567: Json status of BGP peer is not updated properly 2018-06-30 16:27:25 +04:00
Russ White
04eb8905f9
Merge pull request #2574 from pacovn/Coverity_1399202_Copy-paste_error
bgpd: copy-paste error (Coverity 1399202)
2018-06-29 18:35:12 -04:00
Russ White
53792a0b72
Merge pull request #2582 from donaldsharp/work_smarter_not_slower
bgpd: Remove HAVE_CUMULUS from evpn commands
2018-06-29 18:18:34 -04:00
Russ White
6f7f19c4cf
Merge pull request #2588 from pacovn/Clang_dereference1
bgpd isisd: null check (Clang scan)
2018-06-29 18:12:48 -04:00
Quentin Young
bced989bf0
Merge pull request #2577 from pacovn/Coverity_1399377_Structurally_dead_code
bgpd: dead code (Coverity 1399377)
2018-06-29 17:08:58 -04:00
F. Aragon
77bfaef4eb
bgpd: dead code (Coverity 1399377)
Replacing "continue" with "break" because the loop is a "while (0)"

Signed-off-by: F. Aragon <paco@voltanet.io>
2018-06-29 20:21:22 +02:00
Russ White
1ad26882cb
Merge pull request #2517 from pguibert6WIND/flowspec_other_options
Flowspec support other options
2018-06-29 13:45:44 -04:00
Jafar Al-Gharaibeh
20e5fd7ab5
Merge pull request #2532 from donaldsharp/various_stuff
Redistribution and some extra developer debug code
2018-06-29 12:41:02 -05:00
Russ White
b46f306ed5
Merge pull request #2583 from donaldsharp/more_warnings
zebra: Fix use of uninited variable
2018-06-29 13:39:42 -04:00
Russ White
c29e9d23bf
Merge pull request #2581 from qlyoung/fix-vtysh-autocomplete
vtysh: fix autocomplete garbage printouts
2018-06-29 13:31:21 -04:00
Russ White
11f13d2333
Merge pull request #2578 from pacovn/Coverity_1453455_Dereference_null_return_value
bgpd: null check (Coverity 1453455)
2018-06-29 13:28:28 -04:00
Russ White
33bce37947
Merge pull request #2573 from pacovn/Coverity_23065_Explicit_null_dereferenced
bgpd: null check (Coverity 23065)
2018-06-29 13:27:04 -04:00
Russ White
42edc48606
Merge pull request #2514 from pacovn/Coverity_1462467_1465497_Control_flow_issues
zebra: control flow issues (Coverity 1462467 1465497)
2018-06-29 13:24:42 -04:00