Stéphane Graber
275b76d27b
Merge pull request #2179 from brauner/2018-02-21/docs_add_cgroup_full_force
...
doc: document cgroup-full:{mixed,ro,rw}:force
2018-02-21 12:23:14 -05:00
Christian Brauner
a763deecfb
Merge pull request #2180 from tenforward/japanese
...
Update Japanese lxc.container.conf(5)
2018-02-21 12:22:58 +01:00
KATOH Yasufumi
3e2bb54b2e
doc: Improve Japanese translation in lxc.container.conf(5)
...
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>
2018-02-21 20:17:15 +09:00
KATOH Yasufumi
3f163e459f
doc: add "force" option of lxc.mount.auto to Japanese lxc.container.conf(5)
...
Update for commit 3f69fb1
2018-02-21 20:12:59 +09:00
KATOH Yasufumi
07410c63a4
doc: Add the describe of mount propagation to Japanese lxc.container.conf(5)
...
Update for commit d840039
2018-02-21 19:36:03 +09:00
KATOH Yasufumi
a2fbabedb2
doc: Add lxc.namespace.{clone,keep} to Japanese lxc.container.conf(5)
...
Update for commit 46186ac
2018-02-21 19:27:28 +09:00
KATOH Yasufumi
1fe33b7b90
doc: Update to lxc.namespace.share.* in Japanese lxc.container.conf(5)
...
change from lxc.namespace.* to lxc.namespace.share.*.
Update for commit b074bbf
2018-02-21 18:37:33 +09:00
KATOH Yasufumi
2021665823
doc: add lxc.cgroup2.* to Japanese lxc.container.conf(5)
...
Update for commit 54860ed
2018-02-21 18:34:23 +09:00
Christian Brauner
5038d11a98
utils: include linux/types.h
...
Closes #2178 .
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-21 10:13:12 +01:00
Christian Brauner
e7806b2eff
doc: document cgroup-full:{mixed,ro,rw}:force
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-21 10:06:56 +01:00
Serge Hallyn
6800288122
Merge pull request #2175 from brauner/2018-02-17/coding_style_fixes
...
tree-wide: coding style + fixes
2018-02-19 12:15:36 -06:00
Christian Brauner
49beb65eb9
cgroups: remove cgroup_create_legacy()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 12:56:40 +01:00
Christian Brauner
d2a4d1db03
cgroups: implement "driver" and "driver_version"
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 12:56:25 +01:00
Christian Brauner
1a8848b371
cgroups: remove legacy cgfs cgroup driver
...
The time has come to remove the cgfs cgroup driver as well. I'm doing this for
mainly two reasons:
- potential security issue:
The cgfs cgroup driver has been unmaintained for a long time now. It did not
receive new functionality apart from bugfixes. Now that cgroup2 is a thing
the internal logic how to deal with cgroups has been substantially reworked
for the cgfsng driver. Given that we won't do the same work for the cgfs
driver I smell bugs all over the place in the near future. I don't want to
wake up to a security issue where someone forces LXC to fallback to the cgfs
driver to exploit bugs when e.g. running in a pure unified cgroup layout.
- code complexity:
The cgfs cgroup driver is massively complex since it tried to figure out
where the mountpoint for each legacy cgroup hierarchy is, i.e. it didn't make
simplyfing assumptions like cgfsng does about where the cgroup hierarchies -
legacy or unified - would be mounted. This was appropriate before cgroup
mounting has been standardized. Nowadays, anyone who mounts cgroups not under
/sys/fs/cgroup is on their own. Furthermore, with unified hierarchy cgroup
layouts there will only be a single hierarchy mounted at /sys/fs/cgroup so
there's even less need to drag the complex parsing in cgfs into the future.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 12:49:45 +01:00
Christian Brauner
6812d83301
cgfsng: enable "force" for "cgroup-full"
...
This enables cgroup-full:{mixed,ro,rw}:force and reworks the mount logic.
When cgroup-full was specified we used to bind-mount the cgroups from the host.
That is pretty weird thing to do given that you can simply mount them directly
without going through bind-mounts.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 12:30:51 +01:00
Christian Brauner
becad0ec98
start: cleanup namespace handling
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 11:52:32 +01:00
Christian Brauner
1fd0f41eff
utils: add lxc_set_death_signal()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 10:58:56 +01:00
Christian Brauner
46800e7713
start: non-functional changes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 10:23:32 +01:00
Christian Brauner
134df64540
start: do_destroy_container()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:49:47 +01:00
Christian Brauner
ae3beac9af
start: lxc_destroy_container_on_signal()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:49:29 +01:00
Christian Brauner
4c8e880e32
start: post_start()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:48:03 +01:00
Christian Brauner
984984e4f7
start: start()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:47:46 +01:00
Christian Brauner
c30e9b193e
start: lxc_start()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:47:19 +01:00
Christian Brauner
cfc62c6036
start: lxc_spawn()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:40:43 +01:00
Christian Brauner
e96a536cee
start: do_start()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:27:37 +01:00
Christian Brauner
0e4f9d5169
start: lxc_abort()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:18:08 +01:00
Christian Brauner
c097467fce
start: lxc_fini()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:17:21 +01:00
Christian Brauner
2170b2631f
start: lxc_init()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:11:17 +01:00
Christian Brauner
fdecbc9c46
start: lxc_init_handler()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:01:43 +01:00
Christian Brauner
5032bf399e
start: simplify
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:00:06 +01:00
Christian Brauner
0376021562
start: lxc_poll()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:00:06 +01:00
Christian Brauner
6e94162aae
start: signal_handler()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-19 00:00:04 +01:00
Christian Brauner
a5a70219bc
start: lxc_check_inherited()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:46:37 +01:00
Christian Brauner
9fef335509
start: preserve_ns()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:44:50 +01:00
Christian Brauner
39cd919cb1
start: close_ns()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:42:05 +01:00
Christian Brauner
9e5f5f2fee
start: print_top_failing_dir()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:41:21 +01:00
Christian Brauner
6be5397b86
start: use correct prefix for includes
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:39:04 +01:00
Christian Brauner
300d1cb40a
{commands,start}: remove element from list first
...
First remove the client from the list then close the fd. Otherwise we open
ourselves to a race where another codepath might be writing to a bad file
descriptor.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:20:05 +01:00
Christian Brauner
81084dbd0e
tree-wide: remove locking around openpty()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 23:10:04 +01:00
Christian Brauner
1e1579672b
start: remove duplicate lxc_monitor_send_state()
...
Closes #2177 .
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 22:19:51 +01:00
Christian Brauner
01c1b11e45
lxccontainer: use wait_for_pid()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-18 21:43:46 +01:00
Christian Brauner
b2ac2cb755
cgfsng: __cg_unified_setup_limits()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:49:31 +01:00
Christian Brauner
c347df5846
cgfsng: __cg_legacy_setup_limits()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:48:59 +01:00
Christian Brauner
90e9728449
cgfsng: cg_legacy_set_data()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:47:23 +01:00
Christian Brauner
91d1a13a13
cgfsng: convert_devpath()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:46:44 +01:00
Christian Brauner
eec533e378
cgfsng: cgfsng_set()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:45:12 +01:00
Christian Brauner
e2bd2b133d
cgfsng: cgfsng_get()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:44:52 +01:00
Christian Brauner
0cb10e11f1
cgfsng: cgfsng_attach()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:44:21 +01:00
Christian Brauner
25f66a8fde
cgfsng: __cg_unified_attach()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:43:46 +01:00
Christian Brauner
c40c820909
cgfsng: build_full_cgpath_from_monitorpath()
...
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-17 19:42:17 +01:00
