proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 18:01:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
8,030 Commits 4 Branches 191 Tags 125 MiB
dd8765cad5
Commit Graph

8030 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Renato Westphal
dd8765cad5 babel: fix crashes and improve the redistribute command 
Fixes the following crashes:
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute pim"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute eigrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute nhrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute table"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "no redistribute vnc"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute pim"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute eigrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute nhrp"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute table"
babeld aborted: vtysh -c "configure terminal" -c "router babel" -c "redistribute vnc"

While here, add an option to chose if we want to redistribute IPv4 or
IPv6 routes (e.g. we might want static IPv4 routes only). Also, join the
"no" version of the command in the same DEFUN (Yes We Can).

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-26 11:51:44 -03:00
Renato Westphal
493c8ac787 eigrpd: minor fix in the redistribute command 
Commands like "redistribute stati" and "redistribute osp" were being
silently ignored.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-26 11:51:00 -03:00
Renato Westphal
9b86009a38 bgpd/eigrpd: fix crashes found by the CLI fuzzer 
Fixes the following crashes:
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1 json"
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1"
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show ip bgp l2vpn evpn all 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1 json"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show bgp l2vpn evpn all 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 2001:db8::1/128 json"
* bgpd aborted: vtysh  -c "show bgp ipv4 vpn rd 1:1 2001:db8::1/128"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 1.1.1.1/32 json"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 2001:db8::1/128 json"
* bgpd aborted: vtysh  -c "show bgp ipv6 vpn rd 1:1 2001:db8::1/128"
* bgpd aborted: vtysh  -c "show vnc responses 1.1.1.1/32"
* bgpd aborted: vtysh  -c "show vnc responses 2001:db8::1/128"
* bgpd aborted: vtysh  -c "show vnc responses 11:11:11:11:11:11"
* bgpd aborted: vtysh  -c "show vnc responses"
* eigrpd aborted: vtysh -c "configure terminal" -c "no router eigrp 65535"

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-25 13:58:23 -03:00
Donald Sharp
c6413dd394 Merge pull request #848 from opensourcerouting/rb-tree-fix 
Fix corrupted RB trees
 2017-07-25 11:11:33 -04:00
David Lamparter
d5eb795965 Merge pull request #847 from donaldsharp/cmd_success 
Cmd success
 2017-07-25 16:23:48 +02:00
David Lamparter
4ff218ac39 Merge pull request #838 from dwalton76/lib-copy-nexthops 
lib: copy_nexthops() only copies the first nexthop
 2017-07-25 16:20:08 +02:00
David Lamparter
533450e4b9 Merge pull request #837 from qlyoung/fix-eigrp-routemap-cli 
eigrpd, vtysh: add dummy route-map cli
 2017-07-25 16:15:54 +02:00
David Lamparter
c8ac4457c0 Merge pull request #836 from dwalton76/zebra-debug-packet-send-detail 
zebra: "debug zebra packet" config display
 2017-07-25 16:01:40 +02:00
Renato Westphal
145b205177 lib: fix corrupted RB trees 
Commit 8f942af90 introduced a bug while silencing a clang warning. Silence
the warning in a different way to fix our red-black tree implementation.

Fixes #841.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-24 18:50:45 -03:00
Renato Westphal
52535beec1 lib: revert reindent of files imported from OpenBSD 
We should preserve the original indentation to make it easier to keep
these files in sync with the upstream.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2017-07-24 18:40:24 -03:00
Donald Sharp
9c9d843baa ripd: Fix debug config failures 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 16:00:20 -04:00
Donald Sharp
40e344cc4b ripngd: Fix failure returned with some debug commands 
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2017-07-24 15:59:36 -04:00
David Lamparter
92690ee649 *: fix git-reindent-branch.py reversing order 
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-22 18:00:44 +02:00
David Lamparter
9d303b37d7 Revert "*: reindent pt. 2" 
This reverts commit c14777c6bf.

clang 5 is not widely available enough for people to indent with.  This
is particularly problematic when rebasing/adjusting branches.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-22 14:52:33 +02:00
Daniel Walton
8744028312 lib: copy_nexthops() only copies the first nexthop 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Before the fix NHT had each path resolving via swp1

cel-redxp-10# show ip route 20.0.11.253
Routing entry for 20.0.11.0/24
  Known via "bgp", distance 20, metric 0, best
  Last update 00:00:20 ago
  * 169.254.0.1, via swp1
  * 169.254.0.17, via swp2

cel-redxp-10#

cel-redxp-10# show ip nht
[snip]
20.0.11.253
 resolved via bgp
 via 169.254.0.1, swp1
 via 169.254.0.1, swp1
 Client list: pim(fd 19)

After the fix

cel-redxp-10# show ip nht
[snip]
20.0.11.253
 resolved via bgp
 via 169.254.0.1, swp1
 via 169.254.0.17, swp2
 Client list: pim(fd 19)
 2017-07-20 17:11:43 +00:00
David Lamparter
dceb5f8ac7 *: add git-reindent-branch.py 
This tries to heave a branch over the reindentation step.  Somewhat
tested, don't trust it blindly...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-20 19:09:56 +02:00
Quentin Young
a72730d34a
eigrpd, vtysh: add dummy route-map cli 
eigrpd will successfully accept `(conf)# route-map foo ...` because it
is not sent to eigrpd from vtysh, but of course, this is the classic
node sync syndrome.

Since eigrpd apparently doesn't support proper routemaps yet just add
the cli so we can suppress the vtysh errors.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-20 12:51:57 -04:00
David Lamparter
95b06c0aa5 Merge pull request #834 from dwalton76/ospf6d-show-crash 
ospf6d: crash in ospf6_lsdb_show
 2017-07-19 22:05:23 +02:00
David Lamparter
9fdcca14ca Merge pull request #835 from dwalton76/lib-route-node-lookup 
lib: route_node_lookup() needs to apply_mask() to prefix
 2017-07-19 22:03:36 +02:00
Daniel Walton
94c608d636 zebra: "debug zebra packet" config display 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
 2017-07-19 18:20:02 +00:00
Daniel Walton
b37aead99b lib: route_node_lookup() needs to apply_mask() to prefix 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by:   <qlyoung@cumulusnetworks.com>
 2017-07-19 16:54:24 +00:00
Quentin Young
8ed86a5d20 Merge pull request #828 from tigranmartirosyan/master 
#752 ARP is not updating if mac address changed on remote side
 2017-07-18 12:11:35 -04:00
tmartiro
f26bc77358 Add 1 more identation to correspond to kernel style multi-line comment 2017-07-18 19:06:57 +03:00
Jafar Al-Gharaibeh
04ce08ecd1 Merge pull request #833 from dslicenc/cm16779-bgp-startup-ll 
bgpd: fix peer startup for labeled-unicast if linklocal address not f…
 2017-07-18 10:46:03 -05:00
Quentin Young
e71d2d641f Merge pull request #827 from devicenull/patch-1 
Add note about bridge limitations
 2017-07-18 11:41:11 -04:00
Quentin Young
7b47def8cf Merge pull request #805 from Orange-OpenSource/master 
Add OSPF API and FRR Hacking documents
 2017-07-18 11:34:25 -04:00
Daniel Walton
62d86b87fc ospf6d: crash in ospf6_lsdb_show 
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
 2017-07-18 13:19:47 +00:00
Don Slice
e5f22b3036 bgpd: fix peer startup for labeled-unicast if linklocal address not found 
Problem found in testing where ipv6 labeled-unicast prefixes were not received
on the peers if a "service networking restart" was issued.  Same problem would
happen with an ifdown/ifup on the link to the peer.  Found the problem to be
that peers would establish for labeled-unicast even if a link-local address was
not yet available on the interface toward the peer, causing updates to be sent
without a nexthop value. These were then rejected by the peer. Fix is to delay
peer establishment until after the link-local addresses are available.

Ticket: CM-16779
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed By: Donald Sharp <sharpd@cumulusnetworks.com>
Testing Done: Manual testing successful.  Bgp-smoke completed with no new failures
 2017-07-18 13:09:34 +00:00
tmartiro
d1479ec895 replace space to tabs, add kernel styles multiline, remove trailing whitespaces. 2017-07-18 10:34:21 +03:00
whitespace / reindent
c14777c6bf
*: reindent pt. 2 
w/ clang 5

* reflow comments
* struct members go 1 per line
* binpack algo was adjusted
 2017-07-17 15:26:02 -04:00
devicenull
6e63f8cb52 Add note about bridge limitations 
Add note that Zebra will never be able to detect the master interface for any interface due to IFLA_INFO_SLAVE_KIND not being defined
 2017-07-17 13:04:55 -04:00
David Lamparter
f0735da293 Merge pull request #826 from qlyoung/rm-vtyoutln 
eigrpd: remove last vty_outln
 2017-07-17 18:37:46 +02:00
Quentin Young
2b2f79ae69
eigrpd: remove last vty_outln 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2017-07-17 11:18:56 -04:00
tmartiro
a8a4fa8954 merge with upstream 2017-07-17 17:23:20 +03:00
whitespace / reindent
d62a17aede *: reindent 
indent.py `git ls-files | pcregrep '\.[ch]$' | pcregrep -v '^(ldpd|babeld|nhrpd)/'`

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-17 14:04:07 +02:00
David Lamparter
888ac268a0 *: add indent control files 
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-17 14:00:23 +02:00
Jafar Al-Gharaibeh
13c2f50cd5 Merge pull request #818 from donaldsharp/eigrp_afi 
Eigrp afi
 2017-07-14 12:55:28 -05:00
Donald Sharp
e553b498f1 Merge pull request #820 from opensourcerouting/gcc7 
fix new warnings emitted by GCC 7
 2017-07-14 12:54:40 -04:00
Donald Sharp
9b42781b5d Merge pull request #794 from opensourcerouting/table-hash-ospf6-lsdb-refactor 
use hash in lib/table, also refactor ospf6 lsdb code
 2017-07-14 12:18:06 -04:00
David Lamparter
33cef91932 lib: parser: remove incorrect assert 
A {foo|bar|baz} graph node will have more than 1/2 incoming links even
if no other references are left to it (which is what the assert was
previously trying to ensure.)

I don't see a good way to "fix" the assert so I'm just removing it.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-14 17:53:59 +02:00
David Lamparter
9eb03e7565 Merge pull request #806 from dwalton76/bgpd-set-ipv4-vpn-nexthop 
bgpd: "set ipv4 vpn next-hop 1.1.1.1" is saved/displayed as "set ip vpn next-hop 1.1.1.1"
 2017-07-14 17:37:04 +02:00
David Lamparter
53a37141f9 tests/ospf6d/test_lsdb: remove vty_outln 
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-14 17:32:22 +02:00
David Lamparter
22106bbf68 Merge remote-tracking branch 'frr/master' into table-hash-ospf6-lsdb-refactor 
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-14 17:30:56 +02:00
David Lamparter
3192b3ac46 nhrpd: enable -Werror 
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-14 16:59:44 +02:00
David Lamparter
20a6c6f31f *: fix GCC 7 warnings/issues 
The label initializer & nhrpd variable are just to shut up GCC 7,
the other two are actual bugs.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-14 16:59:44 +02:00
David Lamparter
acd738fc7f *: fix GCC 7 switch/case fallthrough warnings 
Need a comment on these.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2017-07-14 16:59:43 +02:00
Donald Sharp
888efdbb5e Merge pull request #803 from opensourcerouting/redhat-doc-fixes-master 
Redhat doc fixes for master branch
 2017-07-14 10:59:31 -04:00
Russ White
805d1ca6b0 Merge pull request #809 from donaldsharp/evpn_plus_struct_attr 
Evpn plus struct attr
 2017-07-14 09:36:31 -04:00
Donald Sharp
2850f0ea58 bgpd, zebra: Cleanup warnings from new code 
1) Clean up VTY_NEWLINE -> \n
2) Remove usages of VTY_GET_INTEGER

Signed-off-by: Donald Sharp
 2017-07-14 08:52:45 -04:00
Donald Sharp
1ea6b3f237 Merge remote-tracking branch 'origin/master' into evpn_plus_struct_attr 2017-07-14 08:24:46 -04:00