proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-27 22:02:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,876 Commits 4 Branches 191 Tags 125 MiB
c29e9d23bf
Commit Graph

11876 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Russ White
c29e9d23bf
Merge pull request #2581 from qlyoung/fix-vtysh-autocomplete 
vtysh: fix autocomplete garbage printouts
 2018-06-29 13:31:21 -04:00
Russ White
11f13d2333
Merge pull request #2578 from pacovn/Coverity_1453455_Dereference_null_return_value 
bgpd: null check (Coverity 1453455)
 2018-06-29 13:28:28 -04:00
Russ White
33bce37947
Merge pull request #2573 from pacovn/Coverity_23065_Explicit_null_dereferenced 
bgpd: null check (Coverity 23065)
 2018-06-29 13:27:04 -04:00
Russ White
42edc48606
Merge pull request #2514 from pacovn/Coverity_1462467_1465497_Control_flow_issues 
zebra: control flow issues (Coverity 1462467 1465497)
 2018-06-29 13:24:42 -04:00
Quentin Young
b723011d39
Merge pull request #2586 from pacovn/clang_scan_nhrpd_vici_initialization 
nhrpd: uninitialized variable (Clang scan)
 2018-06-29 12:55:55 -04:00
Quentin Young
df6e5a848e
Merge pull request #2587 from pacovn/Clang_scan_dead_code 
isisd zebra: dead code (Clang scan)
 2018-06-29 12:18:38 -04:00
Jafar Al-Gharaibeh
5b03d030d9
Merge pull request #2562 from pacovn/Coverity_1221444_1221446_Out-of-bounds_read 
ospf6d: OoB read (Coverity 1221444 1221446)
 2018-06-29 10:48:33 -05:00
F. Aragon
e36e5b569c
isisd zebra: dead code (Clang scan) 
This correction fixes two bugs detected by Clang scan:

Bug Group: Dead store

Bug Type: Dead assignment
File: zebra/kernel_netlink.c
Function: netlink_parse_extended_ack
Line: 548

Bug Type: Dead increment
File: isisd/isis_lsp.c
Function: lsp_bits2string
Line: 625

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 17:47:05 +02:00
F. Aragon
0a939f4f24
nhrpd: uninitialized variable (Clang scan) 
This correction fixes two bugs detected by Clang scan:

Bug Group: Logic error
Bug Type: Assigned value is garbage or undefined
File: nhrpd/vici.c
Function: vici_parse_message
Lines: 100, 105

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 17:40:45 +02:00
Donald Sharp
798ad23151
Merge pull request #2575 from pacovn/Coverity_1399219_Copy-paste_error 
bgpd: copy-paste error (Coverity 1399219)
 2018-06-29 11:17:52 -04:00
F. Aragon
0866cdaf3e
bgpd: null check (Coverity 1453455) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 11:03:06 +02:00
paco
d4f8b53750
bgpd: null check (Coverity 23065) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 10:48:31 +02:00
paco
b8ce0c3696
ospf6d: OoB read (Coverity 1221444 1221446) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-29 10:39:27 +02:00
Jafar Al-Gharaibeh
d6076845b3
Merge pull request #2561 from pacovn/Coverity_1399231_Logically_dead_code 
lib ospf6d: dead code (Coverity 1399231)
 2018-06-28 14:48:17 -05:00
Quentin Young
8d70e7fe32 vtysh: fix autocomplete garbage printouts 
The semantics for suppressing output received from daemons changed
slightly when pipe actions were introduced, causing raw autocomplete
output to be printed where it shouldn't have been.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-28 18:37:01 +00:00
Quentin Young
d55c2456e8
Merge pull request #2576 from pacovn/Coverity_1399228_Logically_dead_code 
bgpd: dead code (Coverity 1399228)
 2018-06-28 12:55:25 -04:00
Quentin Young
1db6d24497
Merge pull request #2572 from pacovn/Coverity_1399203_Unchecked_return_value 
bgpd: return value (Coverity 1399203)
 2018-06-28 12:35:58 -04:00
Quentin Young
c2d64eacde
Merge pull request #2579 from pacovn/Coverity_1424370_Unchecked_return_value_from_library 
isisd: return check (Coverity 1424370)
 2018-06-28 12:25:45 -04:00
Quentin Young
2587508e87
Merge pull request #2580 from pacovn/Coverity_1424529_Dereference_after_null_check 
isisd: null check (Coverity 1424529)
 2018-06-28 12:23:56 -04:00
F. Aragon
c46df7876a
isisd: null check (Coverity 1424529) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 16:48:37 +02:00
F. Aragon
aa979109f2
isisd: return check (Coverity 1424370) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 16:31:37 +02:00
paco
b684aedac8
bgpd: dead code (Coverity 1399228) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:56:29 +02:00
paco
f86285ffef
bgpd: copy-paste error (Coverity 1399219) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 15:39:59 +02:00
paco
da3b87f8b0
bgpd: return value (Coverity 1399203) 
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 12:41:52 +02:00
paco
a35fb78f1c
ospf6d: dead code (Coverity 1399231) 
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-28 11:50:49 +02:00
Quentin Young
62a9c814e1
Merge pull request #2563 from pacovn/Coverity_1465494_String_not_null_terminated_2 
lib zebra: str-z check (2) (Coverity 1465494)
 2018-06-27 15:15:22 -04:00
Quentin Young
7f3ad069d7
Merge pull request #2570 from pacovn/Coverity_1448386_Untrusted_value_as_argument 
lib: untrusted argument (Coverity 1448386)
 2018-06-27 15:09:34 -04:00
Jafar Al-Gharaibeh
904124c1ec
Merge pull request #2569 from pacovn/Coverity_1451361_Dereference_before_null_check_2 
lib: null check (2) (Coverity 1451361)
 2018-06-27 13:51:48 -04:00
Jafar Al-Gharaibeh
e3660a21a4
Merge pull request #2566 from pacovn/Coverity_23024_Dereference_null_return 
ospf6d: null check (Coverity 23024)
 2018-06-27 13:49:08 -04:00
Jafar Al-Gharaibeh
8bd98c6b15
Merge pull request #2564 from pacovn/Coverity_23110_Dereference_after_null_check 
ospfd: null check (Coverity 23110)
 2018-06-27 13:47:47 -04:00
paco
45ec351df2
lib: untrusted argument (Coverity 1448386) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 15:50:04 +02:00
paco
4872511153
ospf6d: null check (Coverity 23024) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 15:31:05 +02:00
paco
64268e1a12
lib: null check (2) (Coverity 1451361) 
Additional correction to fa3016309b

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 15:24:45 +02:00
paco
4adf00f765
ospfd: null check (Coverity 23110) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 14:41:50 +02:00
paco
b6312ad185
lib zebra: str-z check (2) (Coverity 1465494) 
This is an additional correction after  45981fda06 / PR #2462. I hope
this fixes the Coverity warning (I've added an additional check for ensuring
the string provided by the inotify read is zero-terminated).

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-27 14:22:01 +02:00
Donald Sharp
71a7b1f82f
Merge pull request #2556 from pacovn/Coverity_1465491_Untrusted_value_as_argument_3 
pimd: untrusted argument (3) (Coverity 1465491)
 2018-06-26 19:59:27 -04:00
Quentin Young
81ef2361a3
Merge pull request #2559 from pacovn/Coverity_1302503_Logically_dead_code 
lib ospfd: dead code (Coverity 1302503 1302502)
 2018-06-26 16:48:54 -04:00
paco
39050c7e0d
lib ospfd: dead code (Coverity 1302503 1302502) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 21:39:56 +02:00
Quentin Young
045a178c13
Merge pull request #2560 from pacovn/Coverity_1302500_Constant_variable_guards_dead_code 
ospfd: dead code (Coverity 1302500)
 2018-06-26 15:05:53 -04:00
Quentin Young
cccb13bff1
Merge pull request #2557 from pacovn/Coverity_1465490_Unchecked_return_value 
pimd: return check (Coverity 1465490)
 2018-06-26 14:42:30 -04:00
paco
9df48e81ee
ospfd: dead code (Coverity 1302500) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 20:33:47 +02:00
paco
d1b21b9616
pimd: return check (Coverity 1465490) 
Unless someone intentionally changes MCAST_ALL_ROUTERS ("224.0.0.2") with a
wrong IP, this should never fail, so the fix is using "(void)" at the left
of the function call, as an explicit way of indicating we discard the
return value on purpose.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 19:34:04 +02:00
Quentin Young
cf6bc77d28
Merge pull request #2503 from pacovn/Coverity_1469898_Uninitialized_scalar_variable 
lib: uninitialized variable (2) (Coverity 1469898)
 2018-06-26 11:35:58 -04:00
Quentin Young
c1802707e0
Merge pull request #2463 from pacovn/Coverity_1452539_Out-of-bounds_access 
lib: out-of-bounds access (Coverity 1452539)
 2018-06-26 11:34:31 -04:00
Russ White
8394a34484
Merge pull request #2534 from pacovn/Coverity_1470113_Untrusted_array_index_write 
zebra: untrusted array index (2) (Coverity 1470113)
 2018-06-26 11:18:38 -04:00
Russ White
4bca4c6f0c
Merge pull request #2540 from LabNConsulting/working/master/bgp-twice-leaked-nht 
bgpd: don't nexthop-track twice-leaked routes that came from zebra
 2018-06-26 11:17:32 -04:00
Russ White
dec20a1570
Merge pull request #2542 from pacovn/Coverity_1452552_Out-of-bounds_access 
isisd: out-of-bounds access (Coverity 1452552)
 2018-06-26 11:15:59 -04:00
Russ White
f1b5eeea03
Merge pull request #2545 from pacovn/Coverity_1468413_Explicit_null_dereferenced 
bgpd: null check (Coverity 1468413)
 2018-06-26 11:14:39 -04:00
paco
813099f0fc
pimd: untrusted argument (3) (Coverity 1465491) 
Additional fix over d94023d85c (PR #2546)

Removed all pointer arithmetic used for the checks, while keeping same
coverage. I hope this removes the Coverity warning (If this don't fix it, I'll
make Coverity work with a fork and try there as many times as necessary)

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 17:14:36 +02:00
Russ White
884cc57a96
Merge pull request #2547 from pacovn/Coverity_1458168_Dereference_null_return_value 
eigrpd ospfd: null check (Coverity 1458168 1455335)
 2018-06-26 11:14:07 -04:00