Donald Sharp
49201fe505
Merge pull request #7491 from volta-networks/fix_ebgp_mhop_reset
...
bgpd: avoid needless ebgp-multihop session reset
2020-11-10 18:50:10 -05:00
Russ White
dfe016b06b
Merge pull request #7495 from qlyoung/doc-fuzzing
...
Doc fuzzing
2020-11-10 16:48:31 -05:00
Donald Sharp
9a3efff6ac
Merge pull request #7500 from mjstapp/fix_topo_scale_mem
...
tests: reduce scale of the route scale test
2020-11-10 16:40:53 -05:00
Donald Sharp
02a17eaddf
Merge pull request #7498 from mjstapp/fix_topo_count_only
...
tests: only test count of nexthops in bgp max-paths test
2020-11-10 15:17:59 -05:00
Mark Stapp
3adb21ea4e
Merge pull request #7482 from AnuradhaKaruppiah/evpn-sticky-fix
...
zebra: Set NUD_NOARP on sticky MAC entries in addition to NTF_STICKY
2020-11-10 15:13:10 -05:00
Quentin Young
9da6c9bf20
Merge pull request #7499 from mjstapp/fix_topo_dup_verify_fib
...
tests: remove duplicate verify_fib_routes from common_config.py
2020-11-10 15:02:42 -05:00
Mark Stapp
d6a75b53e7
tests: reduce scale of the route scale test
...
Reduce the number of routes used in the route-scale test: we're
having memory troubles, and this may help the CI run with fewer
false failures. Also re-orged the route-scale test code a bit
so it can be driven from the json file, with fewer hard-coded
values.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-10 14:14:23 -05:00
Jafar Al-Gharaibeh
3d73df359a
Merge pull request #7484 from donaldsharp/nhrp_leak
...
nhrpd: Fix memory leak on shutdown
2020-11-10 10:25:16 -06:00
Donald Sharp
42e122614b
Merge pull request #7448 from mjstapp/fix_gcc10_formats
...
* : clean up format specifiers for gcc-10
2020-11-10 11:23:02 -05:00
Russ White
087336f5de
Merge pull request #7445 from ranjanyash54/dev_4
...
ospf6d: Json support added for command "show ipv6 ospf6 neighbor [json]"
2020-11-10 11:15:02 -05:00
Mark Stapp
c57638d6fd
tests: remove duplicate verify_fib_routes from common_config.py
...
There were two copies of the function - we only need one.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-10 10:06:48 -05:00
Mark Stapp
15df6d3165
tests: only test count of nexthops in bgp max-paths test
...
Add support to compare the number of RIB nexthops, rather than the
specific nexthop addresses. Use this in the bgp_ecmp topotests that
test maximum-paths - testing the specific nexthops is wrong there,
it's not deterministic and we get spurious failures.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-10 09:58:15 -05:00
Donatas Abraitis
4b0e387075
Merge pull request #7463 from louis-oui/netnsname
...
lib: change limit of netns name from 15 to 35 characters
2020-11-10 09:39:43 +02:00
Quentin Young
4b9049fa31
doc: fix vrrp block quote
...
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-11-09 16:19:13 -05:00
Quentin Young
e869d3f0c7
doc: use anonymous link refs
...
rst...
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-11-09 15:25:26 -05:00
Quentin Young
e862bcc572
doc: add docs on fuzzing stuff
...
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-11-09 15:25:26 -05:00
Quentin Young
6e3cb61de1
Merge pull request #7494 from mjstapp/fix_basic_title_levels
...
doc: fix sphinx complaint about indent levels
2020-11-09 15:24:25 -05:00
Mark Stapp
d71b915695
doc: fix sphinx complaint about indent levels
...
There was an inconsistency in the characters used for the second
level of title/section hierarchy - fix it.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-09 12:44:44 -05:00
Emanuele Di Pascale
8ffeaddb5f
bgpd: avoid needless ebgp mhop reset
...
if the user sets the ebgp-multihop for a neighbor to the same value
we currently have, avoid resetting the session and just return a
silent success.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2020-11-09 13:54:35 +01:00
Louis Scalbert
990374e1d2
lib: change limit of netns name from 15 to 35 characters
...
Extend the size of netns name to match linux permitted netns name size
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2020-11-09 11:24:53 +01:00
Donatas Abraitis
340434461b
Merge pull request #7487 from donaldsharp/reformat_rfapi
...
bgpd: Fix rfapi indentation issues with a for loop
2020-11-08 17:09:23 +02:00
Donald Sharp
9929134ab8
Merge pull request #7486 from ton31337/fix/bgp_debug_keepalives_docstring
...
bgpd: Correct CLI description for `debug bgp keepalives`
2020-11-07 19:20:15 -05:00
Donald Sharp
841d18ab2e
bgpd: Fix rfapi indentation issues with a for loop
...
I am not even sure how this compiles or what it is supposed
to do from a c perspective :(
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-07 11:43:44 -05:00
Donatas Abraitis
2e1bc8cf41
Merge pull request #7462 from qlyoung/fix-misc-doc-issues
...
Fix misc doc issues
2020-11-07 17:26:46 +02:00
Donatas Abraitis
6084908ec8
Merge pull request #7477 from chiragshah6/yang_dev
...
bgpd: fix compiler warnings in nbr cmd
2020-11-07 17:25:37 +02:00
Donatas Abraitis
bc6bc7a8de
bgpd: Correct CLI description for debug bgp keepalives
...
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-11-07 17:24:21 +02:00
Donatas Abraitis
e114e3278d
Merge pull request #7480 from donaldsharp/bgp_defer_bad_donald
...
bgpd: Fix mistakes in defer working
2020-11-07 12:21:27 +02:00
Donatas Abraitis
89fccd9341
Merge pull request #7470 from donaldsharp/bgp_group
...
bgpd: Actually return the group peer
2020-11-07 12:19:47 +02:00
Donald Sharp
7df171f59a
nhrpd: Fix memory leak on shutdown
...
On shutdown we were blantantly dropping the node->info
data. Make it happy.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-06 20:56:02 -05:00
Anuradha Karuppiah
60e372e9cb
zebra: Set NUD_NOARP on sticky MAC entries in addition to NTF_STICKY
...
(ndm_state & NUD_NOARP) - prevents the entry from expiring
(ndm_flags & NTF_STICKY) - prevents station moves on the entry
Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
2020-11-06 17:21:12 -08:00
Donald Sharp
6338d24218
bgpd: Fix mistakes in defer working
...
Commit: 26742171e6
2020-11-06 19:13:59 -05:00
Donald Sharp
3bb43118ec
Merge pull request #7473 from eololab/fix-crash-bfdd-show-counters-json
...
bfdd: fix crash on show bfd peers counters json
2020-11-06 18:40:07 -05:00
Chirag Shah
555c8ab7ad
bgpd: fix compiler warnings in nbr cmd
...
Addressed the gcc-10 buffer overflow warnings.
Put a sanity check of not using prefix for
neighbor update-source with interface option.
Signed-off-by: Chirag Shah <chirag@nvidia.com>
2020-11-06 11:43:36 -08:00
Emanuele Bovisio
1d923374f6
bfdd: fix crash on show bfd peers counters json
...
wrong pointer passed to bfd_id_iterate function
Signed-off-by: Emanuele Bovisio <emanuele.bovisio@eolo.it>
2020-11-06 17:34:56 +01:00
Olivier Dugeon
6403fc8725
Merge pull request #7385 from opensourcerouting/isisd-prefix-sid-collision
...
isisd: detect Prefix-SID collisions and handle them appropriately
2020-11-06 12:21:37 +01:00
Donald Sharp
164f94a452
Merge pull request #7466 from idryzhov/fix-bfd-null-deref
...
bfdd: fix possible null dereference
2020-11-05 20:54:02 -05:00
Donald Sharp
e5209541f2
bgpd: Actually return the group peer
...
The code is returning the group peer data structure, which
is what is happening but we should not have assignment statements
in this return statement for a `struct peer *` return.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-05 20:44:31 -05:00
Russ White
9f6c4d4d16
Merge pull request #7227 from chiragshah6/yang_dev
...
bgpd, yang : neighbor and peer-group config cmds to transactional clis
2020-11-05 14:32:39 -05:00
Donald Sharp
9811fcdca3
Merge pull request #7137 from kssoman/ospf
...
ospf6d : Intra area route for connected prefix not installed
2020-11-05 11:57:50 -05:00
Igor Ryzhov
1db60b576b
bfdd: fix possible null dereference
...
bs->ifp may be null, so we should check it before dereferencing.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-05 19:46:27 +03:00
Mark Stapp
f52e45dbdb
Merge pull request #7459 from donaldsharp/clang_more_stuff_to_cleanup
...
Clang more stuff to cleanup
2020-11-05 08:25:40 -05:00
Russ White
40ef77c702
Merge pull request #7423 from donaldsharp/route_list
...
bgpd: Remove pointer structure from `struct bgp_dest`
2020-11-05 07:29:54 -05:00
github login name
6a5bb30062
ospf6d: Json support added for command "show ipv6 ospf6 neighbor [json]"
...
Modify code to add JSON format output in show command
"show ipv6 ospf6 neighbor" with proper formating
Signed-off-by: Yash Ranjan <ranjany@vmware.com>
2020-11-04 22:44:21 -08:00
Donald Sharp
56c226e773
bgpd: Cleanup memory leaks associated with t_router_timer
...
We are allocating temporary memory for information about
what to process in this thread, which is not being cleaned
up on thread cancelling.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-04 21:02:57 -05:00
Quentin Young
4eddb67834
doc: add crosslink to developer docs
...
for source build instructions
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-11-04 17:33:17 -05:00
Quentin Young
d7432defac
doc: explain integrated config
...
This is poorly documented and confusing to users
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-11-04 17:29:58 -05:00
Quentin Young
3ea3aff99d
doc: add troubleshooting info for vrrp
...
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
2020-11-04 17:21:33 -05:00
Mark Stapp
72327cf3e7
* : clean up format specifiers for gcc-10
...
gcc 10 complains about some of our format specs, fix them. Use
atomic size_t in thread stats, to work around platform
differences.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-04 16:56:17 -05:00
Russ White
898fde3c1d
Merge pull request #7456 from donaldsharp/flowspec_issues
...
Rules and why they are made to be broken
2020-11-04 15:41:35 -05:00
Donald Sharp
26742171e6
bgpd: Remove pointer structure from struct bgp_dest
...
The `struct listnode *rt_node` data structure is adding
8 bytes of size to the `struct bgp_dest`. This is a large
amount of data for a flag we are already setting on each
node for this. Just set the flag and use that to figure
out who we are doing graceful restart on.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-04 15:18:01 -05:00
