The dimensions sent by the remote end are redundant and should not be
trusted.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
The returned value from do_pointer_grab() is treated as a boolean - grab
was successful or not. Change the function to return a boolean value.
Reported-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
We check that there is a matching frame in the queue before popping the
old ones. So we know the inner loop will find a match and thus that
frame will not be NULL. But figuring that out is too hard for the
compiler.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Reported-by: Marc-André Lureau <marcandre.lureau@gmail.com>
manywarnings.m4 update will bring new flags that fail with some
glib/gst headers.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
In file included from
../spice-common/common/client_marshallers.h:29:0,
from ../src/spice-channel-priv.h:35,
from ../src/spice-file-transfer-task-priv.h:28,
from file-transfer.c:3:
../spice-common/common/messages.h:45:23: fatal error: libcacard.h: No such file or directory
compilation terminated.
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Fix all the gtk-doc: "unused declarations. They should be added to
spice-gtk-sections.txt in the appropriate place."
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Fixes the following warning:
../../src/vmcstream.c:124: warning: Symbol name not found at the start of the comment block.
../../src/win-usb-driver-install.c:347: warning: Symbol name not found at the start of the comment block.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
This make possible to rename the function to
spice_file_transfer_task_handle_status as a handler for
VDAgentFileXferStatusMessage for a specific task.
This change is related to split SpiceFileTransferTask from
channel-main.
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Acked-by: Jonathon Jongsma <jjongsma@redhat.com>
They are only supposed to be changed when receiving the relevant server
message.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
When the display is not yet realized, spice_display_widget_gl_scanout()
will fail because the egl context is not ready. The display is never
marked ready because the egl.image (and egl.scanout) is not set, and
some clients, such as virt-viewer will not realize the widget until the
display is ready.
Deal with gl scanout updates when the widget is not yet realized, and
mark the display as ready when egl is enabled (when last display draw
signal is from gl).
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
spice_cairo_draw_event() can deal with d->canvas.surface == NULL.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
spice-gtk used to have x11/shm backend, now it's only cairo
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
glEGLImageTargetTexture2DOES() changes the current bound texture. If
the last texture bound is the cursor, update_scanout() will modify the
cursor texture, instead of the display.
Fix regression from commit 3539ac6212.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Fixes lz decompression crash:
https://bugzilla.redhat.com/show_bug.cgi?id=1285469
Christophe Fergeau (5):
Remove 2 unused vfuncs from client_marshallers.h
tests: Fix glib version check
log: Clamp SPICE_DEBUG_LEVEL if it's too high
log: Use SPICE_CONSTRUCTOR_FUNC
log: Make sure glib threading is initialized
Eduardo Lima (Etrunko) (2):
Fix build in systems with Glib version older than 2.38
2/2] Add check for openssl
Fabiano Fidêncio (7):
coverity: avoid use after free
coverity: avoid resource leak
coverity: avoid dereference after null check
coverity: avoid division or modulo by zero
coverity: remove unused value
coverity: remove structurally dead code
Use g_getenv() instead of getenv()
Frediano Ziglio (6):
Cap logging level to the valid bounds
tests: exit on SIGABRT
define SPICE_CONSTRUCTOR_FUNC and SPICE_DESTRUCTOR_FUNC macros
use macro to define constructor function
fix 16 bpp LZ image decompression
Explicitly specify size of SpiceMsgSmartcardData
Lin Ma (1):
build-sys: Define opengl GL_LIBS and GL_CFLAGS in generated Makefile.in
Pavel Grunt (3):
Define canvas_fix_alignment when is used
test-logging: Include stdlib.h for _Exit()
Remove GL support
On X11, each widget has its own context. Make sure we are using the
widget associated context when using gl.
With gtk 3.16, glEGLImageTargetTexture2DOES() can be called during
update scanout, since we can call gtk_gl_area_make_current(). On < 3.16,
do it before drawing.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1337721
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>
This is global to the display connection: all egl resources will be
released, including those from other widgets or from the application.
Fix spice/virgl display being rendered black after another widget
display is destroyed.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>
The egl context is from Gtk on Wayland. Destroy it only on X11.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>
Since 8943d2329, the channel may be disconnected from the session
before it's destroyed. In this case, session is NULL.
Fixes some critical with virt-manager when closing a display:
(virt-manager:20451): GSpice-CRITICAL **: spice_session_is_for_migration: assertion 'SPICE_IS_SESSION(session)' failed
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
They are no longer needed since 0a9ec4ec0.
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
This new Gdk API allows in Windows to retrieve the raw scancodes sent
by Windows.
This allows us to do some translations getting the right value without
many hacks and supporting all possible layouts.
Windows convert the scancodes into virtual key codes. The translation is
1 -> N based on different condition. Also a single virtual key code can
be originated from different scancodes. This make quite complicated
(if not impossible) to get the original scancode from the hardware_keycode
field (which in Windows is the virtual key).
The additional check for native_scancode after calling this function
allows to support key injection.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
This means future video codecs may be supported automatically.
One can also force usage of decodebin by setting $SPICE_GSTVIDEO_AUTO.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
This makes it possible to test the GStreamer video decoder with MJPEG
streams.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
