qemu-server/PVE
Fiona Ebner 089aed811d cfg2cmd: netdev: fix value for tx_queue_size
Quoting from QEMU commit 4271f40383 ("virtio-net: correctly report
maximum tx_queue_size value"):

> Maximum value for tx_queue_size depends on the backend type.
> 1024 for vDPA/vhost-user, 256 for all the others.

> So the parameter is silently ignored and ethtool reports a different
> value than the one provided by the user.

Indeed, for a non-vDPA/vhost-user netdev, the guest will see TX: 256
instead of the specified 1024 here. With the mentioned QEMU commit (in
master and will be part of 8.1), using 1024 will be a hard error:

> Invalid tx_queue_size (= 1024), must be a power of 2 between 256 and 256

Since neither vhost-user, nor vhost-vdpa netdev types are exposed by
Proxmox VE, just changing the limit to the correct 256 should be fine.
No obvious issue during live-migration found.

Fixes: 620d6b32 ("virtio-net: increase defaults rx|tx-queue-size to 1024")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2023-07-27 13:14:12 +02:00
..
API2 migration: alloc nbd disks: fix fall-back for remote live migration 2023-07-27 10:05:20 +02:00
CLI qm: remote migration: improve error when storage cannot be found 2023-06-09 09:49:40 +02:00
QemuServer cloudinit: restore previous default for package upgrades 2023-06-21 12:40:58 +02:00
VZDump vzdump: pbs: factor out getting and checking encryption keys 2023-07-06 17:44:18 +02:00
Makefile buildsys: use $(MAKE) instead of make 2019-09-24 18:06:16 +02:00
QemuConfig.pm qemuserver: foreach_volid: always include pending disks 2023-06-21 12:48:11 +02:00
QemuMigrate.pm migration: fix issue with qcow2 cloudinit disk live migration 2023-06-21 12:48:11 +02:00
QemuServer.pm cfg2cmd: netdev: fix value for tx_queue_size 2023-07-27 13:14:12 +02:00
QMPClient.pm remove left-over mentions of to-be-dropped, outdated QMP commands 2023-06-07 19:36:45 +02:00