proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-06-12 21:41:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cloudinit: restore previous default for package upgrades

Browse Source 
Commit efa3355d ("fix #3428: cloudinit: add parameter for upgrade on
boot") changed the default, but this is a breaking change. The bug
report was only about making the option configurable.

The commit doesn't give an explicit reason for why, and arguably,
doing the upgrade is not an issue for most users. It also leads to a
different cloud-init instance ID, because of the different setting,
which in turn leads to ssh host key regeneration within the VM.

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2023-06-21 12:04:32 +02:00 committed by Thomas Lamprecht
parent 178c355ded
commit ec11b92abb
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PVE/QemuServer.pm
View File

@ -786,7 +786,7 @@ my $confdesc_cloudinit = {
optional => 1,
type => 'boolean',
description => 'cloud-init: do an automatic package upgrade after the first boot.',
default => 0,
default => 1,
},
cicustom => {
optional => 1,

2
PVE/QemuServer/Cloudinit.pm
View File

@ -148,7 +148,7 @@ sub cloudinit_userdata {
$content .= " - default\n";
}
$content .= "package_upgrade: true\n" if $conf->{ciupgrade};
$content .= "package_upgrade: true\n" if !defined($conf->{ciupgrade}) || $conf->{ciupgrade};
return $content;
}