proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-04-29 03:40:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

migration: fail when aliased volume is detected

Browse Source 
Aliased volids can lead to unexpected behavior in a migration.

An aliased volid can happen if we have two storage configurations,
pointing to the same place. The resulting 'path' for a disk image
will be the same.
Therefore, stop the migration in such a case.

The check works by comparing the path returned by the storage plugin.

We decided against checking the storages themselves being aliased. It is
not possible to infer that reliably from just the storage configuration
options alone.

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
This commit is contained in:
Aaron Lauterer 2023-06-19 11:29:33 +02:00 committed by Fiona Ebner
parent 60404e3c1a
commit 07f2e57c98
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
PVE/QemuMigrate.pm
View File

@ -316,12 +316,12 @@ sub scan_local_volumes {
my $storecfg = $self->{storecfg};
eval {
# found local volumes and their origin
my $local_volumes = $self->{local_volumes};
my $local_volumes_errors = {};
my $other_errors = [];
my $abort = 0;
my $path_to_volid = {};
my $log_error = sub {
my ($msg, $volid) = @_;
@ -411,6 +411,8 @@ sub scan_local_volumes {
die "owned by other VM (owner = VM $owner)\n"
if !$owner || ($owner != $vmid);
$path_to_volid->{$path}->{$volid} = 1;
return if $attr->{is_vmstate};
if (defined($snaprefs)) {
@ -444,6 +446,12 @@ sub scan_local_volumes {
}
});
for my $path (keys %$path_to_volid) {
my @volids = keys $path_to_volid->{$path}->%*;
die "detected not supported aliased volumes: '" . join("', '", @volids) . "'"
if (scalar(@volids) > 1);
}
foreach my $vol (sort keys %$local_volumes) {
my $type = $replicatable_volumes->{$vol} ? 'local, replicated' : 'local';
my $ref = $local_volumes->{$vol}->{ref};