From 07f2e57c983cf095d80a60811def0b9821f1e5d4 Mon Sep 17 00:00:00 2001 From: Aaron Lauterer Date: Mon, 19 Jun 2023 11:29:33 +0200 Subject: [PATCH] migration: fail when aliased volume is detected Aliased volids can lead to unexpected behavior in a migration. An aliased volid can happen if we have two storage configurations, pointing to the same place. The resulting 'path' for a disk image will be the same. Therefore, stop the migration in such a case. The check works by comparing the path returned by the storage plugin. We decided against checking the storages themselves being aliased. It is not possible to infer that reliably from just the storage configuration options alone. Reviewed-by: Fiona Ebner Signed-off-by: Aaron Lauterer --- PVE/QemuMigrate.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 97a9fbba..1e19d838 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -316,12 +316,12 @@ sub scan_local_volumes { my $storecfg = $self->{storecfg}; eval { - # found local volumes and their origin my $local_volumes = $self->{local_volumes}; my $local_volumes_errors = {}; my $other_errors = []; my $abort = 0; + my $path_to_volid = {}; my $log_error = sub { my ($msg, $volid) = @_; @@ -411,6 +411,8 @@ sub scan_local_volumes { die "owned by other VM (owner = VM $owner)\n" if !$owner || ($owner != $vmid); + $path_to_volid->{$path}->{$volid} = 1; + return if $attr->{is_vmstate}; if (defined($snaprefs)) { @@ -444,6 +446,12 @@ sub scan_local_volumes { } }); + for my $path (keys %$path_to_volid) { + my @volids = keys $path_to_volid->{$path}->%*; + die "detected not supported aliased volumes: '" . join("', '", @volids) . "'" + if (scalar(@volids) > 1); + } + foreach my $vol (sort keys %$local_volumes) { my $type = $replicatable_volumes->{$vol} ? 'local, replicated' : 'local'; my $ref = $local_volumes->{$vol}->{ref};