pve-manager/PVE/API2/Ceph
Stoiko Ivanov c92fc8a1e8 api2: osd destroy: untaint device before pvremove
We get the device list from ceph-volume lvm list, and decode the json
output, which at that point is tainted (perlsec (1)).
Untaint it here before calling, because it is currently the only
call-site using the information in a problematic way (run_command).
(the only other call-site being in pve5to6)

Alternatively we could untaint while reading the information, but then
should only return a small subset of the ceph-volume output.

The issue is most likely due to
cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 in pve-common ('run_command:
improve performance for logging and long lines'),

Tested on a virtual testsetup by creating OSDs with second DB disk,
and destroying it via GUI (did not manage to get the error without the
DB disk)

Reported via our community forum:
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2020-11-24 23:37:33 +01:00
..
FS.pm ceph tools: factor out frequent keyring and config init check 2019-07-23 07:48:45 +02:00
Makefile ceph: move Monitor API calls to API2/Ceph/MON.pm 2018-12-20 09:44:01 +01:00
MDS.pm ceph: make all service name regexes the same 2020-03-04 15:38:09 +01:00
MGR.pm ceph: make all service name regexes the same 2020-03-04 15:38:09 +01:00
MON.pm Make PVE6 compatible with supported ceph versions 2020-06-03 14:23:38 +02:00
OSD.pm api2: osd destroy: untaint device before pvremove 2020-11-24 23:37:33 +01:00