Go to file
Stoiko Ivanov c92fc8a1e8 api2: osd destroy: untaint device before pvremove
We get the device list from ceph-volume lvm list, and decode the json
output, which at that point is tainted (perlsec (1)).
Untaint it here before calling, because it is currently the only
call-site using the information in a problematic way (run_command).
(the only other call-site being in pve5to6)

Alternatively we could untaint while reading the information, but then
should only return a small subset of the ceph-volume output.

The issue is most likely due to
cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 in pve-common ('run_command:
improve performance for logging and long lines'),

Tested on a virtual testsetup by creating OSDs with second DB disk,
and destroying it via GUI (did not manage to get the error without the
DB disk)

Reported via our community forum:
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2020-11-24 23:37:33 +01:00
aplinfo aplinfo: update shipped index 2020-11-16 18:06:16 +01:00
bin fix #2890: also detect & renew DNS-only ACME certs 2020-07-27 10:53:32 +02:00
configs buildsys: fixup: fully remove pve-apt-hook mentionings 2019-06-28 10:57:03 +02:00
debian bump version to 6.2-17 2020-11-24 16:01:48 +01:00
network-hooks ifupdown1: bridgevlan: add bridge-vids list support 2020-01-11 17:22:46 +01:00
PVE api2: osd destroy: untaint device before pvremove 2020-11-24 23:37:33 +01:00
services pvesr service: order after pve-cluster 2019-11-28 10:54:12 +01:00
test backup: include IDs for non-existent guests 2020-10-22 16:29:26 +02:00
www ui: storage content: add encryption and verification columns for PBS 2020-11-24 23:36:02 +01:00
.gitignore Extend the .gitignore(s) 2018-05-04 14:50:04 +02:00
defines.mk fix #844: allow to pre-delay start-all-marked guests on boot 2019-11-20 20:20:58 +01:00
Makefile pvecfg: adapt version and release semantic 2019-05-26 16:11:43 +02:00
spice-example-sh doc: spice-example-sh: support special characters in passwords 2017-10-05 13:57:27 +02:00
vzdump-hook-script.pl vzdump-hook-script: rename TARFILE to TARGET 2020-07-14 10:27:18 +02:00