This help button is meant to be added on InputPanels, where a
link to an online documentation chapter or subschapter is available.
Clicking on the help button will open the help in a new
browser tab.
Original idea similar to the pfSense GUI.
in my commit 685b7aa4c5
i introduced a bug with that an item gets selected
in the tree when you right click on it
also fix the function parameters
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
If the socket couldn't be created (e.g. FQDN not resolvable) we
continued witouth any hint, when actualy writing the data we then
die'd. The user then does not really know why, so report errors
if the socket creation failed.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
We only allowed servers with the dns-name format, as such status
server may often be in internal networks and with no hostname
(testing, small network so no dns, ...) do not limit the
configuration possibilities with no reason.
Also move the base property part to the base Status class, all
current plugins use server and port so no need for double
declaration of format/descriptions.
If a future plugin doesn't need them it can omit them by not
returning the respective properties in the options method
inherited by SectionConfig.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
since extjs5 Store.snapshot does not exist anymore,
we didnt remove filtered records
this lead to the fact, that the 'message' record did
not get removed and a "no subscription file" message
was shown directly after uploading a key
to get also the filtered records in the store
we use store.getData().getSource()
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we had the function for the cmdmenu at two
different places (resourcetree and resourcegrid)
move it to PVE.Utils to reuse code, and
also use it in pool members list
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
if we do not disable the storageselector with bind mounts,
it automatically sets the first storage which can hold
containers (because of allowBlank: false) and triggers
the dirty flag but clicking on reset does not delete
the value there
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
V3 changelog:
-fix test of zero value id
please note that even if ceph(osd|mon).target are currently not available in ceph packages,
they are not used by proxmox api currently, because we always specify an id to a service.
targets are used to start/stop all services at the same time. Starting speficic serviceid is
done through ceph-(osd|mon)@.service files.
V2 changelog :
- remove setsid
- use [A-Za-z0-9]{1,32} pattern for services
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
since we can simply use the first free one, omit the
selection combobox.
disable the add button if we have 10 or more network
devices
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
The framework value of 100 is not enough for many of our description
fields.
Setting this at the parent component level allow to remove
the end component setting.
the hotplugselector was not good to use,
and the options were confusing (empty was the default value, etc)
now we have checkboxes for each value, and if none are selected,
hotplug is disabled
also fixes the renderer when hotplug is set to '1' which
just means the default of 'disk,network,usb'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we only checked for grouping attributes for moved vms,
but this is only true in server view
e.g. in pool view the grouping attributes is pool
and the item is not reselected, resulting in a "file not found"
error (it looks for the conf on the wrong node)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Carbon (particularly carbon-c-relay) expects one metric per line.
Current PVE implementation breaks this rule.
Committed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this patch fixes an access to an undefined value
if a disk/cd/network device was pending
also improve how this is displayed:
instead of
****
undefined
new value
****
show just the new value
this occured when having a new disk under pending,
or having a disk removal under pending
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
From ExtJS4 to 6 the debug files have doubled in size from
4.4MB to 8.8MB
HTTPServer.pm compress these files on the fly before sending them
to the browser (as "Accept-Encoding: gzip" is the default in
browsers)
On very slow systems (AMD Bobcat for instance, as discussed in
https://forum.proxmox.com/threads/no-webfrontend-showed-in-browser-with-new-gui-pvetest.26951/#post-135699
the compression of this file can take up to 5 seconds, and this will
hit the HTTP Timeout (line 1629) we use for serving static files, provoking the
error:
curl -k --verbose --insecure --header "Accept-Encoding: gzip" https://slowhost:8006/pve2/ext6/ext-all-debug.js
curl: (18) transfer closed with 1991108 bytes remaining to read
Non-debug files are 4 times smaller, and since everybody will benefit of having
a faster initial load of PVE, there is no reason not to make this default.
this patch checks if only the bootdisk changed,
using the multikey funcionality
also use this in the revert button handler,
to revert the bootdisk also
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we set the pveNodeSelector to [] by default,
but filter by !node (![] == false), so that no vms are shown
this occurs, when the pveNodeSelector store loads after the store
for the vm list, which rarely happens
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
on comboboxes/combogrids with multiselect,
if you deselect an item (but not the last),
the order of the selected items after resetting is
not the same as the original order
because of this, the reset button is still enabled
this happens, because extjs only adds the missing
values instead of overwriting the whole array
with this fix, we overwrite the reset function of
the comboboxes and only if the values do not match
(after a reset) do we clear and set the value again
so we only change the behaviour when it is necessary
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this fixes a nasty combogrid/multiselect/storeload bug
in which the value of a combogrid gets set to a string instead
of an array, under certain circumstances
we overwrite the getRawValue method of our ComboGrid,
and on multiselect ComboGrids, we just get the value out of
me.rawValue, else we call the method of the parent class
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
jslint does not like names that begin with _
also it complains when you do not filter
a for in statement with a hasOwnProperty(property) as first
if statement
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
