Commit Graph

5995 Commits

Author SHA1 Message Date
Dominik Csapak
d66b726c0e ceph: fix version check shortcut
with 'get_node_kv', we get a hash which contains the value for
all nodes in the cluster (with the nodename as key), so we have to use
the value from the hash corresponding to our nodename.

also the 'str' property is inside the 'version' hash

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-11-07 21:03:13 +01:00
Thomas Lamprecht
1b72acbf2f ui: join info: rework error handling/checking for no-cluster
check if error is set before trying to access it and check for the
new HTTP code a newer pve-cluster may return, and do a more fuzzy
match for older ones.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-11-07 21:01:55 +01:00
Thomas Lamprecht
6152988ea6 ui: join info: code cleanup and future proof
we may want to return null or an empty object for the join info on a
node without a cluster in the future (i.e., PVE 8.0+), so get
compatible for that now already as it costs not much and as we can
now use es2020 we even can write the object access nicer..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-11-07 20:57:39 +01:00
Dominik Csapak
9ab0c06954 ui: dc/Cluster: show errors on 'join' info in the view
so instead of getting the 'standalone node' message, the grid
is masked with the actual api error

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-11-05 14:34:15 +01:00
Fabian Ebner
98301c0877 ui: guest backup grid: monitor store errors
so that users see when something went wrong.

Don't mask the grid directly, but rather only its view so that the
title bar can be used for selecting another storage during load.

Reported in the community forum:
https://forum.proxmox.com/threads/get-backups-from-proxmox-randomly-fails.98383/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-05 13:55:44 +01:00
Dominik Csapak
d738b11e37 ui: window/Wizard: make it a little wider
for the multi disk panel, we want it to be just a little wider, so
that all form fields are still readable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
9dbc4dfa88 ui: add qemu/MultiHDEdit and use it in the wizard
uses the MultiDiskPanel as base and implements the necessary
functions/variables

this allows now to create a vm also without any disk

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
af07d3d3d6 ui: add lxc/MultiMPEdit and use in lxc/CreateWizard
uses the MultiDiskPanel as a base and implements the necessary
functions/values

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
5f219fd3ba ui: add MultiDiskPanel
this adds a new panel where a user can add multiple disks, intended
for use in the wizard.

Has a simple grid for displaying the already added disks and displays
a warning triangle if the disk is not valid.

this is a base panel for adding multiple disks/mps for vms/ct
respectively.

this combines the shared behavior and layout and defines the functions
that subclasses must define

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
87161abf38 ui: lxc/MPEdit: add selectFree toggle
that sets the given vmconfig at the start and selects the first
free mpid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
143a507181 ui: lxc/MPEdit: fire diskidchange event
when the diskid changes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
09e7ac8b63 ui: lxc/MPEdit: add updateVMConfig
helper for the upcoming MultiMPEdit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-11-05 09:50:36 +01:00
Dominik Csapak
cef0b24cff ui: qemu/SystemEdit: add spacing and heading for 'firmware' options
So that they are more visually seperated from the rest of the options.
Use the same style as in the realm sync panel.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-11-03 17:05:26 +01:00
Dominik Csapak
4b105ec574 ui: storage/PBSEdit: do not send server on edit
it's a fixed value for the storage config, so the api would reject it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-10-28 15:55:42 +02:00
Lorenz Stechauner
ae595bc16c ui: storage/PBSEdit: add port to server field
this gives users the chance to supply the port nr in the gui,
without having to add a extra new field to the panel.

using the same implementation as in RemoteEdit.js in PBS.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
2021-10-28 15:46:24 +02:00
Thomas Lamprecht
7d21fd936a ui: clarify labels for EFI/TPM storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-21 13:41:06 +02:00
Stefan Reiter
a9175b0ba1 ui: add 'win11' ostype and set defaults in wizard
Windows 11 requires a TPM and secure boot, so try to auto-enable both.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-21 12:41:30 +02:00
Stefan Reiter
b0a0b17dbc ui: SystemEdit: promote advanced settings to normal
and reorder the panel a bit, as otherwise I found it *very* cluttered.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-21 12:41:25 +02:00
Thomas Lamprecht
401a5c1f76 d/control: bump versioned dependency on libpve-storage-perl
to ensure the new selectable `preallocation` property is available.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-21 12:15:16 +02:00
Lorenz Stechauner
bb157f5d6d fix 3850: ui: storage: using PreallocationSelector for file based storage types
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
2021-10-21 12:14:38 +02:00
Lorenz Stechauner
418e9c13ae ui: add PreallocationSelector
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
2021-10-21 12:14:38 +02:00
Dominik Csapak
d8da55382a ui: resourcetree: move guest position on template creation
we sort templates at the end normally, but if we convert a guest to a
template, it was not moved in the tree

add it to the list of attributes that are checked for a move

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-21 11:48:38 +02:00
Thomas Lamprecht
e8c41dc561 statd: rebalance_lxc_containers: use grep instead of for+next-if
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-20 17:01:48 +02:00
Thomas Lamprecht
b707257a16 statd: rebalance_lxc_containers: code bload reduction
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-20 16:47:06 +02:00
Oguz Bektas
911a8e4f48 pvestatd: fix rebalancing cpusets for cgroupv2
currently we only check the entry for cgroup v1 to decide if cores
should be rebalanced. extend the check to include cgroup v2 entries.

reported in forum [0]

[0]: https://forum.proxmox.com/threads/hard-set-streams-for-lxc-container.97768/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-20 16:47:06 +02:00
Thomas Lamprecht
b1a3af5c65 ceph services: get_cluster_service: code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-20 16:47:06 +02:00
Thomas Lamprecht
656667dbd2 ceph services: return early if versions stayed the same
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-20 16:47:06 +02:00
Thomas Lamprecht
8a3a300b8e ceph services: drop broadcasting legacy version pmxcfs KV
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-20 16:47:06 +02:00
Thomas Lamprecht
6c83ba5823 pvenetcommit: better handle non-existent pending changes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-20 16:47:06 +02:00
Fabian Ebner
f332a16745 vzdump: pbs: suppress output from upload-log command
which ended up in the backup task log and can be confusing to users:

> INFO: Backup finished at 2021-10-11 08:40:38
> Result: {
>       "data": null
> }
> INFO: Backup job finished successfully

For proxmox-backup-server < 2.0.11-1, there was no output for the
upload-log command.

Reported in the community forum:
https://forum.proxmox.com/threads/backup-finishes-ok-but-data-null-info-on-finish.97740/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-10-11 09:51:24 +02:00
Thomas Lamprecht
9242f96c78 d/control: depend on libproxmox-acme-plugins directly
was provided indirectly through libproxmox-acme-perl but we want to
downgrade it there to a recommends

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-09 14:14:56 +02:00
Thomas Lamprecht
8648704ea9 drop unused and ancient pvenetcommit shell sysv script
Handled by the pvenetcommit.service systemd unit nowadays

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-08 16:01:15 +02:00
Dominik Csapak
4e6b6db2c4 d/postinst: use reload-or-restart instead of try-reload-or-try-restart
The only difference is that reload-or-try-restart does not do
anything if the service isn't already running, while
reload-or-restart also starts a stopped service.

We explicitly check if the service is enabled on upgrade before doing
any start/reload-or-restart action anyway. So, it would now start
daemons that were stopped but not disabled, which is not a really
valid state and would have happened on the next reboot anyway.

This starts new daemons (like the pvescheduler) automatically on a
package upgrade

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-07 10:34:24 +02:00
Thomas Lamprecht
df827e9890 bump version to 7.0-13
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 20:25:08 +02:00
Thomas Lamprecht
b18a3d9f16 wizard: code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 20:11:21 +02:00
Thomas Lamprecht
78b3c3df99 ui: vm create: allow configuring a TPM in wizard
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 20:11:21 +02:00
Thomas Lamprecht
fd12adfb32 ui: efi: default to new 4MB format and allow pre-enrolled keys
to allow "real" secure boot, at least real enough for Windows 11 ;)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 20:11:21 +02:00
Thomas Lamprecht
80ddbcdf53 ui: efi/tpm: propagate disabled to child items
we'll need that soon once this is used int the wizard

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 20:03:21 +02:00
Thomas Lamprecht
fde3a291f3 bump version to 7.0-12
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 08:07:48 +02:00
Thomas Lamprecht
d380d00008 ceph: code/whitespace cleanups
avoid line bloat, use same capitalization style in warnings as (most)
of the rest of code, some style nits

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 08:01:33 +02:00
Thomas Lamprecht
9f6dc0750a ceph: use method to have a single source for install flag file
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-05 08:00:46 +02:00
Aaron Lauterer
4dd27d5034 ceph install: improve ceph install checks during installation
Adding a flag file during the Ceph installation helps to cover the time
span in which the binary is already present but the installation not yet
done.

The most noticeable effect is that the 'Next' button in the GUI will
only become active once the installation is actually finished and not
earlier.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-05 07:42:57 +02:00
Aaron Lauterer
a040ecafb7 ui: lxc options: change CIFS to SMB/CIFS
For consistency with the Storage panel and it might also help people to
make the connection if they are not aware that CIFS is a name used for
SMB.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-05 07:37:22 +02:00
Aaron Lauterer
3266c03d72 ui: storage: change CIFS to SMB/CIFS
This will hopefully help people to find the needed storage as not
everyone will be aware of the fact that CIFS is also a name used for it
(technically it was only SMB v1).

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-10-05 07:37:22 +02:00
Stefan Reiter
6d084964b3 ui: add support for adding TPM devices
Inspired by HDEfi for efidisks. Extends the DiskStorageSelector to allow
hiding the format, since tpmstate can only be stored in 'raw' format
(even on directory storages).

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-10-05 07:12:19 +02:00
Thomas Lamprecht
1883444486 d/lintian: update overrides
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-04 12:22:02 +02:00
Thomas Lamprecht
86badf17fe buildsys: lintian: do not ignore "binaries" anymore
not required anymore and if it would be, we'd rather use the
debian/lintian-overrides file

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-04 12:22:02 +02:00
Thomas Lamprecht
d9fab55662 pve6to7: improve manpage slightly
this fixes a lintian complaint regarding "bad-whatis-entry"

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-04 12:22:02 +02:00
Thomas Lamprecht
81dbe056fc drop pve5to6 checker tool, not relevant in 7.x release
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-04 12:22:02 +02:00
Thomas Lamprecht
9efc89f6b0 d/postinst: fix lintian: command-with-path-in-maintainer-script postinst:76 /usr/bin/pvecm
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-10-04 12:22:02 +02:00