Commit Graph

3858 Commits

Author SHA1 Message Date
Tim Marx
d03d7e1eee unified the classification of the passed command for all shell apis
As discussed on the pve-devel list [0] I extracted the identical chunks from each
shell api into one function as basis for future changes.

[0] https://pve.proxmox.com/pipermail/pve-devel/2019-January/035387.html

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-02-28 11:32:18 +01:00
Thomas Lamprecht
f9d26e098f trailing whitespace fix in Nodes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-27 13:39:32 +01:00
Stoiko Ivanov
b7d441dc28 remove read_proxy_conf from PVE::API2Tools
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-02-26 07:32:22 +01:00
Stoiko Ivanov
a642f8a01b pveproxy, spiceproxy: new read_proxy_conf location
read_proxy_conf was moved to the new PVE::ApiServer::Utils so that it
can be reused by other apiservers (e.g., PMG one). Use that one, so
that we can remove it here later

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-26 07:32:22 +01:00
Stoiko Ivanov
9503511809 remove default values from pveproxy ssl config
they are in PVE::APIServer::AnyEvent

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-02-26 07:32:22 +01:00
Thomas Lamprecht
e784d10fda d/control: bump libpve-http-server-perl version dependency
In preperance for the next two commits, which use the (moved)
PVE::ApiServer::Utils module and rely on the fact that
pve-http-server now set some ssl defaults itself.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-26 07:23:18 +01:00
Dominik Csapak
7af1ab47f6 fix popup behaviour in firefox with touchscreens on desktop
when the popup blocker is active, nw is undefined and nw.focus() throws an
error and the touchend event is not finished, causing extjs to retry the
touchevent and click handler, which tries to open a popup which gets blocked
here, and so on

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-02-21 11:58:14 +01:00
Thomas Lamprecht
97f7773b6c ui: qemu/cddrive: increase width for better ux
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-21 11:14:16 +01:00
Thomas Lamprecht
5e2371a988 bump version to 5.3-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-20 19:42:28 +01:00
Thomas Lamprecht
507b7cfedd fix #2108: ceph: 'osd pools set' cannot accept integers anymore
The new luminous release 12.2.11 cherry-picked a commit[0] which
remove some legacy fallback when parsing a pool set command.
As of now only strings (which itself can then be a string, int or
float) may be passed as a value, while older also accepted an int
directly.

So ensure that all of our "osd pool set" commands pass strings, which
means that 'min_size' and 'size' must be converted to strings before
executing the command.

Without this one cannot create a CephFS over the WebUI anymore as the
create pools fails. Interestingly, the normal create pools over WebUI
still worked, as it has those two parameters exposed in the creation
formular, and thus sents them as string to the backend, while the
cephfs API does not exposes those two values at all but sets them
directly to integers. Funny stuff. CLI invocations also had the same
issue, depending on the fact if size and min_size could and got
passed (then it worked) or where omited (then it did not worked).

[0]: c838a0096d

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-20 19:25:16 +01:00
Thomas Lamprecht
a2d017efc8 bump version to 5.3-10
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-20 12:29:34 +01:00
Thomas Lamprecht
35b159f4ed d/control: bump version dependency to pve-doc-generator
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-20 12:29:21 +01:00
Christian Ebner
ad9d1215f5 Fix 1891 Generate zsh tab completion scripts for cli tools
This patch builds the  zsh tab completion scripts for the cli tools of
pve-manager.
In order for it to work, the latest version of pve-common and pve-docs
including the corresponding patches have to be installed on the build
system.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-02-20 12:12:07 +01:00
Stoiko Ivanov
f0ea5afcd7 pveproxy: honor_cipher_order by default
change the default from client preference to server preference, but leave it
configurable.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-02-20 07:15:38 +01:00
Stoiko Ivanov
a33abad12d pveproxy: add configurable COMPRESSION
disabling http compression is considered good practice and certain TLS-testing
scripts/sites lower the security rating if it's enabled.

compression is still on by default for the potential speed/performance gain.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-02-20 07:15:38 +01:00
Stoiko Ivanov
1f7809624b pveproxy: add configurable HONOR_CIPHER_ORDER
fix #2069 (the report includes rationale and also information on test-cases).

Tested by:
* running testssl.sh [0]
* enabling this setting (our default cipherlist prefers AES256,
  chromium on stretch AES128)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-02-20 07:15:38 +01:00
Stoiko Ivanov
bbb0c700bd fix typo in comment (ssl-config)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2019-02-19 17:17:17 +01:00
Oguz Bektas
77d2332068 add symbol for suspended guests
use the same symbol as 'paused' guests to avoid confusion.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 14:12:06 +01:00
Dominik Csapak
21ef191b66 jslint fixes
type confusion: value is int and string
let is not recognized by our jslint version yet, so
use var for now

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-02-19 12:08:23 +01:00
Dominik Csapak
e2c97a19e3 BulkAction.js: fixup indentation
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-02-19 12:08:23 +01:00
Oguz Bektas
200a9b5dc5 add lxc restart warning to bulk migration screen
only show warning in migration window and when a running lxc container
is chosen

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Co-Authored by: Dominik Csapak <d.csapak@proxmox.com>
2019-02-19 11:53:15 +01:00
Oguz Bektas
e50456078b fix #1769: restart mode for bulk lxc migration
online mode doesn't work, and causes bulk migration of
running lxc containers to fail.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:53:15 +01:00
Oguz Bektas
a18927017f unprivileged:true by default in restore window
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:52:22 +01:00
Oguz Bektas
02307282bd unprivileged:true by default in ct creation
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:52:16 +01:00
Oguz Bektas
fc32524056 fix #2096: enable resume in context menu for guest triggered sleep
We act correctly for an outside triggered suspend, but if the guest
suspends itself from inside (e.g., systemctl suspend,
`echo "standby" > /sys/power/state` or windows sleep) it has another
state (suspended vs. paused), so handled that also

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:46:17 +01:00
Thomas Lamprecht
017bb1a8bd minor typo fix and code cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-08 15:26:44 +01:00
Alwin Antreich
3c6aa3f47e api osd/destroy: use ProcFSTools to iterate mounts
Instead of opening proc/mounts through IO::File directly for parsing,
the patch uses ProcFSTools. This way it also takes care of eventual
decoding.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2019-02-08 15:26:00 +01:00
Thomas Lamprecht
e45cc727e6 follouwp: code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-08 15:26:00 +01:00
Alwin Antreich
b436dca874 Fix #2051: preserve DB/WAL disk on destroy
When destroying an OSD over API or CLI, e.g. by executing:

'pveceph osd destroy <num> --cleanup'

all disks associated with the OSD got wiped with dd, which included
any shared and by others still in use ones, e.g., separate disks with
DB/WAL.

The patch changes 'wipe_disks' to wipe the partition instead of the
whole disk.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-08 14:20:23 +01:00
Dominik Csapak
0110314c61 gui: show Storage Content with Datastore.AllocateSpace/Audit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-02-06 11:35:13 +01:00
Thomas Lamprecht
417dd60183 bump version to 5.3-9
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-01 13:40:39 +01:00
Thomas Lamprecht
29acb9b58f fixup: s/Filter: /Search/ which is already translated
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-01 09:28:29 +01:00
Christian Ebner
f577bda029 Fix #1831: Add filter to CT template/appliances download window
This adds the posibility to filter CT template/appliances by package as well as
description in the CT template/appliances download window.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-02-01 09:03:00 +01:00
Thomas Lamprecht
fcca6095e1 pveperf: print errno on die if sensible
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-31 13:50:37 +01:00
Thomas Lamprecht
259c05ea2e remove various outdated or moved dependencies
some http/ssl based ones where for the now separate http-server,
while they got added there, they did not get removed here.

Some are not needed in manager, e.g., liblinux-inotify2-perl which is
used in pve-common

Some others are simply outdated, e.g. libauthen-pam-perl or
libhttp-daemon-perl

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-31 12:05:01 +01:00
Thomas Lamprecht
dd6b2e5742 remove unused libxml-parser-perl dependency
over from the time where corosync was still bnased on XML configs
(pre PVE 4.0). This was not used, and XML::Parser is not Export
based, so it does not pushes some methods into the using modules
namespace

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-31 12:02:55 +01:00
Thomas Lamprecht
97ad5e50d7 pveperf: use fsync syscall from PVE::Tools
allows to drop the libfile-sync-perl dependency

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-31 11:44:15 +01:00
Dominik Csapak
95f2a8a21a show hookscript in gui
only viewing, no editing
and show it only when it is set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-31 11:05:55 +01:00
Dominik Csapak
aef28e0430 add snippets content type to the gui
we only show that a storage can store snippets, but for now
we do not allow to set or upload them via the gui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-31 11:05:55 +01:00
Thomas Lamprecht
7d762f4cc0 cleanup: api/subscription: keep variable declarations closer to use
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-31 10:54:50 +01:00
Dominik Csapak
7d6fba8fff api/subscription: fix permission check
when using 'check_permissions' directly, we have to actually use the
nodename in the path, else we check the wrong permission and one
needed to have propagating 'Sys.Audit' permissions on '/nodes' for
this to work.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-31 10:52:38 +01:00
Dominik Csapak
acbf524510 d/control: remove netcat dependency
we do not use it anymore, history of it goes back to the initial SVN
to git import.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-31 06:52:29 +01:00
Christian Ebner
9f0b4e045b Add context menu to global search entries
This add a context menu to the entries of the global search field instead of
showing the browsers default one.
This allows to search and easily manage nodes, VMs and CTs similar to the
behaviour in the resource tree.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-01-29 14:04:10 +01:00
Dominik Csapak
89ae1bb151 gui: add virtio-gpu and none to combobox
since 'virtio' is alredy used in that file for a number,
we have to add jslint confusion

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-28 17:32:32 +01:00
Christian Ebner
5aa7b909b1 Add bash completion for wakeonlan API call
This adds the bash completion for the wakeonlan API call.
The bash completion returns only those nodes which are offline according to the
member status.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-01-28 17:28:34 +01:00
Christian Ebner
0640620693 Add context menu entry for WoL calls to nodes in GUI
This adds a context menu entry to the cluster nodes which triggers the wake on
LAN API call for the selected node.
The entry is disabled if the node is already running or the user has no
Sys.PowerMgmt capabilities.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-01-25 14:22:26 +01:00
Thomas Lamprecht
42b49c3569 update shipped aplinfo index: add debian updates
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-24 16:00:21 +01:00
Thomas Lamprecht
0fe92cb7f8 update shipped aplinfo index
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-01-24 11:04:43 +01:00
Fabian Grünbichler
99aca71627 pvenode: use 'UNKNOWN' if task status is missing
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-01-23 18:42:59 +01:00
Fabian Grünbichler
236f253c9e pvenode: don't treat running tasks as failed
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-01-23 18:42:59 +01:00