This takes a bit of screensize, but is fine as long as the browser
horizontal screen size is at least 1280 px ( 92 % of desktop users in 2016
according to StatsCounter)
Still usable for the remaining small displays, but horizontal scrolling
is needed for grids with a lot of columns.
Moving the sub tabs to the top left provides a minor usability
improvement as all controls are now grouped together in the same
screen region.
we used an empty value for the Key-Value ComboBox for defaults.
With extjs6, if the idProperty of a model is empty, they generate
a name for it, which breaks our logic for submitting
(currently we checked if this is empty, and send a delete command
to our api)
instead, we use the value 'default' and check for it when we submit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
includes the following fixes:
* remove all code related to the old java applet vnc client
(we do not use this anymore)
* move static configuration to class definition
* use Ext.ux.IFrame instead of widget.uxiframe (to be consistent)
* change listener from show to activate (for browser refresh)
* change deprecated autoScroll to scrollable
* remove novnc option from openVNCViewer function,
since we do not need this option anymore
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this fixes two problems:
* we were loading the store before the parent ComboGrid class could put
a listener on the load event
* displayField must now be set in class body, take opportunity to move out
what we can of the mega initComponent()
this two fixes allow the HA GroupEdit Window to properly display the
existing members of a HA Group when editing group membership
Tabpanel reload -> send 'show' event -> reload child panel store
do not work with ExtJS6
but
Tabpanel reload -> reload child panel -> child send 'show' event ->
reload a grid store in the panel still works
so we don't blindly replace the 'show' events everywhere but only
when the event was expected by a direct child of a tabpanel
this also fixes the problem that the method
Ext.ComponentQuery.query() was outputting a warning
since it did not know if it should perform a lookup
for a class name or a xtype
fixes the LogView (for Tasks and Syslog) including:
moving static configuration to class definition
changing deprecated bodyStyle: padding to bodyPadding
removing chrome scrolltop hack (does work properly now, and hack
did not work anymore)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
fixes include:
move static configuration to class declaration
use Ext.create instead of new for reload_task
use store.reload(), because store.filter() triggers no reload with
activated
remove store.guaranteeRange hack for infinite grid (works properly now)
since buffered: true is deprecated, use a BufferedStore instead
remove verticalScrollerType and invalidateScrollerOnRefresh
since this does not exist anymore in extjs6
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This reverts commit c8e0699d5d.
Without using an idProperty in the KeyValue model, the id of each
store item is autogenerated, and the DiffStore always recreate the whole
store content every second instead of updating the fields where values
have changed. Recreating the whole store content makes the
Node Summary View flicker, as the order of items in the store change
after each reload.
Testing shows that reversing this commit do not break anything else.
ExtJS6 requires a stateId if we want to save the component state
(seems it is not autogenerated anymore from 'id')
this fix the selection of timeframes in the Summary View
also move properties out of initComponent()
also remove code which duplicates framework code:
setting stateEvents to 'select' will save the component state
after a selection by calling applyState()/getState() automatically
so we don't need to specify a callback ourselves and we don't need
the testChange() method since applyState() will be called anyway
this patch adds the ability to add existing lvm thinpools to the
storage configuration via the gui
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
add htmlEnode as a renderer to fields which lets you
input arbitrary strings, to prevent html tags
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
To prevent that one time Net:SSL and an outer time IO::Socket::SSL is loaded,
ensure that always use the same socket class.
We load the the Net:SSL in AccessControl.pm if we call pveupdate,
but if we call pveam update this module is not loaded an so the default is used (IO::Socket::SSL).
ExtJS6 adds accessibility (aria) support to the framework, which means
special handling of space/enter key and panels title, and a lot of
warnings / errors in the browser console
Aria support will be reenabled after all the components are migrated to
ExtJS6
