adding LIO option and dedicated "LIO target portal group" input field to the
"Add: ZFS via iSCSI" dialog
Signed-Off-By: Udo Rader <udo.rader@bestsolution.at>
Change to agent now being a property_string, and including fstrim_cloned_disks.
Co-Authored-By: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
allows to catch bugs faster as we get a call trace and may see this
error even when our caller doesn't handle an undefined return value
from this method.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Combine both dialogues. This reduces storage choices from the
Storage -> Add menu, and thus improves usability.
We make the whole dialog also more intelligent by querying the
monitors, so that we can show them for the hyper converged case
keeping a similar interface for both cases. Further we can use this
to decide if a hyperconverged setup is possible at all.
While this information would also be available through the fact if
the pool selector has entries I wanted to show them anyway and could
make logic a bit easier using it.
allowSpice needs to be a real boolean, because of a
'=== true' check to open a spice console if allowed, so make it one here
this fixes the issue that a doubleclick on a tree item only opened
the novnc console even if spice is the default and the vm is spice
enabled
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
allows us to remove the external loading of extjs from the cloudflare
cdn in pve-docs easier with having the external hosted version in
mind.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Most of those API calls return simple strings, so it does not really matter.
Nethertheless, some calls return complex data structures and we want to set
output format for them.
we now put a form around the fields/buttons and can track
the valid/dirty state, and use this for setting the button states
now the buttons are correctly enabled/disabled when the form
is dirty/valid/empty
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
In pve-common the following changes happened:
0adee98 ("cli_handler: pass common output options as separate parameter")
352b7a1 ("PVE::CLIFormatter - implement new output options")
We now get the format passed via an options hash in the
output function instead of seeing it as an api call
parameter.
Similarly, --quiet is now already handled there.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
We have good command line completion and history with 'bash', so there is
no real need to duplicate this functionality.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
The lxc CreateWizard ignores the pool setting. That makes creating
containers impossible for users who are restricted to using a pool. This
patch fixes that.
Signed-off-by: Andrew Neitsch <andrew@neitsch.ca>
username, password and domain name are all related, they are non-pve
options related to accessing the CIFS storage and have all influence
on the pveCIFSScan component.
So group at kleast user and password together. But keep domain on the
right for the sake of balance.
Move the content type selector to the right, as the RBD and other
panels do.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we ignore the password in the backend if no user is passed,
which can be very confusing for the user - or more important, me,
when testing cifs/storage stuff.
So change the mechanics slightly. Previously we changed the
allowBlank property of the password field if username was changed.
I set it to always required, but disable the whole field if we do not
have a username.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
