Commit Graph

5030 Commits

Author SHA1 Message Date
Fabian Ebner
5b6b72e6ee Simplify how maxfiles is determined
No functional change is intended.
The preference order is: option, then storage config, then vzdump defaults.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-06-30 13:55:11 +02:00
Fabian Ebner
3a805f8d68 storage_info: avoid duplication
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-06-30 13:54:32 +02:00
Fabian Ebner
a6fcd7d9d4 Die if dumpdir and storage are both defined
dumpdir will be overwritten if a storage is specified

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-06-30 13:54:16 +02:00
Thomas Lamprecht
c081336c2e fixup: get fallback caps correctly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-26 10:20:20 +02:00
Mira Limbeck
044b08f255 change permissions for non-network cloudinit settings
With the introduction of VM.Config.Cloudinit we can set the user,
password and an SSH key without VM.Config.Network permission.
Keep the fallback for VM.Config.Network so custom roles don't break.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2020-06-26 09:43:00 +02:00
Alexandre Derumier
90f7cb68d1 sdn: fix zone icon in tree view
also add status icon:
  -pending (yellow triangle)
  -error (red cross)

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-06-25 13:35:55 +02:00
Fabian Grünbichler
b3fbf2ac10 node_config: followup s/domain/alias
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-06-25 10:28:14 +02:00
Fabian Möller
d1dd680b09 node_config: Allow leading underscore in ACME aliases 2020-06-25 10:25:45 +02:00
Dominik Csapak
d8cb744d2f fix #2810: reset state of mounts array in initComponent
so that each new instance has an empty mounts list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-06-24 09:45:47 +02:00
Stefan Reiter
7376c56edc ui: ProcessorEdit: allow modifications with inaccessible CPU model
An administrator can set a custom CPU model for a VM where the general user
does not have permission to use this particular model. Prior to this change
the ProcessorEdit component would be broken by this, since the store of the
CPU type selector did not contain the configured CPU model.

Add it in manually if this situation occurs (with 'Unknown' vendor, since
we cannot retrieve it from the API), but warn the user that changing it
would be an irreversible action.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-06-17 15:51:11 +02:00
Stefan Reiter
4546808caa ui: CPUModelSelector: use API call for store
CPU models are retrieved from the new /nodes/X/cpu call and ordered by
vendor to approximate the previous sort order (less change for accustomed
users).

With this, custom CPU models are now selectable via the GUI.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-06-17 15:51:11 +02:00
Stefan Reiter
b839766e7d ui: ProcessorEdit: fix total core calculation and use view model
Clean up the code in ProcessorEdit with a view model and fix a bug while at
it - previously, pressing the 'Reset' button on the form would always set
the value of the total core count field to 1, so mark 'totalcores' with
'isFormField: false' to avoid reset.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-06-17 15:51:11 +02:00
Stefan Reiter
01ac98c702 api: register /nodes/X/cpu call for CPU models
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-06-17 15:51:11 +02:00
Thomas Lamprecht
50ba40ec59 vzdump: move VMID sorting to check_vmids
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-17 15:45:56 +02:00
Thomas Lamprecht
05447e0459 vzdump: import split_list and cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-17 15:45:21 +02:00
Thomas Lamprecht
f839f3d153 vzdump: style fix, trailing comma and closing brace on new line
also sort the hash definition

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-17 15:39:46 +02:00
Aaron Lauterer
5d807cf56d vzdump: test: adapt and add more tests that are possible now
Now, with the logic for `all` and `exclude` in the same single method,
additional tests for these cases are possible.

Adapt to hash return value of `get_included_guests`.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-06-17 15:16:06 +02:00
Aaron Lauterer
df5875b41e vzdump: move remaining guest include logic to single method
The `guest include` logic handling `all` and `exclude` parameters was in
the `PVE::VZDump->exec_backup()` method. Moving this logic into the
`get_included_guests` method allows us to simplify and generalize it.

This helps to make the overall logic easier to test and develop other
features around vzdump backup jobs.

The method now returns a hash with node names as keys mapped to arrays
of VMIDs on these nodes that are included in the vzdump job.

The VZDump API call to create a new backup is adapted to use the new
method to create the list of local VMIDs and the skiplist.

Permission checks are kept where they are to be able to handle missing
permissions according to the current context. The old behavior to die
on a backup job when the user is missing the permission to a guest and
the job is not an 'all' or 'exclude' job is kept.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-06-17 15:16:06 +02:00
Fabian Grünbichler
4aa89cc0e8 fix #2784: always compare ACME domains in lower case
otherwise the ACME endpoint might return the ordered domain in lower
case and we fail to find our plugin config.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-06-17 14:00:43 +02:00
Fabian Grünbichler
63ad21645d fix #2771: relax cert API endpoints permissions
allow users with Sys.Modify to modify custom or ACME certificates. those
users can already hose the system in plenty of ways, no reason to
restrict this in particular to being root@pam only.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-06-17 14:00:43 +02:00
Thomas Lamprecht
fab600b796 fix #2802: metric flush check should not care about current usage
We only need to check if the next data addition brings us over the
batch send size, not if we have already at least half of that data in
there, as else we may get again over the batch sent size.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-17 10:16:27 +02:00
Thomas Lamprecht
e72c20fbe7 d/control: update versioned dependency for widget-toolkit
for the refactored out disk manage stuff

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-16 17:01:56 +02:00
Thomas Lamprecht
91d86e8fde dc/Tasks: pass endtime to make duration calculation correct
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-16 17:00:26 +02:00
Dominik Csapak
4554fe77e5 ui: use pmxDiskList from widget-toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-06-16 11:43:05 +02:00
Dominik Csapak
d0cfe2eadd ui: use pmxDiskSelector from widget-toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-06-16 11:43:05 +02:00
Alexandre Derumier
8d4589b7e2 sdn: browser: fix Permissions.Modify
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-06-15 15:35:30 +02:00
Alexandre Derumier
9afcbd26b2 api : cluster resources: add sdn audit permission
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-06-15 15:35:30 +02:00
Thomas Lamprecht
47399e41ad small nit follouwp: use $var->[0] to acccess array ref element
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-08 15:57:34 +02:00
Aaron Lauterer
54df211432 vzdump: test: add first tests to the guest include logic
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-06-08 15:54:42 +02:00
Aaron Lauterer
5c4da4c3e8 vzdump: make guest include logic testable
As a first step to make the whole guest include logic more testable the
part from the API endpoint has been moved to its own method with as
little changes as possible.

Everything concerning `all` and `exclude` logic is still in the
PVE::VZDump->exec_backup() method.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2020-06-08 15:54:42 +02:00
Thomas Lamprecht
9c3a51ee22 vzdump: format size: future proof against huge VM disks
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-08 15:54:35 +02:00
Stoiko Ivanov
7d2e6f5b7e add model information to ZFS create window
and improve the layout by adding flex values and increasing the width.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2020-06-06 19:36:46 +02:00
Thomas Lamprecht
cd338fe153 ui: migrate: sort migrations hints by text column
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 19:24:27 +02:00
Fabian Ebner
11c17a01b7 Allow setting no target storage and make it default
so the current disk locations can be preserved even if
there are multiple local disks. And users don't have to
manually select the current storage if there is only one
local disk.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-06-06 18:49:08 +02:00
Fabian Ebner
0411c2c058 Don't show empty parentheses when size is not known
The size of VM state files and the size of unused disks not
referenced by any snapshot is not saved in the VM configuration,
so it's not available here either.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-06-06 18:49:08 +02:00
Thomas Lamprecht
3bbce3b8cd drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Thomas Lamprecht
df503ff92c ui: ceph/status: cleanup legacy version handling
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 19:12:45 +02:00
Thomas Lamprecht
363432b9b1 bump version to 6.2-6
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 16:42:40 +02:00
Tim Marx
8b4987e5a9 ui: migration: add maxHeight to migration window
to prevent indefinite growth in case of e.g. many local disks

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2020-06-03 16:27:38 +02:00
Thomas Lamprecht
a7c90b405f ui: backup grid: use boxLabel type and VMID
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 16:26:25 +02:00
Dominik Csapak
201b89dbd5 ui: add checkbox for vmid filter for backupview
instead of hardcoding the text 'type-id-' into the searchbar
to accomodate for the additional size, add an overflowHandler
to the toolbar (for very small display sizes)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-06-03 16:21:11 +02:00
Thomas Lamprecht
23b316a325 ui: ceph/pool: allow autoscale on create
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 16:15:55 +02:00
Alwin Antreich
d4dba076a6 ceph: extend pveceph pool ls
to present more data on pools and a nicer formated output on the command
line.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2020-06-03 16:08:27 +02:00
Alwin Antreich
06bd1c5215 ceph: extend the pool view
to add the pg_autoscale_mode since its activated in Ceph Octopus by
default and emmits a waring (ceph status) if a pool has too many PGs.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2020-06-03 16:08:27 +02:00
Thomas Lamprecht
fdf79b4e66 ceph: avoid fork/exec overhead for every ceph_cluster_status call
detect heuristically if we need to get the full mon and mgr map extra
for Octopus

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 15:30:06 +02:00
Thomas Lamprecht
45221aae94 ui: ceph/StatusDetail: cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 15:25:39 +02:00
Alwin Antreich
e25dda254c Make PVE6 compatible with supported ceph versions
Luminous, Nautilus and Octopus. In Octopus the mon_status was dropped.
Also the ceph status was cleaned up and doesn't provide the mgrmap and
monmap.

The rados queries used in the ceph status API endpoints (cluster / node)
were factored out and merged to one place.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2020-06-03 14:23:38 +02:00
Thomas Lamprecht
df9f3d6e7c ui: followup: use title case
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-03 14:22:21 +02:00
Alexandre Derumier
a724fe23c1 sdn: vlan : add mtu field
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-06-03 14:22:21 +02:00
Alexandre Derumier
d0da259e35 sdn: add vlan aware option to vnet
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-06-03 14:22:21 +02:00