proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-17 07:59:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,434 Commits 6 Branches 0 Tags 12 MiB
11d7427400
Commit Graph

5434 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Fabian Grünbichler
a6f6ed5a06 ui: don't refer to enc key as 'master key' 
the master key is something entirely different, this might confuse
users..

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
 2020-11-26 10:42:20 +01:00
Thomas Lamprecht
c781d185c5 bump version to 6.3-2 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-25 16:20:35 +01:00
Thomas Lamprecht
903e646d7c ui: pbs: set onlineHelp (again) 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-25 16:19:50 +01:00
Stefan Reiter
c856bd1c22 ui: bootorder: add onlineHelp link 
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
 2020-11-25 16:11:32 +01:00
Dominik Csapak
dadba141a8 api: metrics/server: test connection on add/update 
just a basic check, but better than not checking at all

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-25 14:55:25 +01:00
Thomas Lamprecht
e3022813ec ui: storage edit: ensure to set keep-all by default 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-25 14:49:23 +01:00
Dominik Csapak
13a0434066 ui: pbs key show: improve labelWidth for 'Key' in translations 
it is not that short in other languages, e.g. German

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-25 13:19:30 +01:00
Dominic Jäger
ba854589f4 ui: storage: pbsedit: Fix spelling 
No e in unusable.

to loose means to free from restraint, or to make less tight or strict [1].
to lose means to fail to keep, or to miss something from one's possession [2].
So "losing" (instead of "loosing") would be bad.

[0] https://www.merriam-webster.com/dictionary/unusable
[1] https://www.merriam-webster.com/dictionary/loose
[2] https://www.merriam-webster.com/dictionary/lose

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
 2020-11-25 13:16:30 +01:00
Thomas Lamprecht
a55b3b717f ui: storage edit: avoid returning prune values if unsupported 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-25 13:15:19 +01:00
Wolfgang Bumiller
5865b59747 ad #3140: allow interface suffix in dns entries 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 2020-11-25 12:33:54 +01:00
Dominic Jäger
c63115da85 ui: metrics: Link help button to correct chapter 
... instead of generic PVE admin guide.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
 2020-11-25 12:32:42 +01:00
Dominik Csapak
b22cbac9bf api: metrics/server: add minimum and maximum to port schema 
we just added the api, so it would be good to only accept valid ports
(they were wrapped before)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-25 12:31:42 +01:00
Thomas Lamprecht
de656c26f6 bump version to 6.3-1 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:45:11 +01:00
Stoiko Ivanov
c92fc8a1e8 api2: osd destroy: untaint device before pvremove 
We get the device list from ceph-volume lvm list, and decode the json
output, which at that point is tainted (perlsec (1)).
Untaint it here before calling, because it is currently the only
call-site using the information in a problematic way (run_command).
(the only other call-site being in pve5to6)

Alternatively we could untaint while reading the information, but then
should only return a small subset of the ceph-volume output.

The issue is most likely due to
cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 in pve-common ('run_command:
improve performance for logging and long lines'),

Tested on a virtual testsetup by creating OSDs with second DB disk,
and destroying it via GUI (did not manage to get the error without the
DB disk)

Reported via our community forum:
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
 2020-11-24 23:37:33 +01:00
Stoiko Ivanov
259b557cf4 api2: osd destroy: fix error function 
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
 2020-11-24 23:37:33 +01:00
Thomas Lamprecht
a4b871296f ui: storage content: add encryption and verification columns for PBS 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:36:02 +01:00
Thomas Lamprecht
770d614ff0 ui: factor out backup verification renderer 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:35:39 +01:00
Thomas Lamprecht
3003a59d95 ui: guest backup view: add encrypted column for PBS storages 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:35:15 +01:00
Thomas Lamprecht
ebea3f4507 ui: storage content: allow to specify extraColumns (again) 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:34:25 +01:00
Thomas Lamprecht
1be81ae0d6 ui: storage/browser: pass storage plugin type to content panels 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:33:57 +01:00
Thomas Lamprecht
cfc3a1665a ui: storage: pbs paperkey: print short fingerprint in heading 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:32:20 +01:00
Thomas Lamprecht
db364c61bb ui: storage: pbs: move datastore field to right column for balance 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:10:26 +01:00
Thomas Lamprecht
14ba33fbff ui: storage: pbs: improve encryption key handling 
Move encryption key handling in its own tab.

Allow uploads, warn more visible on edit/remove

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:10:26 +01:00
Thomas Lamprecht
7dda153cca ui: utils: add more generic loadTextFromFile upload helper 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:10:03 +01:00
Thomas Lamprecht
d994d2a712 ui: storage: base: allow adding extra tab panels 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:06:21 +01:00
Thomas Lamprecht
77a9ce3248 api: resources: return plugin type 
The storage one for now.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 23:01:54 +01:00
Thomas Lamprecht
54a589be68 ui: dc/storage: set onlineHelp for prune tab in edit window 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 17:09:51 +01:00
Thomas Lamprecht
7e78e99428 bump version to 6.2-17 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 16:01:48 +01:00
Dominik Csapak
063b6d5e0e API2/Ceph: fix createpools 'add_storages' parameter 
by deleteing it from $ceph_param we deleted it also from
$param since it was only a reference

fix it by extracting it beforehand

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-24 15:45:24 +01:00
Fabian Ebner
56fad7c4e6 ui: storage: show no-keeps hint exactly when needed 
extracting the logic from the previous checkbox listener into a function, which
is also called on field changes and once in afterrender. Calling it initially
makes sure the hint is also displayed at the beginning when editing a storage
with no retention options configured, and the initial disabling of the input
fields for the isCreate case now also happens through that call.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
 2020-11-24 15:45:24 +01:00
Thomas Lamprecht
fbbb2a1428 ui: guest backups: add separator, fix left-over Comments title 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 14:26:18 +01:00
Fabian Ebner
e969d18761 ui: storage backup view: add prune window 
adapted from PBS. Main differences are:
    * API has GET/DELETE distinction instead of 'dry-run'
    * API expects a single property string for the prune options

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
 2020-11-24 14:13:20 +01:00
Dominik Csapak
a6d960f15d ui: add ability to show and edit comments for backups 
for now we filter out pbs storages

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-24 13:47:07 +01:00
Dominik Csapak
ef402242d8 ui: change comment column to notes 
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 2020-11-24 13:47:07 +01:00
Thomas Lamprecht
c2d24034d5 followup code cleanup 
actually cleaning up the initial state, the last patch was OK as is..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 13:38:52 +01:00
Dominic Jäger
93489d898b storage: base edit: Don't send delete during creation 
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
 2020-11-24 13:23:40 +01:00
Dylan Whyte
f00da0a52e UI: Ceph Wizard: language fixup 
Improve the language found in the ceph install Wizard.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
 2020-11-24 12:10:02 +01:00
Thomas Lamprecht
587cdeb55a ui: wizard: fix ceph docs link 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-24 09:27:18 +01:00
Thomas Lamprecht
e194ea7c12 ui: avoid ||= 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 20:12:56 +01:00
Thomas Lamprecht
2407b60bdf bump version to 6.2-16 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 19:35:42 +01:00
Thomas Lamprecht
5b7ab402c4 ui: storage: pbs: add hint for backup retention 
Normally it's better to configure pruning (backup retention) on the
backup server only, as then multiple client settings may not
interfere with each other due to outdated or to strict prune
settings (remember, the strictest prune setting always wins).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 19:33:02 +01:00
Thomas Lamprecht
370fc0c498 storage: drop max backup fields, replaced by pruning 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 19:33:02 +01:00
Thomas Lamprecht
017889f1c3 storage: base edit: add Backup Retention tab 
Support all prune keep- settings we have.

masked if the storage cannot support backups.

We do not care if it is disabled as content type for now, a user can
just set them nonetheless (could show a hint though).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 19:33:02 +01:00
Thomas Lamprecht
232415d99d storage: base edit: move main inputpanel into tab panel 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 19:13:18 +01:00
Thomas Lamprecht
4a45a1d9c8 ui: storage base panel: cope with undefined column2 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 19:13:18 +01:00
Thomas Lamprecht
b942b85542 d/control: bump versioned dependency of libpve-storage-perl 6.2-11 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 16:04:12 +01:00
Fabian Ebner
b63baa391c cleanup keep-all handling 
If keep-all is set to 0, adding it doesn't make a difference,
if the key is not in the hash, it won't show up in the 'values'.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
 2020-11-23 16:03:08 +01:00
Fabian Ebner
1db8529eb2 vzdump: adapt to new keep-all prune option 
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
 2020-11-23 16:03:08 +01:00
Thomas Lamprecht
e41a172b63 ui: snapshot tree: add separator between rollback and edit button 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
 2020-11-23 14:00:07 +01:00
Moayad Almalat
97f8afffd4 close #3114: ui: snapshots: switch Edit and Remove Button & add warning logo 
Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
 2020-11-23 13:57:40 +01:00