Commit Graph

2250 Commits

Author SHA1 Message Date
Thomas Lamprecht
9ee48450b8 ui: fixup missing dangling comma
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-03-15 17:46:28 +01:00
Thomas Lamprecht
187b970075 add notice for nearing Proxmox VE 6.4 End-of-Life
As PVE 6.4 goes out of support in July, add a notice at the top with
a link to the faq, where the EOL dates are and also the upgrade
process is described and linked in short.

This year the base notice got added in proxmox-widget toolkit for
better reuse with our other two products.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-03-15 17:09:10 +01:00
Dominik Csapak
0a26768991 fix #3620: ui: dc/storage: delete empty pbs fingerprint on edit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit c6182270dae0b7af44acad3f858d961fa3f08a94)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-03-14 10:44:20 +01:00
Aaron Lauterer
11daa6364c ui: ha/ressources: fix toggling edit button on selection
It needs to be a 'proxmoxButton' to get activated when selecting a HA
ressource. This was lost during the last code cleanup, commit d11524c.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
(cherry picked from commit 403476f8ef27989f0d7d14ba09938729211f672b)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-07 14:21:39 +02:00
Aaron Lauterer
d4dd47fc88 ui: dc: backup: fix job detail search
'for...in array' returns the id in the array but not the value,
'for...of array' returns the values.

Another issue that I ran into was if the property did not exist.

Checking if the property evaluates to false will catch situations where
the property does not exist or is null. All other situations where there
is a value for the name, id or type, should evaluate to true if present
as they are strings or the VMID.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
(cherry picked from commit cfabe90ecb69a1b4120d37a6879c3bb4772d310c)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-22 11:51:17 +02:00
Dominik Csapak
5caadba86f ui: ceph/Status: fix icon in status grid
there was a spurious leftover single quote("'"), that prevented
the correct css class to be inserted
(e.g., fa-exclamation' instead of fa-exclamation)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit c3b2a34528b40d000564c492cc0fd5ce69432c02)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 17:24:36 +02:00
Dominik Csapak
9e75c00ea4 fix #3470: ui: qemu/CmdMenu: fix confirm message for 'pause' cmd
while the command itself is 'suspend', the task description
is 'qmpause', so simply add a parameter and overwrite it for the pause
menu item

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit 9875adb0c789c1e88d19da32d1f16e63595929e9)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 17:22:08 +02:00
Dominik Csapak
0d08e3e868 ui: fix Guest Summary Notes height
fixes 'infinite' height of the guest notes, by setting the height on the
container a level up

the notes view itself is already scrollable, so if it is too large,
there'll be a scrollbar

this does not change anything for templates, as there we show nothing
under the notes and thus there the infinite height is ok

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit 8530bc4149ee09f149c584870e0c4df5e6066a70)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 13:39:19 +02:00
Thomas Lamprecht
ebe48d7e23 ui: TFA: use correct user-id value when creating TOTP QR code
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit 2abc47ae590de83c0ff7a4fcc7abfbe5bb061088)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-10 09:17:40 +02:00
Dominik Csapak
57cbbfa969 ui: form/CalendarEvent: remove displayField from config
in extjs 7.0, setting the displayField overwrites the displayTpl, which
we use here

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
d6ee17e74f ui: tree/SnapshotTree: use beforedestroy instead of destroy
on extjs 7.0, this triggers when the handler is not available anymore,
so use the beforedestroy event instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
d040c83a54 ui: panel/ConfigPanel: return early on no selection
treelist technically allows deselection and this happens on destruction
in extjs 7.0 so simply return early to avoid errors accessing
components that do not exist anymore

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
e9e1c7de50 ui: panel/ConfigPanel: change ui class to pve-nav
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
cea4b35f49 ui: ResourceGrid: move first update to afterrender
else with extjs 7.0, the first render does not happen yet, because
the grid is not visible at that time

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
22ee5b5c29 ui: form/VMCPUFlagSelector: mark radio-buttons as 'not form fields'
else they might get picked up individually

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
39fe40d8a2 ui: ResourceGrid: correctly remove ResourceStore listener
while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected

instead, use '.mon' on the grid, which automatically cleans up the
listeners

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:00:38 +02:00
Dominik Csapak
aacfcde0e6 ui: dc/RoleView: add variableRowHeight
otherwise the grid is confused about the row height (since it is
variable here) and renders the scrollbars weirdly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:00:38 +02:00
Dominik Csapak
ca2e1752d3 ui: Parser: fix bind and dev mounts for lxc
match returns 'null' if the regex does not match, which is not
destructurable. so we have to save the match and check if it valid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:00:37 +02:00
Thomas Lamprecht
c15d821e0a enable eslint on build
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 17:42:21 +02:00
Thomas Lamprecht
00c3ac53c7 ui: form/storage selector: re-validate after storage list was reloaded
two style fixes thrown in

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
685b52f58c ui: window/Migrate: avoid triggering another info request if already in-progress
use the node as key, so that a target switch would still trigger a
new one - else there's a slight chance that a user could get the
check out-of-sync (from another node).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
d8d4c14b73 ui: window/Migrate: eslint fixes and code cleanup/refactoring/modernize
Use the Proxmox.Async.api2 helper to avoid deep nesting

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
cb139584b1 ui: window/Browser Settings: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
75728a889b ui: window/FW Log Rate: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
3fb9e6f9df ui: window/wizard: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
3405edbefb ui: window/ceph install: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
f4eab70a57 ui: window/bulkaction: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
e5d5764668 ui: window/startup: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
eda300438e ui: snapshot tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Dominic Jäger
90519f8a55 ui: panel/StatusPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
a9e7018401 ui: panel/RunningChart: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
193df2f373 ui: panel/NotesView: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
202298c10b ui: panel/IPSet: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
ee3903451e ui: panel/ConfigPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Thomas Lamprecht
ff0777c520 ui: resource tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 14:00:59 +02:00
Thomas Lamprecht
81cde64305 ui: form/pci: add simple IOMMU group renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:30:06 +02:00
Thomas Lamprecht
a7ec3666b1 ui: qemu/PCI Edit: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:29:29 +02:00
Dominic Jäger
f9fa832270 ui: storage/PBS edit: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 12:12:36 +02:00
Dominic Jäger
61e0576823 ui: qemu: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 12:12:36 +02:00
Thomas Lamprecht
dc90ab40ff ui: node/ZFS-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:11:46 +02:00
Thomas Lamprecht
0a778d0243 ui: node/LVM-Thin-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:11:37 +02:00
Thomas Lamprecht
57c29e0b1d ui: node/LVM-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:11:27 +02:00
Thomas Lamprecht
7650925676 ui: node/directory-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:11:19 +02:00
Thomas Lamprecht
ecbe890b02 ui: node/command menu: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:17:24 +02:00
Thomas Lamprecht
3491bd184a ui: node certs: use new loadFile helper to avoid confusion
we did not handle those cert related files like SSH keys, so do not
suggest so.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
37f2e82ca2 ui: utils: split out general "load local file" helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
48bbb009c3 ui: node/certs: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
028e4cd309 ui: node certs: make delete button safer, add confirmation
IMO the behavior was really dangerous prev., possibly causing
downtime of API accessing stuff with a single mistaken click.

Follow our general pattern and ask for confirmation

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
b1b0fcbcd3 ui: lxc/context cmd: factor out confirmed CT command
unifying CT and VM command menu would be pretty easy now, but I need
to wrap the eslint stuff up, so cannot chase all tails..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 10:19:08 +02:00
Thomas Lamprecht
978ee37981 fixup! ui: qemu/context cmd: code cleanup/refactoring/modernize 2021-05-19 10:18:48 +02:00