proxmox-mirrors/pve-manager
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-manager synced 2025-08-02 17:32:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: dc: backup: fix job detail search

Browse Source 
'for...in array' returns the id in the array but not the value,
'for...of array' returns the values.

Another issue that I ran into was if the property did not exist.

Checking if the property evaluates to false will catch situations where
the property does not exist or is null. All other situations where there
is a value for the name, id or type, should evaluate to true if present
as they are strings or the VMID.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
(cherry picked from commit cfabe90ecb69a1b4120d37a6879c3bb4772d310c)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Aaron Lauterer 2021-06-22 10:07:26 +02:00 committed by Thomas Lamprecht
parent 5886cca256
commit d4dd47fc88
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
www/manager6/dc/Backup.js
View File

@ -515,8 +515,8 @@ Ext.define('PVE.dc.BackupDiskTree', {
data = record.parentNode.data;
}
for (const property in ['name', 'id', 'type']) {
if (data[property] === null) {
for (const property of ['name', 'id', 'type']) {
if (!data[property]) {
continue;
}
let v = data[property].toString();