some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
there we implemented deleteEmpty, which we can use in some cases.
this also fixes a bug in the ControllerSelector where
an empty field would be allowed (but should not)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we had it previously on 8GB for containers, but with the refactoring,
this got lost. this patch changes this back
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
when changing between elements in the tree, either the
start or shutdown buttons were visually flashing (meaning they are
enabled/disabled for a short time and change state shortly after)
this patch fixes that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Acked-by: Emmanuel Kasper <e.kasper@proxmox.com>
Move the remove button into the more button and add a 'Manage HA'
button there, mirroring the changes from the qemu panel.
Allows to add an unmanaged CT to HA or to edit the HA settings of a
managed one.
Fixes: #1518
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Acked-By: Dominik Csapak <d.csapak@proxmox.com>
This button was hidden by default and was intended to show up when a
CT is mounted only.
The check if mounted, was done for OpenVZ and may not become true
currently also we only have CLI helpers for mount/unmount but no API
– so just remove it.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Acked-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
First, there was an additional space between "'" and ")" which lead
me to this.
I could never trigger the case where vmname is undefined, and saw
that we have a almost same default handling in data/ResourceStore.js
So, just use that one instead here - it misses the single-quotes
inside the parentheses, but as there are already said parentheses
this is visually still very OK, IMO.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
It isn't needed as its obvious that the table below show the
configuration. It just takes away space.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
when having an lxc mountpoint/rootfs on a storage which does not
allow the 'rootfs' content (e.g. somebody disabled it after creating
a container there), trying to edit the mp/rootfs broke the gui
now we check if the record exists
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
when having a simple directory as rootfs,
trying to edit it in the gui broke it, because
we tried to disable the backup checkbox which did not exists
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we used a static emptytext at creation, which is wrong after editing
now copied from qemu/Options.js (the name), but instead of deleting the
hostname on the backend on an empty field, we set it to CT<VMID>
(this is also the default in the wizard)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
there were a number of problems in how we reselected vms when they
migrated and selected:
we relied on the data in the configpanel to be static, but since
pveselnode is a reference, it actually changes when the resourcestore
changes
also, handling the reselection as a response to the statusstore failure
is very inconsistent, because we know exactly when a vm moves node in
the tree
this patch removes the whole configpanel vm migration code,
and lets the tree handle it
for this, we have to check if we have to reselect the entry,
deselect it manually and after the treeupdate reselect it
also in the right click selection check we have to check if it is
already selected, else the next selection will get canceled
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
API calls return dates in seconds where the JS Date() constructor
wants millisecond.
For the correct computation use render_timestamp_human_readable.
A similar fix was commited in 4092576b1b
for VMs but Containers missed the fix.
extjs saves the state including the sorter, but cannot serialize the
sorter function. when restoring the state, it is not a valid sorter,
so we delete it before saving
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This allows to display a 'CT', a 'VM', or a 'CT/VM' label
to be displayed, depending on the context.
Currently when restoring a CT backup or creating a CT via the
wizard, we are asked to enter a *VM* ID, which is confusing.
we changed the ssh public key field to a pvetextfield, which return not
an empty string but null, so the .length check failed with an exception
we do not need to delete the field because it does not exists, when
no key is given
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this adds a subclass of Ext.form.field.Number with the settings for
Integers (allowDecimals: false and allowExponential: false and default
step size 1)
and use it where we only accept integers
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we introduced the vertical menus,
each panel is about 30px too wide for having
two side by side with a 1920x1080 resolution
this patch changes, the paddings/sizes so that
this fits again, at the cost of about 30 pixels width
per panel
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
with the reorganizing of the tabs to
the treelist, we forgot to add /firewall to some
urls, making the url for source/destination invalid
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch removes the "system" group
and reorders the options like it was before,
with one exception:
console now comes at second place after summary
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
jslint needs FileReader as global
jslint want object.property instead of object['property']
jslint does not like trailing commas
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we do not use tabpanels anymore,
the hide calls and listeners do nothing,
so we can drop them
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
use new tree functionality of configpanel
move options,network,dns,console under resources (now system)
move firewall subpanels into tree
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
adds a help button to the following panels in the lxc wizard
Template (points to: Container Images)
Root Disk (points to: Container Storage)
Network (points to: Container Network)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
in a previous commit (26c5aba0) we changed the reload
from the activate event to afterrender, because
activate will not be fired as a lazyitem
but this only fires once, so we also reload on activate.
with the lazyitem/tabchange fix from a previous commit,
this has now the correct behaviour
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
it makes more sense to define the padding in context,
rather than directly in the component
especially if we want to use this panel elsewhere in the future
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we cannot save the ram state for lxc containers currently,
it makes no sense to display a column, where every entry is 'no'
i left it there but commented it out, so that when we implement it,
we just have to reenable the column
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
if we do not disable the storageselector with bind mounts,
it automatically sets the first storage which can hold
containers (because of allowBlank: false) and triggers
the dirty flag but clicking on reset does not delete
the value there
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we can simply use the first free one, omit the
selection combobox.
disable the add button if we have 10 or more network
devices
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
The framework value of 100 is not enough for many of our description
fields.
Setting this at the parent component level allow to remove
the end component setting.
before ECMA5 trailing commas in arrays and objects
are forbidden
in jslint this is an error and cannot be deactivated
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}
also fix object['property'] access with
object.property
also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
in one change, there is also a change from object['property']
to object.property which jslint complains about
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
change the order of the contextmenu items to
group functions, also introducing separators
like this:
***
power options
***
moving options
***
console
***
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
