Commit Graph

200 Commits

Author SHA1 Message Date
Thomas Lamprecht
d42ef8da91 ui: lxc: do not disable complete add resource button if no disk caps
While for now you only have elements which require the add disk
capability in the add sections it makes no sense to hide it, as it
would suggest that one can add no resource at all, and can easily
introduce a bug if we add another type of resource here, independent
of disk add cap.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-04-10 09:56:17 +02:00
Dominik Csapak
d35b5b2afb fix #1814: do not enable disk related buttons for audit user
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-04-10 09:50:05 +02:00
Thomas Lamprecht
95e77b22cc ui: ct: fix displaying nic firewall if explicitly 0
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-04-04 16:11:28 +02:00
Christian Ebner
b29918337e fix: #1145 enable CT/VM firewall by default on creation via WebUI
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-04-03 11:25:25 +02:00
Thomas Lamprecht
833b048f9f ui: ct/vm: add tooltip to hibernate and stop button
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-03-30 15:21:12 +01:00
Dominik Csapak
375d291810 gui: show lock in status bar of vms/cts
also add 'tbarSpacing' parameter to ConfigPanel, that controls
the spacing after the title

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-21 18:39:27 +01:00
Oguz Bektas
02307282bd unprivileged:true by default in ct creation
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:52:16 +01:00
Dominik Csapak
95f2a8a21a show hookscript in gui
only viewing, no editing
and show it only when it is set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-31 11:05:55 +01:00
Thomas Lamprecht
60c81a34cc ui: fixup jslint warnings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-12-07 14:03:06 +01:00
Wolfgang Bumiller
7c48f7f717 ui: lxc/features: add fuse
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2018-12-06 15:42:28 +01:00
Wolfgang Bumiller
7bf152bf22 ui: lxc/features: disable nfs and cifs for unprivileged
While we can allow them via the apparmor profile, they still
won't be usable as the kernel doesn't have FS_USERNS_MOUNT
set on those.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2018-12-06 15:42:13 +01:00
Thomas Lamprecht
160673c147 ui: lxc/net: s/i.e./e.g./ and transform to emptyText
We want to name an example here, so `e.g.` would be better.

Also show that in the field if empty. No changes to gettext stuff.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-20 11:10:07 +01:00
Thomas Lamprecht
eb421b2c57 followup: split up and pull out html tags from gettext
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-16 12:19:50 +01:00
Tim Marx
ea3bffd087 fix #1928: ct snapshot: changed rollback message to warning
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-11-16 12:15:05 +01:00
Thomas Lamprecht
93bd0d75c3 fixup: lxc/Resources: add missing trailing semicolon
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-09 14:18:47 +01:00
David Limbeck
1a2fdf62fa fix mount point/unused disk sorting in Resources.js
use the same sort function as for VMs based on group and order

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-09 14:02:26 +01:00
Thomas Lamprecht
237245957f lxc/Features: not that keyctl is unnecessary for privileged
So that users are (hopefully) less confused why this is disabled for
privileged CTs. If we get more feature settings which only make
sense for unprivileged or privileged but not both we could split
this into sections which respective headings, but for one only I
didn't wanted to do this - so just add a boxLabel conditionally.

Cc: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-09 09:25:00 +01:00
Dominik Csapak
a88fcb7d13 gui: expose lxc features
but constrain editing to root@pam
give a checkbox (for now) for nfs and cifs, but keep all that are manually set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-05 10:37:57 +01:00
Fabian Grünbichler
85e6b368d1 switch MP selector to integer input
instead of combobox - 256 elements are too much.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2018-09-11 07:55:28 +02:00
Andrew Neitsch
4998ae6f1f Submit pool if non-empty in lxc CreateWizard
The lxc CreateWizard ignores the pool setting. That makes creating
containers impossible for users who are restricted to using a pool. This
patch fixes that.

Signed-off-by: Andrew Neitsch <andrew@neitsch.ca>
2018-07-11 07:25:48 +02:00
Thomas Lamprecht
fe3d3afc67 ui/ct: add autostart-after-create checkbox to wizard
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-18 10:34:48 +02:00
René Jochum
fdce7d56ce Remove swap/memory limit in the Manager, fixes #1799 2018-06-07 13:44:21 +02:00
Dominik Csapak
abbf0eb74f let NotesView load itself
instead of needing to load from the outside, let NotesView handle the
loading itself

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
768dd5e462 hide irrelevant buttons and tabs for container templates
like we do with vm templates

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-08 16:08:16 +02:00
Dominik Csapak
c7164db743 add container move volume to gui
this reuses the vm HDMove window to move volumes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-07 14:55:49 +02:00
Dominik Csapak
6c4429613f disable the mountpoint selector and path field by default
since in the wizard, the validity check happens before the
viewmodel can set the visible/enabled state so this is invalid there,
even if the remaining panel is valid

setting it to disabled by default, makes the fields 'valid' at the
beginning but retain their behavior

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-02 08:28:29 +02:00
Dominik Csapak
1fe7312bf2 remove the novnc panels for node/container
so that by default the users get xtermjs
not for vms though, since most will still not use a serial
terminal as the display

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-23 09:42:55 +02:00
Dominik Csapak
b08ae04435 overwrite the built-in 'run_editor' function
this is needed for the 'enter' handler

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 14:03:59 +02:00
Dominik Csapak
dc683ca068 better focus of lxc/MPEdit
this gives the focus to either the 'path' field
or to the 'X' tool (if it is a rootfs)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 13:51:30 +02:00
Dominik Csapak
3e4b78dc68 merge cores, cpulimit and cpuunits for containers
like we do for qemu vms

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 13:38:36 +02:00
Dominik Csapak
34c235bea6 lxc/MPEdit: rework for advanced options
this is a complete rework of the inputpanel (long overdue)
it uses a viewModel and viewcontroller to avoid the
multiple is zfs/root/bind checks and concentrate them
in one place

also some features get optimized (e.g. the noreplication checkbox)

adds a setNodename to the DiskStorageSelector so that we can bind
the nodename there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00
Dominik Csapak
14a845bc7b Utils: add forEachMP
in the style of forEachBus, but for containers, so that we
only have to save the count once

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00
Dominik Csapak
53395db153 lxc/ResoureEdit: move some cpu fields to advanced options
and show them now also in the wizard

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00
Dominik Csapak
9bad05bd76 make container clones/template available in the gui
also refactor the right click menu logic

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-21 15:54:32 +01:00
Dominik Csapak
e31690fac0 rework lxc DNS Edit
instead of having 3 server fields, have a single line
which can be ips seperated by ',' ';' or ' '

also now the domain and dns server can be changed seperately

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-16 10:05:57 +01:00
Dominik Csapak
33f459ca5c improve node/lxc/qemu summary pages
let them use a one/two column layout depending on browser width
optimize stylings/padding values
get rid of the (now long) unecessary lazyitems plugin
(this was necessary for performance when we still used tabpanels instead
of our own configpanel with treelist)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-23 11:01:28 +01:00
Thomas Lamprecht
7adbc4a457 ui: declarative LXC Create
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-22 15:04:51 +01:00
Thomas Lamprecht
658bf72581 ui: MPEdit: add setUnprivileged to allow data binding
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-22 15:04:51 +01:00
Thomas Lamprecht
d8e3d77c15 ui: lxc/Network: set empty datachache by default when in wizard
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-22 15:04:51 +01:00
Thomas Lamprecht
857b97a7dc ui: move loadSSHKeyFromFile from lxc/Create to Utils
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-22 15:04:51 +01:00
Dominik Csapak
8cd96756d3 fix edit button for some panels
when using the 'run_editor' function provided by the ObjectGrid,
we have to make sure the function runs in the context of the grid,
not in that of the button, else we cannot access the
selectionModel/rows/etc. of the grid

this happened with the switch to the widget toolkit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-07 10:39:57 +01:00
Dominik Csapak
07de011804 fix #1631: change units to binary prefix
we always expected MiB/GiB but labeled them incorrectly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-31 14:08:34 +01:00
Dominik Csapak
35a04562fd change PVE.UserName/CSRFPreventionToken to Proxmox
this is now all in the widget-toolkit and needs to be
set/read to/from there, else we possibly get an inconsistent view on
those

this fixes as issue, where after login the ResourceStore would not update

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 14:49:11 +01:00
Thomas Lamprecht
ef4ef788d5 use InputPanel from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
0ee5a21ef1 use LogView from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
9cb193cf8c use ObjectStore from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
8cbc11a70c use TaskViewer & TaskProgress window from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
9fccc702ec use windowEdit from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
04444337a3 lxc/Options: cleanup & use a few new features from ObjectGrid
Use also same store update interval as qemu/Options

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
14dd743b9e lxc/Resources: cleanup & use new features from ObjectGrid
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00