mirror of
https://git.proxmox.com/git/pve-manager
synced 2025-08-03 23:46:58 +00:00
api: nodes: allow usage of query url metadata with Sys.AccessNetwork
This was restricted to Sys.Modify + Sys.Audit on the whole cluster to ensure that only trusted users get access to a method that can scan the (local) network from the POV of the Proxmox VE node, even if only through HTTP HEAD requests. Nowadays there's enough user interest [0] to warrant a separate access privilege to cover such an use case, and while most of the requests are for the download-url storage API endpoint, this method here is not only a bit less powerful than the storage one, it's rather tied to the latter anyway (e.g. for querying the metadata of a URL in the web UI for name and size before downloading it to a storage). For backwards compatibility keep the old check and add the new privilege as alternative to fulfill the permission requirements of that API endpoint. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5254 Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Tested-by: Hannes Duerr <h.duerr@proxmox.com> Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
parent
33b0c265ef
commit
6cf1a48d45
@ -1620,7 +1620,10 @@ __PACKAGE__->register_method({
|
||||
description => "Query metadata of an URL: file size, file name and mime type.",
|
||||
proxyto => 'node',
|
||||
permissions => {
|
||||
check => ['perm', '/', [ 'Sys.Audit', 'Sys.Modify' ]],
|
||||
check => ['or',
|
||||
['perm', '/', [ 'Sys.Audit', 'Sys.Modify' ]],
|
||||
['perm', '/nodes/{node}', [ 'Sys.AccessNetwork' ]],
|
||||
],
|
||||
},
|
||||
parameters => {
|
||||
additionalProperties => 0,
|
||||
|
Loading…
Reference in New Issue
Block a user