From 6cf1a48d45417aa8a698f9dadb48a6fe4a206029 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Mon, 19 Feb 2024 17:27:46 +0100 Subject: [PATCH] api: nodes: allow usage of query url metadata with Sys.AccessNetwork MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was restricted to Sys.Modify + Sys.Audit on the whole cluster to ensure that only trusted users get access to a method that can scan the (local) network from the POV of the Proxmox VE node, even if only through HTTP HEAD requests. Nowadays there's enough user interest [0] to warrant a separate access privilege to cover such an use case, and while most of the requests are for the download-url storage API endpoint, this method here is not only a bit less powerful than the storage one, it's rather tied to the latter anyway (e.g. for querying the metadata of a URL in the web UI for name and size before downloading it to a storage). For backwards compatibility keep the old check and add the new privilege as alternative to fulfill the permission requirements of that API endpoint. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5254 Signed-off-by: Thomas Lamprecht Tested-by: Hannes Duerr Reviewed-by: Fabian Grünbichler --- PVE/API2/Nodes.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 67a8ce22..cc5ee65e 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1620,7 +1620,10 @@ __PACKAGE__->register_method({ description => "Query metadata of an URL: file size, file name and mime type.", proxyto => 'node', permissions => { - check => ['perm', '/', [ 'Sys.Audit', 'Sys.Modify' ]], + check => ['or', + ['perm', '/', [ 'Sys.Audit', 'Sys.Modify' ]], + ['perm', '/nodes/{node}', [ 'Sys.AccessNetwork' ]], + ], }, parameters => { additionalProperties => 0,