pve-eslint/eslint/docs/rules/no-self-assign.md
Dominik Csapak eb39fafa4f first commit
includes a (minimal) working wrapper

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-06 15:06:03 +02:00

87 lines
1.7 KiB
Markdown

# Disallow Self Assignment (no-self-assign)
Self assignments have no effect, so probably those are an error due to incomplete refactoring.
Those indicate that what you should do is still remaining.
```js
foo = foo;
[bar, baz] = [bar, qiz];
```
## Rule Details
This rule is aimed at eliminating self assignments.
Examples of **incorrect** code for this rule:
```js
/*eslint no-self-assign: "error"*/
foo = foo;
[a, b] = [a, b];
[a, ...b] = [x, ...b];
({a, b} = {a, x});
```
Examples of **correct** code for this rule:
```js
/*eslint no-self-assign: "error"*/
foo = bar;
[a, b] = [b, a];
// This pattern is warned by the `no-use-before-define` rule.
let foo = foo;
// The default values have an effect.
[foo = 1] = [foo];
// non-self-assignments with properties.
obj.a = obj.b;
obj.a.b = obj.c.b;
obj.a.b = obj.a.c;
obj[a] = obj["a"];
// This ignores if there is a function call.
obj.a().b = obj.a().b;
a().b = a().b;
// Known limitation: this does not support computed properties except single literal or single identifier.
obj[a + b] = obj[a + b];
obj["a" + "b"] = obj["a" + "b"];
```
## Options
This rule has the option to check properties as well.
```json
{
"no-self-assign": ["error", {"props": true}]
}
```
- `props` - if this is `true`, `no-self-assign` rule warns self-assignments of properties. Default is `true`.
### props
Examples of **correct** code with the `{ "props": false }` option:
```js
/*eslint no-self-assign: ["error", {"props": false}]*/
// self-assignments with properties.
obj.a = obj.a;
obj.a.b = obj.a.b;
obj["a"] = obj["a"];
obj[a] = obj[a];
```
## When Not To Use It
If you don't want to notify about self assignments, then it's safe to disable this rule.