mirror of
https://git.proxmox.com/git/pve-eslint
synced 2025-10-05 20:55:26 +00:00
eb39fafa4f
includes a (minimal) working wrapper Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
68 lines
2.3 KiB
Markdown
68 lines
2.3 KiB
Markdown
# Require Dot Notation (dot-notation)
|
|
|
|
In JavaScript, one can access properties using the dot notation (`foo.bar`) or square-bracket notation (`foo["bar"]`). However, the dot notation is often preferred because it is easier to read, less verbose, and works better with aggressive JavaScript minimizers.
|
|
|
|
```js
|
|
foo["bar"];
|
|
```
|
|
|
|
## Rule Details
|
|
|
|
This rule is aimed at maintaining code consistency and improving code readability by encouraging use of the dot notation style whenever possible. As such, it will warn when it encounters an unnecessary use of square-bracket notation.
|
|
|
|
Examples of **incorrect** code for this rule:
|
|
|
|
```js
|
|
/*eslint dot-notation: "error"*/
|
|
|
|
var x = foo["bar"];
|
|
```
|
|
|
|
Examples of **correct** code for this rule:
|
|
|
|
```js
|
|
/*eslint dot-notation: "error"*/
|
|
|
|
var x = foo.bar;
|
|
|
|
var x = foo[bar]; // Property name is a variable, square-bracket notation required
|
|
```
|
|
|
|
## Options
|
|
|
|
This rule accepts a single options argument:
|
|
|
|
* Set the `allowKeywords` option to `false` (default is `true`) to follow ECMAScript version 3 compatible style, avoiding dot notation for reserved word properties.
|
|
* Set the `allowPattern` option to a regular expression string to allow bracket notation for property names that match a pattern (by default, no pattern is tested).
|
|
|
|
### allowKeywords
|
|
|
|
Examples of **correct** code for the `{ "allowKeywords": false }` option:
|
|
|
|
```js
|
|
/*eslint dot-notation: ["error", { "allowKeywords": false }]*/
|
|
|
|
var foo = { "class": "CS 101" }
|
|
var x = foo["class"]; // Property name is a reserved word, square-bracket notation required
|
|
```
|
|
|
|
### allowPattern
|
|
|
|
For example, when preparing data to be sent to an external API, it is often required to use property names that include underscores. If the `camelcase` rule is in effect, these [snake case](https://en.wikipedia.org/wiki/Snake_case) properties would not be allowed. By providing an `allowPattern` to the `dot-notation` rule, these snake case properties can be accessed with bracket notation.
|
|
|
|
Examples of **correct** code for the sample `{ "allowPattern": "^[a-z]+(_[a-z]+)+$" }` option:
|
|
|
|
```js
|
|
/*eslint camelcase: "error"*/
|
|
/*eslint dot-notation: ["error", { "allowPattern": "^[a-z]+(_[a-z]+)+$" }]*/
|
|
|
|
var data = {};
|
|
data.foo_bar = 42;
|
|
|
|
var data = {};
|
|
data["fooBar"] = 42;
|
|
|
|
var data = {};
|
|
data["foo_bar"] = 42; // no warning
|
|
```
|