Rename the helper method to get the archive name from a device name
to reduce possible miss-use. The helper adds a `.img.fidx` filename
extension uncoditionally before parsing the `BackupArchiveName`.
No functional changes intended.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Commit 16298c5f ("update to current PBS master") introduced a helper
method to generate the backup archive names from a device name.
However, the helper was also used incorrectly to generate archive
names from strings already having the `.img.fidx` filename extension.
As the extension is appended unconditionally, this leads to an
archive name which will parse successfully, but not be the expected
archive name to be found in the backup manifest.
Fix this by dropping the incorrect helper call-sites and adapt the
function parameters to take a `BackupArchiveName` directly, reducing
potential for future mishandling.
Fixes: Commit 16298c5f ("update to current PBS master")
Reported-by: Markus Frank <m.frank@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Markus Frank <m.frank@proxmox.com>
We moved pbs-api-types out of proxmox-backup and package it now like
our other rust source code crates for better reuse. Switch this use
site over to use the package variant, not the submodule one, as the
latter won't exist anymore once we update the submodule the next time
anyway.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
the old location has been deprecated for a while, and rustc 1.78 will start to warn about it.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
they then get stripped into their own package anyway, but without this we don't
get debug symbols at all with rustc >= 1.77
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Commit c7077bb3 moved ProxmoxBackupHandle into a separate file and
accidentally made it private in the process.
Revert this behaviour by making ProxmoxBackupHandle and
ProxmoxRestoreHandle accessible from outside of the crate again. These
handles are used in the function signatures of several public functions,
therefore it makes sense to have them public as well.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
cbindgen still requires syn 1.x unfortunately, the new version picks up
wakeup_callback which we don't actually need in our interface, so exclude it at
least until the next bump happens for other reasons.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This fixes dependency installation errors when running the
`mk-build-deps --install` command against the current proxmox devel
bookworm repository.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
as we also track the PBS dependencies in d/control, as the workspace
crates we use from there cannot profit from being handled by debian
dependency system, like the others which are shipped as .deb package
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
to allow easier building in restricted environments, in core
principle nothing changes, those crates got and get in via git, some
way or another.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
