Commit Graph

1454 Commits

Author SHA1 Message Date
Daniel Imms
0b1711fb79 Merge pull request #873 from Tyriar/860_resize_exception
Fix exception when resizing both dimensions
2017-08-08 18:03:02 -07:00
Daniel Imms
bb526aaa88 Fix exception when resizing both dimensions
This happened because buffers now resize themselves but they were
relying on Terminal to give them a blank line. The blank line was
coming back with the old columns value, causing an NPE.

Fixes #860
2017-08-08 12:59:02 -07:00
Paris Kasidiaris
a28d9f1456
Bump version to 2.9.1
Signed-off-by: Paris Kasidiaris <paris@sourcelair.com>
2017-08-06 17:50:53 +00:00
Daniel Imms
fb6b173fe7 Merge pull request #843 from Tyriar/842_resize_buffers_bug
Resize both buffers on resize, clean up alt buffer state
2017-08-06 10:34:50 -07:00
Daniel Imms
1361ff8e22 Merge branch 'master' into 842_resize_buffers_bug 2017-08-06 10:25:38 -07:00
Daniel Imms
0731f28615 jsdoc 2017-08-06 10:25:25 -07:00
Paris Kasidiaris
f7b58d0718 Merge pull request #834 from blink1073/webpack-fix
Prevent Webpack warning in 2.9.0
2017-08-06 13:25:08 +03:00
Daniel Imms
d46003843b Add tests for Buffer.fillViewportRows 2017-08-05 20:15:23 -07:00
Daniel Imms
13619d427a Add a bunch of Buffer tests 🎉 2017-08-05 20:11:26 -07:00
Daniel Imms
f03d00a497 Clean up buffer clean up/fill logic
The alt buffer is now cleared immediated after activating the normal buffer and
is filled when switching to it. The tests were failing because the alt buffer
wasn't being cleared properly with the previous solution.
2017-08-05 19:42:54 -07:00
Daniel Imms
3d20c2f266 Resize both buffers on resize
This brings in proper support to resize both buffers (#510) and fixes an
exception that was caused by wrongfully not clearing the normal buffer when
resizing while the alt buffer is active.

There was an obscure bug in this that could have caused some great confusion
later on; When switching to the alt buffer, a hard terminal reset was performed
which tried to retain the buffers. However, because buffers was initialized in
the Terminal constructor to a new BufferSet, the Terminal.buffer convenience
pointer was pointing at a stale alt buffer which was the one actually being
used, not Terminal.buffers.alt.

Fixes #842
Fixes #510
2017-08-05 18:59:44 -07:00
Steven Silvester
6f749b196a Prevent webpack error 2017-08-03 14:43:51 -05:00
Paris Kasidiaris
f5ba386c01
Bump version to 2.9.0
Signed-off-by: Paris Kasidiaris <paris@sourcelair.com>
2017-08-03 18:43:14 +00:00
Daniel Imms
0079677e43 Merge pull request #781 from mofux/cursor_color
Retain the color of a character for underline and bar cursor styles
2017-08-03 09:16:23 -07:00
mofux
106eda7067 Merge changes from #828 2017-08-02 17:42:43 +02:00
Paris Kasidiaris
f13455965c Merge pull request #828 from sourcelair/issue-#827-fix-terminal-focus
Always focus terminal on click
2017-08-02 18:33:51 +03:00
thomas
5bc0ad879b Set xterm-color for cursor element
Prevent focus from getting lost when in vt mouse mode
Fix: cursor style not applied on init, set a class for block cursor
Make all cursors work under all conditions (focused, unfocused, blink)
Unify cursor rendering with normal rendering code
Make sure underline AND blink can be used in co-existence
Always show outlined block cursor in unfocused state
2017-08-02 15:41:18 +02:00
Paris Kasidiaris
72e85a352a Focus on mousedown, instead of click 2017-08-02 16:03:56 +03:00
Paris Kasidiaris
49c1ca3f57 Fix #827: Always focus terminal on click 2017-08-02 10:44:16 +03:00
Daniel Imms
bcff69b79c Merge pull request #816 from joaomoreno/alt-selection
Alt key should force selection
2017-07-28 14:24:45 -07:00
Daniel Imms
3f7fec8c91 Merge branch 'master' into alt-selection 2017-07-28 14:07:43 -07:00
Daniel Imms
3479614c73 Disable selection override on Windows/Linux 2017-07-28 14:06:55 -07:00
Daniel Imms
34f075a8cc Merge pull request #822 from Tyriar/818_fix_save_restore_cursor
Fix save and restore cursor behavior
2017-07-28 08:58:03 -07:00
Daniel Imms
ff165e8627 Merge branch 'master' into 818_fix_save_restore_cursor 2017-07-28 08:33:52 -07:00
Paris Kasidiaris
cdcbf60e44 Merge pull request #823 from jpmasters/master
Issue #821 - Prevent TypeError in resize()
2017-07-28 15:02:38 +03:00
Jon Masters
2d4e617c95 Issue #821 - Prevent TypeError in resize() 2017-07-28 11:54:46 +00:00
Daniel Imms
6ea7758ab1 Add test for save and restore cursor 2017-07-27 16:35:48 -07:00
Daniel Imms
604959a319 Fix save and restore cursor behavior
This broke in #717.

Fixes #818
2017-07-27 16:28:27 -07:00
Joao Moreno
6a3b39b428 fix context menu in disabled state 2017-07-26 09:07:20 +02:00
Joao Moreno
9e80a12462 fix tests 2017-07-25 17:17:48 +02:00
Joao Moreno
0e0ecc2d6a listen to shift when in Linux 2017-07-25 17:11:41 +02:00
Joao Moreno
f872ced863 oops, this is a function 2017-07-25 11:30:03 +02:00
Joao Moreno
9a30b98880 safeguard npe 2017-07-25 10:45:45 +02:00
Daniel Imms
f36bd24e1e Merge pull request #817 from Lixire/master
Add lineFeed event
2017-07-24 14:58:32 -07:00
t-amqi
23dd3d7a67 Fix indentation 2017-07-24 13:41:24 -07:00
t-amqi
79965708ab Add lineFeed event
- this is useful for checking when a cmd is entered or when a cmd finishes
- also handy to have for accessibility for output
2017-07-24 11:43:03 -07:00
Joao Moreno
80a83ff8d9 wip: alt forces selection 2017-07-24 18:08:11 +02:00
Daniel Imms
2e9177a032 Merge pull request #810 from Tyriar/809_onSingleClick_null_check
Make SelectionManager more resilient
2017-07-21 06:30:56 -07:00
Daniel Imms
bbb5daa575 Merge branch 'master' into 809_onSingleClick_null_check 2017-07-21 06:22:43 -07:00
Daniel Imms
739bd05037 Merge pull request #811 from blink1073/add-jupyter
Add JupyterLab as a real-world use case
2017-07-21 06:17:56 -07:00
Steven Silvester
f7197c10df Add JupyterLab as a real-world use case 2017-07-21 07:59:28 -05:00
Daniel Imms
e56f710cd1 Make SelectionManager more resilient
Fixes #809
2017-07-21 05:45:53 -07:00
Daniel Imms
18f3cc77e5 Merge pull request #805 from Tyriar/801_null_check
Add null check when mouse coords are bad
2017-07-20 09:19:09 -07:00
Daniel Imms
e3ded61122 Add null check when mouse coords are bad
This happens if the viewport is bad (which was fixed in another commit).

Fixes #801
2017-07-18 20:34:24 -07:00
Daniel Imms
f8e3fa5a99 Fix browserify build and search addon (#804)
Fixes #803
2017-07-18 19:58:35 -07:00
Daniel Imms
05d308a37a Merge pull request #798 from jerch/faster_wcwidth
faster wcwidth with lookup table
2017-07-18 14:23:42 -07:00
Jörg Breitbart
cd5827e69b higher timeout for test case 2017-07-18 22:19:55 +02:00
Daniel Imms
20048d31a1 Merge branch 'master' into faster_wcwidth 2017-07-17 11:06:38 -07:00
Jörg Breitbart
598a729fc0 fixes #799 - lookup table is created on first wcwidth call for char > 127 2017-07-17 19:07:02 +02:00
Jörg Breitbart
6ed5c9e64d speed test commented out 2017-07-16 23:53:41 +02:00