Commit Graph

6593 Commits

Author SHA1 Message Date
Christian Brauner
5a24adb870
criu: do_restore()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:42 +01:00
Christian Brauner
665bb114c4
criu: criu_version_ok()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:41 +01:00
Christian Brauner
4f43526d74
criu: __criu_check_feature()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:39 +01:00
Christian Brauner
dfa7eaeb21
lxccontainer: create_container_dir()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:38 +01:00
Christian Brauner
78d44e5af5
lxccontainer: do_create_container_dir()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:37 +01:00
Christian Brauner
9f52e3317d
lxccontainer: lxcapi_startl()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:36 +01:00
Christian Brauner
0c14779f09
lxccontainer: lxcapi_start()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:35 +01:00
Christian Brauner
702bf732f8
lxccontainer: free_init_cmd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:33 +01:00
Christian Brauner
75bd13abd3
lxccontainer: split_init_cmd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:32 +01:00
Christian Brauner
1452d3fe06
lxccontainer: push_arg()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:31 +01:00
Christian Brauner
6b0297e327
lxccontainer: am_single_threaded()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:30 +01:00
Christian Brauner
e202dfb821
lxccontainer: do_lxcapi_wait()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:29 +01:00
Christian Brauner
871ed23baa
lxccontainer: do_lxcapi_want_close_all_fds()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:27 +01:00
Christian Brauner
fb5999f65f
lxccontainer: do_lxcapi_want_daemonize()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:26 +01:00
Christian Brauner
d03ab308a7
lxccontainer: do_lxcapi_load_config()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:25 +01:00
Christian Brauner
e3246ab9c8
lxccontainer: load_config_locked()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:24 +01:00
Christian Brauner
49cfedb329
lxccontainer: lxcapi_console()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:23 +01:00
Christian Brauner
37dce81753
lxccontainer: do_lxcapi_console_getfd()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:22 +01:00
Christian Brauner
8e59e0bab2
lxccontainer: do_lxcapi_unfreeze()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:20 +01:00
Christian Brauner
8787b387db
lxccontainer: do_lxcapi_freeze()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:19 +01:00
Christian Brauner
1b61062fa7
lxccontainer: do_lxcapi_is_running()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:18 +01:00
Christian Brauner
5bddcb62d2
lxccontainer: is_stopped()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:17 +01:00
Christian Brauner
b547d79fb9
lxccontainer: do_lxcapi_state()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:14 +01:00
Christian Brauner
428ad142f2
lxccontainer: do_lxcapi_is_defined()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:13 +01:00
Christian Brauner
045552aabe
lxccontainer: lxc_container_{get,put}()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:11 +01:00
Christian Brauner
70849dc234
lxccontainer: lxc_container_free()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:10 +01:00
Christian Brauner
a3740e805a
lxccontainer: create_partial()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:09 +01:00
Christian Brauner
f5cd0252f7
lxccontainer: create_partial()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:07 +01:00
Christian Brauner
444249ea2f
lxccontainer: ongoing_create()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:06 +01:00
Christian Brauner
ef1ab8f10d
lxccontainer: config_file_exists()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:05 +01:00
Christian Brauner
238b3e5ea4
lxccontainer: move macros to utils.h
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:03 +01:00
Christian Brauner
0e1a60b0fb
lxccontainer: do_lxcapi_save_config()
If liblxc is used multi-threaded do_lxcapi_save_config() could be called from
threads that fork() which to not risk ending up with invalid locking states we
should avoid using functions like fopen() that internally allocate memory and
use locking. Let's replace it with the async-signal safe combination of
open() + write().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:02 +01:00
Christian Brauner
a30b9023a0
network: lxc_delete_network_unpriv_exec()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:38:00 +01:00
Christian Brauner
780700561e
network: lxc_create_network_unpriv_exec()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:59 +01:00
Christian Brauner
ebd582aeea
network: lxc_netdev_move_wlan()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:58 +01:00
Christian Brauner
05ec44f842
network: lxc_netdev_rename_by_name_in_netns()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:57 +01:00
Christian Brauner
d8b3f9c34a
utils: run_command()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:56 +01:00
Christian Brauner
03f618afc3
utils: lxc_popen()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:54 +01:00
Christian Brauner
7249588c79
lxclock: {un}lock_mutex()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:53 +01:00
Christian Brauner
8d7b6c25af
lxccontainer: do_lxcapi_detach_interface()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:52 +01:00
Christian Brauner
a7764ce792
lxccontainer: do_add_remove_node()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:51 +01:00
Christian Brauner
d8480a31b4
lxccontainer: do_lxcapi_clone()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:50 +01:00
Christian Brauner
fe1ce58c9a
lxccontainer: do_lxcapi_get_ips()
thread-safety: s/exit/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:49 +01:00
Christian Brauner
02c611b013
lxccontainer: do_lxcapi_get_interfaces()
thread-safety: s/exit()/_exit/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:47 +01:00
Christian Brauner
85aec4aca7
lxccontainer: do_lxcapi_create()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:46 +01:00
Christian Brauner
47e558874c
lxccontainer: non-functional changes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:45 +01:00
Christian Brauner
7e34710e5d
lxccontainer: non-functional changes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:44 +01:00
Christian Brauner
eb70aaf0d6
lxccontainer: create_run_template()
thread_safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:42 +01:00
Christian Brauner
d608fbdadb
lxccontainer: do_lxcapi_start()
thread-safety: s/exit()/_exit()/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:41 +01:00
Christian Brauner
9994d1402c
confile: use mmap() to parse config file
Sigh, this is going to be fun. Essentially, dynamic memory allocation through
malloc() and friends is unsafe when fork()ing in threads. The locking state
that glibc maintains internally might get messed up when the process that
fork()ed calls malloc or calls functions that malloc() internally. Functions
that internally malloc() include fopen(). One solution here is to use open() +
mmap() instead of fopen() + getline().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-02-24 21:37:39 +01:00