Commit Graph

7158 Commits

Author SHA1 Message Date
Christian Brauner
4d87983842
confile: add missing header
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-24 15:03:20 +02:00
2xsec
46b217d75a
change log macro of error case from lxc_ambient_caps_up/down
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 15:00:06 +02:00
2xsec
8713009ec5
docs: tools: -d/--daemonize for lxc-execute
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 15:00:04 +02:00
2xsec
4819db24a1
coverity: #1438067
Explicit null dereferenced

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 15:00:02 +02:00
2xsec
03df81a490
thread safe: rand() => rand_r()
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 15:00:00 +02:00
2xsec
431b95c4a4
attach: move errno handling
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:59 +02:00
2xsec
a71e32ca2f
docs: add long options of lxc-unshare
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:56 +02:00
2xsec
a01dec487b
attach: fix return value & cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:54 +02:00
2xsec
96d48ff33b
af_unix: fix return value & cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:53 +02:00
2xsec
cbeda58276
lxccontainer: coding rules
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:51 +02:00
2xsec
94d4ec349c
confile_utils: fix return value & cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:45 +02:00
Markos Chandras
9748d3f1de
apparmor: Allow /usr/lib* paths for mount and pivot_root
openSUSE Leap 15 is using --libdir=/usr/lib64 when building for
x86_64 so we need to allow this path in the apparmor profiles.

Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1099239
Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-07-24 14:59:42 +02:00
Christian Brauner
53c1c86579
conf: the atime flags are locked in userns
This means they need to be added for remount and for fresh mounts.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-24 14:59:39 +02:00
Christian Brauner
370caa5113
confile: move signal helpers to confile utils
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-24 14:59:09 +02:00
2xsec
200c29b146
coverity: #1437949
Argument cannot be negative

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:08 +02:00
2xsec
671df9f10c
tools: lxc-unshare: use lxc list for interface names
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:06 +02:00
2xsec
4dcb39cc35
tools: lxc-unshare: fix wrong coding rules
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:03 +02:00
2xsec
0afaa1317e
tools: lxc-unshare: apply argument parser of lxc and log system of lxc
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:59:02 +02:00
Felix Abecassis
c6c38b301a
confile: fix incorrect strncmp
Passing additional configuration options with "--define" was broken.

Result of git bisect:
d899f11b7b is the first bad commit

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
2018-07-24 14:58:59 +02:00
2xsec
34e443452f
lxclock: change error log using strerror to SYSERROR
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-24 14:58:58 +02:00
Christian Brauner
52c727bb4f
coverity: #1437935
Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-24 14:58:56 +02:00
Christian Brauner
b4e5d17e3e
coverity: #1437936
Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-24 14:58:53 +02:00
Christian Brauner
d81111a658
attach: cleanup log messages in lxc_attach()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:25 +02:00
Christian Brauner
2bbdb2595b
attach: use fd_cloexec()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:24 +02:00
Christian Brauner
a333a9d55d
attach: cleanup no_new_privs()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:22 +02:00
Christian Brauner
ced643a04d
attach: cleanup fetch_seccomp()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:21 +02:00
Christian Brauner
2f8e7d7408
attach: simplify lxc_attach_getpwshell()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:20 +02:00
Christian Brauner
c221e3780a
conf: handle partially functional device nodes
This improves handling kernels which allow userspace to create partially
functional devices nodes.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:19 +02:00
Christian Brauner
50baaba795
autotools: cleanup Makefile.am
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-12 17:32:18 +02:00
2xsec
6a5d4f8c3b
tools: lxc-ls: fix signed_to_bigger_unsigned issue
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-12 17:32:14 +02:00
Christian Brauner
57585db945
start: don't unconditionally open("/dev/null")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-11 22:15:23 +02:00
Christian Brauner
9e793462b8
conf: create /dev directory
If users specified lxc.autodev = 1 it does not make sense to skip setting up
autodev if /dev does not exist. We rather should create it.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-11 22:15:21 +02:00
Christian Brauner
da0353d9b9
autotools: build both a shared and static liblxc
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Serge Hallyn <serge@hallyn.com>
Cc: Tycho Andersen <tycho@tycho.ws>
2018-07-11 22:15:16 +02:00
2xsec
6e824338ae
tools: lxc-unshare: replace write_id_mapping() to the same function in conf.c
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-11 22:15:13 +02:00
2xsec
f2c0d8f20a
tools: lxc-unshare: replace converting standard identifiers of namespaces to api
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-11 22:15:12 +02:00
2xsec
d98ccfe8b4
tools: lxc-attach: replace converting standard identifiers of namespaces to api
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-11 22:15:11 +02:00
2xsec
c12d8fa773
namespace: add api to convert namespaces to standard identifiers
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-11 22:15:06 +02:00
Christian Brauner
311e6357fd
tree-wide: set MSG_NOSIGNAL
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 13:07:40 +02:00
Christian Brauner
58c94cd897
start: declare int array const
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 13:07:38 +02:00
Christian Brauner
9a462e703f
start: refactor match_stdfds()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 13:07:35 +02:00
Christian Brauner
83df46815c
terminal: don't garble output
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 13:07:33 +02:00
Christian Brauner
342a259580
conf: use mknod() to create dummy mount targets
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-06 13:07:29 +02:00
Christian Brauner
58343d36e2
conf: use mknod() to create dummy mount target
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:37 +02:00
Christian Brauner
8f3352c3e1
conf: safely retrieve path of slave device
openpty() is a horrible function that uses strcpy() into the char *name
argument if name != NULL. We can't rely on the path being sane in all cases so
let's split out the name retrieval to ttyname_r().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:36 +02:00
Christian Brauner
494b7bc3a1
conf: use fd_cloexec()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:35 +02:00
Christian Brauner
f004102940
cgfsng: respect lxc.cgroup.use
If lxc.cgroup.use is specified then only those controllers listed in there will
be used others will be skipped.

Closes #2447.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:34 +02:00
Christian Brauner
4ef7288638
cgroups: remove is_crucial_cgroup_subsystem()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:33 +02:00
2xsec
0197b5a80f
log: remove the trailing .
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2018-07-04 18:21:33 +02:00
Christian Brauner
2c68cbd09f
log: cleanup
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:32 +02:00
Christian Brauner
1a50d04eca
tree-wide: remove unneeded log prefixes
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2018-07-04 18:21:29 +02:00