mirror_frr/tests/topotests/static_routing_with_ebgp
Christian Hopps ed776e38f6
tests: apply KISS to retry fixture
This python fixture was way too complex for what is needed.

Eliminate gratuitous options/over-engineering:

- Change from non-deterministic `wait` and `attempts` to a single
`retry_timeout` value. This is both more deterministic, as well as
what the user should actually be thinking about.

- Use a fixed 2 second pause between executing the wrapped function
rather than a bunch of arbitrary choices of 2, 3 and 4 seconds
spread all over the test code.

- Get rid of the multiple variables for determining what "Positive" and
"Negative" results are. Instead just implement what all the user code
already wants, i.e., boolean False or a str (errormsg) means
"Negative" result otherwise it's a "Positive" result.

- As part of the above the inversion logic is much more comprehensible
in the fixture code (and more correct to boot).

Signed-off-by: Christian Hopps <chopps@labn.net>
2021-06-25 05:33:04 +00:00
..
static_routes_topo1_ebgp.json tests: Enchanced static routing testsuits 2020-12-10 16:44:48 -08:00
static_routes_topo2_ebgp.json tests: Enchanced static routing testsuits 2020-12-10 16:44:48 -08:00
static_routes_topo3_ebgp.json tests: Static route cases with admin dist and tag. 2021-01-12 17:13:26 +05:30
static_routes_topo4_ebgp.json tests: Adding static routing topojson automation suites. 2020-12-10 16:44:48 -08:00
test_static_routes_topo1_ebgp.py tests: run black over mcast-pim-static, static_routing_with_[ei]bgp 2021-04-13 13:34:57 -04:00
test_static_routes_topo2_ebgp.py tests: apply KISS to retry fixture 2021-06-25 05:33:04 +00:00
test_static_routes_topo3_ebgp.py tests: run black over mcast-pim-static, static_routing_with_[ei]bgp 2021-04-13 13:34:57 -04:00
test_static_routes_topo4_ebgp.py tests: run black over mcast-pim-static, static_routing_with_[ei]bgp 2021-04-13 13:34:57 -04:00