mirror_frr/ospfd
Joakim Tjernlund 9289c6ff55 ospfd: Do not fall back to intervening router.
The patch in bug 330 did two things. It add a return value
whether ospf_nexthop_calculation() failed or not and also
moved the return stmt for 16.1.1 para 5 so now SPF
will fallback to the intervening router when no back links are found
by 16.1.1 para 5. This is wrong and can potentially create black holes
or routing loops according to Dave Katz and Acee Lindem at ospf@ietf.org

Even if the current code could be proved to be harmless in all cases,
it adds substantial extra processing and memory allocations.

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2012-07-25 18:07:45 +02:00
..
.gitignore [administrivia] Git should ignore backup files and .loT files 2008-08-22 20:00:46 +01:00
ChangeLog.opaque.txt Initial revision 2003-02-03 16:31:16 +00:00
Makefile.am build: use net-snmp-config to configure NetSNMP 2012-06-25 19:03:23 +02:00
ospf_abr.c ospfd: fix bug in NSSA ABR status check 2012-01-02 18:38:04 +04:00
ospf_abr.h 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com> 2005-09-29 13:52:57 +00:00
ospf_api.c ospf: Fix OSPF API and ospf-te LSA refreshers to match recent API change 2011-04-13 15:13:33 +01:00
ospf_api.h 2005-05-06 Paul Jakma <paul.jakma@sun.com> 2005-05-06 21:37:42 +00:00
ospf_apiserver.c ospf: Fix OSPF API and ospf-te LSA refreshers to match recent API change 2011-04-13 15:13:33 +01:00
ospf_apiserver.h ospf: Fix OSPF API and ospf-te LSA refreshers to match recent API change 2011-04-13 15:13:33 +01:00
ospf_asbr.c ospfd: avoid redundant lookup in ospf_redistribute_withdraw 2011-12-06 15:02:52 +04:00
ospf_asbr.h [ospfd] CID #28, remove another ospf_lookup call - ospf_redistribute_withdraw 2006-05-12 23:02:46 +00:00
ospf_ase.c ospfd: address more trivial compiler warnings 2012-01-08 11:43:07 +00:00
ospf_ase.h 2005-05-06 Paul Jakma <paul.jakma@sun.com> 2005-05-06 21:37:42 +00:00
ospf_dump.c ospfd: introduce ospf_auth_type_str[] 2012-03-12 11:05:34 +01:00
ospf_dump.h ospfd: introduce ospf_auth_type_str[] 2012-03-12 11:05:34 +01:00
ospf_flood.c ospfd: improve fix to CVE-2011-3326 (BZ#586) 2011-11-15 20:50:48 +04:00
ospf_flood.h ospfd: Fix maxage/flush to not try flood twice, remember maxages for longer 2010-12-08 17:13:19 +00:00
ospf_ia.c [ospfd] CID #14, NULL check ospf->backbone before use, ospf_update_router_route 2006-05-12 23:04:45 +00:00
ospf_ia.h 2005-05-06 Paul Jakma <paul.jakma@sun.com> 2005-05-06 21:37:42 +00:00
ospf_interface.c ospfd: Optimize and improve SPF nexthop calculation 2012-07-25 18:07:30 +02:00
ospf_interface.h ospfd: Optimize and improve SPF nexthop calculation 2012-07-25 18:07:30 +02:00
ospf_ism.c ospfd: Unify router and network LSA refresh logic with general refresher 2010-12-08 17:13:19 +00:00
ospf_ism.h [ospfd] Make OSPF_ISM_TIMER_OFF macro safer. 2005-11-16 19:33:22 +00:00
ospf_lsa.c ospfd: Optimize and improve SPF nexthop calculation 2012-07-25 18:07:30 +02:00
ospf_lsa.h ospfd: adjust OSPF_ROUTER_LSA_MIN_SIZE for VL case 2012-04-11 23:18:29 +02:00
ospf_lsdb.c ospfd: Fix various route_unlock discrepencies 2010-12-08 17:11:18 +00:00
ospf_lsdb.h 2005-05-06 Paul Jakma <paul.jakma@sun.com> 2005-05-06 21:37:42 +00:00
ospf_main.c quagga: option "-z" ("--socket <path>") added 2011-12-13 14:26:28 +04:00
ospf_neighbor.c [cleanup] Convert XMALLOC/memset to XCALLOC 2009-06-12 17:07:49 +01:00
ospf_neighbor.h [ospfd] Additional NSM neighbour state change stats/information 2006-07-25 20:44:12 +00:00
ospf_network.c lib: simplify interface of setsockopt_multicast_ipv4(). 2011-09-27 21:37:35 +04:00
ospf_network.h Bug #362 is fixed now. 2007-08-21 16:32:56 +00:00
ospf_nsm.c ospfd: Compile fix for opaque support 2011-03-22 15:23:55 +00:00
ospf_nsm.h ospfd: Reset neighbour inactivity timer for any packet arrival 2010-12-08 17:11:18 +00:00
ospf_opaque.c ospfd: Compile fix for opaque support 2011-03-22 15:23:55 +00:00
ospf_opaque.h ospfd: Compile fix for opaque support 2011-03-22 15:23:55 +00:00
ospf_packet.c ospfd: reduce ospf_verify_header() 2012-03-12 11:05:45 +01:00
ospf_packet.h ospfd: introduce ospf_lsa_minlen[] (BZ#705) 2012-03-12 11:05:28 +01:00
ospf_route.c ospf_spf_process_stubs: use LSA pos to find OSFP interface 2012-07-25 18:07:37 +02:00
ospf_route.h ospf_spf_process_stubs: use LSA pos to find OSFP interface 2012-07-25 18:07:37 +02:00
ospf_routemap.c [compiler] miscellaneous trivial compiler warning fixes 2006-01-19 20:16:55 +00:00
ospf_snmp.c snmp: let handlers accept OID from a lesser prefix 2012-06-25 19:03:23 +02:00
ospf_snmp.h 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com> 2005-09-29 16:34:30 +00:00
ospf_spf.c ospfd: Do not fall back to intervening router. 2012-07-25 18:07:45 +02:00
ospf_spf.h [ospfd] Fix SPF of virtual-links 2006-05-04 07:32:57 +00:00
ospf_te.c ospf: Fix OSPF API and ospf-te LSA refreshers to match recent API change 2011-04-13 15:13:33 +01:00
ospf_te.h 2005-11-03 Paul Jakma <paul.jakma@sun.com> 2005-11-03 09:08:29 +00:00
ospf_vty.c lib: fix some strtoul() use cases 2012-01-02 19:13:28 +04:00
ospf_vty.h 2005-05-06 Paul Jakma <paul.jakma@sun.com> 2005-05-06 21:37:42 +00:00
ospf_zebra.c ospfd: use ZEBRA_NEXTHOP_IPV4_IFINDEX 2012-07-25 18:07:45 +02:00
ospf_zebra.h ospfd: justify ospf_default_originate_timer() 2012-01-08 11:46:11 +00:00
OSPF-ALIGNMENT.txt add note about alignment in LS updates due to opaque LSAs. 2004-11-17 17:59:52 +00:00
OSPF-MIB.txt spelling: s/supress/suppress/ 2004-11-05 13:24:12 +00:00
OSPF-TRAP-MIB.txt Initial revision 2002-12-13 20:15:29 +00:00
ospfd.c ospfd: remove unused code 2011-12-07 01:23:32 +04:00
ospfd.conf.sample Initial revision 2002-12-13 20:15:29 +00:00
ospfd.h ospfd: remove unused macro 2011-09-27 21:46:14 +04:00