ospfd: improve fix to CVE-2011-3326 (BZ#586)

Make ospf_flood() propagate error returned by ospf_lsa_install() further
to properly discard the malformed LSA, not just prevent the immediate
crash.
This commit is contained in:
Thomas Ries 2011-10-27 17:43:38 +04:00 committed by Denis Ovsienko
parent 1758dbaa3b
commit 4de148e5d6

View File

@ -320,7 +320,7 @@ ospf_flood (struct ospf *ospf, struct ospf_neighbor *nbr,
MinLSArrival seconds have elapsed. */
if (! (new = ospf_lsa_install (ospf, nbr->oi, new)))
return 0; /* unknown LSA type */
return -1; /* unknown LSA type or any other error condition */
/* Acknowledge the receipt of the LSA by sending a Link State
Acknowledgment packet back out the receiving interface. */