Igor Ryzhov
fe11f66b8c
lib: remove "ip prefix-list sequence-number" command
...
Before the transition of prefix-lists to northbound, this setting
controlled whether sequence numbers were displayed in the config.
After the transition, sequence numbers are always displayed in the
configuration, and this command only controls the output of the show
commands, which is not very useful. This command is not even shown in
the config anymore.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2021-03-24 00:37:54 +03:00
David Lamparter
53ab0eacab
Merge pull request #8115 from mjstapp/fix_ax_pthread
...
build: test program needs to be warning-free
2021-03-22 19:31:05 +01:00
Donald Sharp
7bf7917cde
Merge pull request #8303 from volta-networks/fix_coverity_pceplib
...
pceplib: Fixing coverity messages.
2021-03-22 10:22:25 -04:00
Donald Sharp
cb39b2d4aa
Merge pull request #8280 from kuldeepkash/bgp_convergence_test
...
tests: Fix bgp convergence issue mentioned in #8279
2021-03-22 10:15:36 -04:00
Mark Stapp
c00471326e
build: test program needs to be warning-free
...
One of the configure-time test programs produces a warning with
gcc 9 (at least), so it fails if -Werror is enabled. Fix that.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-03-22 08:41:14 -04:00
David Lamparter
992c42ef01
Merge pull request #8301 from donaldsharp/isis_spacing
...
isisd: Fix extra space after `router isis FOO`
2021-03-22 10:10:33 +01:00
David Lamparter
f0824c57dd
Merge pull request #8287 from mjstapp/more_gdb_in_configure
...
build: add -ggdb3 to dev build
2021-03-22 10:04:47 +01:00
David Lamparter
7183def9b1
Merge pull request #8298 from donaldsharp/isis_spelling
...
isisd: Fix spelling mistake
2021-03-22 10:03:38 +01:00
Donatas Abraitis
37916b2b11
Merge pull request #8121 from opensourcerouting/macro-cleanup
...
*: require ISO C11 + semicolons after file-scope macros
2021-03-22 11:00:34 +02:00
Donald Sharp
6b78d4c9f0
Merge pull request #8297 from adrianomarto/msdp-dscp-cs6
...
pimd: marking MSDP traffic as DSCP CS6
2021-03-21 19:43:01 -04:00
Donatas Abraitis
d3908d31d7
Merge pull request #8257 from donaldsharp/fix_bgp_metric
...
Fix bgp metric
2021-03-21 21:29:25 +02:00
Donald Sharp
31200a2963
isisd: Fix extra space after router isis FOO
...
Fix places where we are outputing an extra space. This was
because it was prepping for vrf but we may not have a vrf.
Fixes : #8300
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-21 13:12:41 -04:00
Donald Sharp
6dfe243c38
Merge pull request #8278 from ckishimo/ospfv3_iface
...
ospf6d: fix iface commands lost when removing from area
2021-03-20 20:11:16 -04:00
Donald Sharp
13c0040db5
Merge pull request #8282 from volta-networks/fix_isisd_bfd_ipv4
...
isisd: fix BFD session when IPv6 not configured
2021-03-20 20:04:38 -04:00
Donald Sharp
ec7b142568
isisd: Fix spelling mistake
...
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-20 19:53:06 -04:00
Donald Sharp
cd28e264a3
Merge pull request #8291 from volta-networks/isis_timer_unstable
...
isisd: avoid lsp_sched loop when unstable
2021-03-20 19:52:01 -04:00
Adriano Marto Reis
b069b5680d
pimd: marking MSDP traffic as DSCP CS6
...
Configuring the sockets used to establish MSDP connections so the
packets are marked as CS6
Signed-off-by: Adriano Marto Reis <adrianomarto@gmail.com>
2021-03-21 09:25:13 +10:00
Javier Garcia
7ed8c4b1fd
pceplib: Fixing coverity messages.
...
Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
2021-03-20 22:21:09 +01:00
Stephen Worley
97ec501ef0
Merge pull request #8129 from mjstapp/backup_recursives
...
zebra: modify backup nexthop handling for recursive routes
2021-03-19 12:30:51 -04:00
Mark Stapp
f0812f010e
build: add -ggdb3 to dev build
...
Add a little more gdb-specific debugging info for dev builds.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-03-19 08:20:54 -04:00
Emanuele Di Pascale
d2232b3e21
isisd: avoid lsp_sched loop when unstable
...
no point in scheduling an LSP refresh immediately if we know it is
going to be postponed again due to the network still being in its
instability grace period
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-03-19 10:37:58 +01:00
Mark Stapp
44544f191c
Merge pull request #8286 from donaldsharp/nhrp_xlref
...
nhrpd: Remove newline from log message
2021-03-18 14:30:33 -04:00
Donald Sharp
e43ba29689
Merge pull request #8263 from opensourcerouting/docker-update
...
tests: docker fixes & improvements
2021-03-18 13:59:30 -04:00
Donatas Abraitis
0966b412ba
Merge pull request #8283 from chiragshah6/mdev
...
bgpd: add seqno in bgp as-path access-list policy
2021-03-18 17:24:35 +02:00
Donald Sharp
dccd71c182
nhrpd: Remove newline from log message
...
We should not be putting new lines in log messages.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2021-03-18 10:32:01 -04:00
Emanuele Di Pascale
980390ce14
isisd: add debug logs to troubleshoot BFD issues
...
when we receive an event from BFDD and we end up throwing it away,
make sure that we log (with debug guards) the reason for this, so
we can troubleshoot issues like the one addressed by the previous
commit.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-03-18 12:49:10 +01:00
Emanuele Di Pascale
0d5b1a3a79
isisd: fix BFD session when IPv6 not configured
...
A wrong check was silently skipping the initialization of the bfd_session
struct in the adjacency if the router was not configured for IPv6. This
would cause BFD events to be ignored regardless of the configuration.
Also add a function to return the "name" of an adjacency and use it in a
couple of places, including the new log, instead of repeating the same
code in a bunch of places.
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2021-03-18 12:49:10 +01:00
Donald Sharp
bb5dddf713
Merge pull request #8284 from mjstapp/fix_bgp_zero_timers
...
bgpd: use add_event instead of add_timer with zero timeout
2021-03-18 07:29:32 -04:00
Chirag Shah
e6e62ee52d
doc: add seqno to bgp as path list section
...
Add sequence no option to bgp as-path list cli syntax.
Add sequence no to example config.
Add auto generated sequence no in running-config if its not
provided in config.
Signed-off-by: Chirag Shah <chirag@nvidia.com>
2021-03-17 22:06:53 -07:00
Chirag Shah
9b6f73ee9c
bgpd: add seqno in bgp as-path access-list policy
...
Add optional parameter seqno to bgp as-patch policy
to inline with other bgp policies commands at same
level.
Testing Done:
config t
bgp as-path access-list foo1 permit _40_
bgp as-path access-list foo1 seq 5 permit _41_
bgp as-path access-list foo1 seq 8 permit _42_
bgp as-path access-list foo2 permit _43_
no bgp as-path access-list foo1 permit _41_
bgp as-path access-list foo1 permit 41$
show run:
bgp as-path access-list foo1 seq 8 permit _42_
bgp as-path access-list foo1 seq 10 permit 41$
bgp as-path access-list foo2 seq 5 permit _43_
Signed-off-by: Chirag Shah <chirag@nvidia.com>
2021-03-17 22:06:53 -07:00
Kuldeep Kashyap
53402dbf1e
tests: Fix bgp convergence issue mentioned in #8279
...
1. Enhance verify_bgp_convergence() to solve issue mentioned in #8279
Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2021-03-17 17:43:57 -07:00
Mark Stapp
e0d550dfea
bgpd: use add_event instead of add_timer with zero timeout
...
Just use events in a few places where timers with zero timeout
were being used.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2021-03-17 16:10:13 -04:00
Quentin Young
263e82b308
Merge pull request #8052 from ton31337/feature/show_bgp_peer-groups_json
2021-03-17 15:08:00 -04:00
Donald Sharp
a78a4e754e
Merge pull request #8232 from reubendowle/fixes/nhrp-ipsec-issues
...
nhrp: Fix some ipsec related issues
2021-03-17 09:33:44 -04:00
Donald Sharp
28bada3d8f
Merge pull request #8255 from pjdruddy/fix-ifindex-test
...
Fix ifindex test
2021-03-17 09:10:20 -04:00
Donald Sharp
5b21cd300c
Merge pull request #8248 from volta-networks/fix_ospf6_chunk_msgs
...
ospfd6: Clear locks when ospf messages need to be chunked
2021-03-17 09:09:28 -04:00
David Lamparter
53abc26569
tests: simplify docker rsync & support worktrees
...
The previous, more complex mechanism failed to take into account that
git worktrees only have a stub .git file & copying the worktree itself
is not enough. Just extract a file list beforehand & don't bother with
git inside the container.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 13:42:20 +01:00
David Lamparter
071f5c1664
tests: add libelf-dev to Dockerfile
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 13:42:20 +01:00
Donald Sharp
4f156615e1
Merge pull request #8276 from opensourcerouting/pathd-fmt-fix
...
pathd: fix some format strings
2021-03-17 08:31:01 -04:00
Santosh P K
de40463b54
Merge pull request #8008 from chiragshah6/yang_nb5
...
[lib, yang] : multiple fixes in prefix-list northbound conversion
2021-03-17 16:25:54 +05:30
Rafael Zalamena
692b3561df
Merge pull request #8225 from idryzhov/bfd-echo-mode
...
bfdd: fix echo receive timer and disable echo mode
2021-03-17 10:45:43 +00:00
Rafael Zalamena
57e627628d
Merge pull request #8229 from idryzhov/bfdd-echo-rx-tx
...
bfdd: separate echo rx/tx timers
2021-03-17 10:41:33 +00:00
ckishimo
d205f01e1d
tests: fix too many arguments for logging
...
Signed-off-by: ckishimo <carles.kishimoto@gmail.com>
2021-03-17 09:35:47 +01:00
David Lamparter
8c64c9571e
Merge pull request #8273 from volta-networks/fix_ospf6_coverity
...
ospf6d: Fix coverity errors
2021-03-17 08:02:14 +01:00
David Lamparter
f38d31f933
Merge pull request #8275 from donaldsharp/peer_afi_safi_mistake
2021-03-17 07:13:09 +01:00
David Lamparter
d85bf6f1eb
pathd: remove mid-string line breaks
...
cf. workflow.rst ("lines over 80 characters are allowed for text strings
to make it possible to search the code for them"), matching Linux kernel
coding style.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:39:34 +01:00
David Lamparter
84b3eb42a9
pathd: use %pIA to print struct ipaddr *
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:31:38 +01:00
David Lamparter
4d39e49673
pathd: fix %pI4 <> %pI6 snafu
...
... as noted by the frr-format GCC plugin.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:30:53 +01:00
David Lamparter
941b5172ea
lib: temporary workaround for LabN CI
...
Accept macros without ; for LabN CI *only*. This is a bit hairy since
we can't generate warnings for this, so it's very limited in both scope
and duration.
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:24:03 +01:00
David Lamparter
7abb042e78
build: put macro-semicolon bits into ignore-revs
...
Signed-off-by: David Lamparter <equinox@diac24.net>
2021-03-17 06:24:03 +01:00