Commit Graph

6810 Commits

Author SHA1 Message Date
Donald Sharp
fc25a6680d Merge pull request #427 from opensourcerouting/zebra-ifdel-fix
lib: fix segfault on exit caused by interface removal
2017-04-28 15:56:10 -04:00
Renato Westphal
ef04b19249 lib: fix segfault on exit caused by interface removal
Add missing bits to properly unlink interface in the if_unlink_per_ns()
function.

In the long term we should convert if_table to use a more convenient
data structure like a red-black tree instead of a routing table.

Fixes issue #398.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-28 15:38:00 -03:00
Donald Sharp
40d3ecc35c Merge pull request #417 from donaldsharp/stable_2_0_fixes_into_stable_3_0
Stable 2.0 fixes into stable 3.0
2017-04-28 11:42:21 -04:00
Jafar Al-Gharaibeh
0b4cbacad9 Merge pull request #381 from donaldsharp/pimmerino
Pimmerino
2017-04-28 10:13:39 -05:00
Donald Sharp
ceac05ce8e Merge pull request #425 from opensourcerouting/bgpd-clear-fix
bgpd: fix "clear bgp" commands
2017-04-28 10:47:05 -04:00
Donald Sharp
de290a3f57 Merge pull request #424 from opensourcerouting/snap-fix-distfile
More snapcraft cleanups
2017-04-28 10:02:03 -04:00
Renato Westphal
f0dac89fde bgpd: fix "clear bgp" commands
The use of VTY_DECLVAR_CONTEXT(bgp, bgp) here is wrong as we are not
inside the "router bgp" configuration node. This was making the clear
commands always fail with a "Current configuration object was deleted
by another process" error, which doesn't make any sense.

Also, the bgp_clear() function will already check for us if the given
peer-group or neighbor exists or not, there's no need to duplicate this
logic here.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-28 10:47:51 -03:00
Martin Winter
b9f34c6215 snapcraft: Clean up old no longer used configure flags
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-28 03:11:51 -07:00
Martin Winter
8ccfe8f875 snapcraft: Add support for extra version information
- frr.version snap command will now show the contents of
  extra_version_info.txt in addition to the zebra --version output

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-28 01:48:51 -07:00
Martin Winter
0d4a6bd23c snapcraft: Fix missing files in "make dist" target
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-27 23:26:20 -07:00
Hung-Wei Chiu
8395883b3e Update Building_FRR_on_Ubuntu1604.md
Fix typo
2017-04-27 09:34:16 -04:00
Hung-Wei Chiu
c398245864 Update Building_FRR_on_Ubuntu1604.md
1.  Modify the configure prefix (since there some hard coded path in **/usr/lib/frr/fr**
2.  Install the systemd service config
2017-04-27 09:34:03 -04:00
Renato Westphal
59341c1b5e Merge pull request #413 from dwalton76/address-family-argv-argc-stable-30
Problem with DEFUNSH in vtysh, issue #358
2017-04-27 09:21:20 -03:00
Daniel Walton
39530dfe75 Problem with DEFUNSH in vtysh, issue #358
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
2017-04-26 22:39:10 +00:00
Jafar Al-Gharaibeh
c276c5657c Merge pull request #399 from donaldsharp/is_configured
ospfd: Remove unused function
2017-04-25 10:13:40 -05:00
Russ White
e546c80068 Merge pull request #403 from donaldsharp/nhrpd2
Nhrpd2
2017-04-25 10:24:23 -04:00
Donald Sharp
c1c17a0ff7 nhrpd: Fix cli changes missed
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-25 09:07:05 -04:00
Timo Teräs
d139786ae8 nhrp: parse and log command response errors from strongSwan
helps to debug configuration problems
2017-04-25 08:33:53 -04:00
Timo Teräs
8ec0c3c125 nhrp: fix potential crash when vici profile name is not configured 2017-04-25 08:33:43 -04:00
Timo Teräs
111aec1e42 nhrp: notify 'tunnel protection' changes
to triggers refresh of IKE SAs immediately on this command
2017-04-25 08:33:33 -04:00
Timo Teräs
3d3813b229 nhrp: explicitly cast ints to size_t for vici_request_vc va_list handling 2017-04-25 08:33:22 -04:00
Timo Teräs
8c01a3bd14 nhrp: fix protocol address family parsing on receive
See bugzilla #948
2017-04-25 08:33:11 -04:00
Timo Teräs
2d4eab2269 nhrp: implement 'no ip nhrp map' command
was accidentally not implemented earlier
2017-04-25 08:33:01 -04:00
Timo Teräs
0ca036b456 nhrpd: implement 'show ip nhrp nhs' 2017-04-25 08:32:46 -04:00
Martin Winter
3d7746c340 Merge pull request #400 from dwalton76/default-frr-conf
vtysh: "Command incomplete: log syslog"
2017-04-24 20:11:11 -07:00
Donald Sharp
c24c910866 ospfd: Remove unused function
ospf_if_is_configured is never used, remove.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-24 19:29:30 -04:00
Daniel Walton
27821f6a5a vtysh: "Command incomplete: log syslog"
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Before
======
root@spine-1[~]# cat /etc/frr/frr.conf
no log monitor
!
service integrated-vtysh-config
!
log syslog
!
log syslog informational
!
line vty
!
root@spine-1[~]#
root@spine-1[~]# vtysh -m -f /etc/frr/frr.conf
no log monitor
!
service integrated-vtysh-config
!
line 5: % Command incomplete: log syslog

root@spine-1[~]#

After
=====
root@spine-1[~]# vtysh -m -f /etc/frr/frr.conf
no log monitor
!
service integrated-vtysh-config
!
log syslog
!
log syslog informational
!
line vty
!
end
root@spine-1[~]#
2017-04-24 18:22:29 +00:00
Donald Sharp
9a09fb8e95 Merge pull request #391 from opensourcerouting/fix-no-router-ospf6
ospf6d: fix "no router ospf6"
2017-04-22 17:55:26 -04:00
Renato Westphal
34288970c4 ospf6d: fix "no router ospf6"
The "no router ospf6" command wasn't working.

Regression introduced by commit 16cedbb.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-04-22 17:51:14 -03:00
Donald Sharp
e9e27161c3 Merge pull request #388 from opensourcerouting/snap-fixes-3.0
Snap fixes 3.0
2017-04-21 20:13:31 -04:00
Martin Winter
97b0200793 doc: Add nhrpd to relevant section in Building_FRR_on_xxxx doc
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-21 17:43:17 -04:00
Phil Huang
aa1322f9f6 Clean installation guide with Debian/Ubuntu
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-04-21 17:43:17 -04:00
Phil Huang
02f3b0512a Add user frr into group frrvty
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-04-21 17:43:17 -04:00
Martin Winter
d851b2fc0d snapcraft: Add FPM module with command to set mode or disable it
- New snap command:
    frr.set fpm {disable | protobuf | netlink}

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-21 02:49:39 -07:00
Martin Winter
80b4df3b08 lib: Add CLI option --moduledir to override default module location (needed for snap support)
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-21 02:37:11 -07:00
Martin Winter
ae49894874 snapcraft: Add nhrpd to snap
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-20 18:18:40 -07:00
Martin Winter
5ae4018e5d snapcraft: Fix another old leftover of ubuntu-core in build doc
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-20 17:24:12 -07:00
Martin Winter
6f2a494a83 snapcraft: Update snapcraft requirements for FRR 3.0 (from 2.0)
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-20 16:58:24 -07:00
Donald Sharp
38d9651ab7 Merge pull request #382 from opensourcerouting/snap-doc-fixes-3.0
snapcraft: Improve README.usage.md based on feedback received
2017-04-20 18:55:21 -04:00
Martin Winter
f4c14c3a80 snapcraft: Improve README.usage.md based on feedback received
- Fix snap connect (it's now called core, not ubuntu-core)
- Add section on MPLS configuration
- Add FAQ topic on ospfd/ospf6d crashing before privs are assigned to snap
- Add pointer to official webpage

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-04-20 15:44:44 -07:00
Donald Sharp
e3a55f03bf pimd: Tweak pim_ifchannel_compare to be faster
Tweak the ifchannel compare to sort based upon
interface first

Ticket: CM-15629
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-20 16:00:21 -04:00
Donald Sharp
b5e6281b65 pimd: Convert pim_ifchannel_list to use up->ifchannels
We have a bunch of places where we iterate over
the pim_ifchannel_list to find those ifchannels
that match a certain upstream.  Since we already
know in the upstream the list of ifchannels
associated with it, just look at those instead.

Functions changed:

forward_on
forward_off
pim_upstream_rpf_interface_changed
pim_upstream_update_could_assert
pim_upstream_update_my_assert_metric
pim_upstream_update_assert_tracking_desired
pim_upstream_is_sg_rpt

Ticket: CM-15629
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-20 15:59:57 -04:00
Donald Sharp
2a28f7a0b9 pimd: Add ability for upstream to know it's ifchannels
Add a list structure to track the ifchannels associated
with a particular upstream.

We are not doing anything with this particular knowledge
yet but it will be come useful in the near future.

Ticket: CM-15629
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-20 15:59:12 -04:00
Donald Sharp
c8fc07cb03 pimd: Limit search to relevant ifchannels in some cases
When we are determining an inherited_olist, let's be allot
smarter about what we look at.  Before this code change
we are looping over the entirety of all ifchannels in
the system to find the relevant ones.  Convert the
code to *find*(hash table lookup) the specific ifchannels we
are interested in.

Ticket: CM-15629
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-20 15:59:01 -04:00
Donald Sharp
cf528e4f26 pimd: When loosing *,G igmp report notify S,G too
When we have a S,G that was created due to the *,G IGMP
report going away, safely remove the S,G as well.

Ticket: CM-15838
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
2017-04-20 15:57:00 -04:00
Donald Sharp
df94f9a91d pimd: Add prefix list handling to spt-switchover
To the 'ip pim spt-switchover infinity-and-beyond' command
add 'prefix-list <PLIST>'. To the command.

Use this as the basis to deny (Not immediate switchover)
or permit (Immediate switchover), based upon matching
the group address and the prefix-list.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-20 15:55:50 -04:00
Russ White
54cd060799 Merge pull request #379 from pguibert6WIND/frrouting_issue309_2
vtysh: remove deprecated HAVE_EVPN flag
2017-04-19 06:58:48 -04:00
Philippe Guibert
d2c1e06d83 vtysh: remove deprecated HAVE_EVPN flag
This flag prevents from entering into evpn address-family node, when
calling command from vtysh.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2017-04-19 09:40:08 +02:00
Martin Winter
3060be2af5 Merge pull request #371 from donaldsharp/as_path_fix_3.0
bgpd: Fix 'set as-path prepend last-as 10'
2017-04-17 14:47:08 -07:00
Donald Sharp
5260e25d20 bgpd: 'show .... bgp regexp WORD' fixed
The command was always just returning as part of the
bgp_regexp_show function.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-04-14 20:39:56 -04:00