proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-02 21:45:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
14,657 Commits 4 Branches 191 Tags 125 MiB
fb85ce1b81
Commit Graph

14657 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Lamparter
fb85ce1b81
Merge pull request #3770 from donaldsharp/detailed_debugs 
zebra: Update zserv debug messages to give a bit more useful info
 2019-02-11 08:21:12 +01:00
David Lamparter
233c5edffe
Merge pull request #3767 from donaldsharp/martians_ate_my_homework 
bgpd: Remove unused bgp_debug_count function
 2019-02-11 08:20:26 +01:00
David Lamparter
0240fee6f4
Merge pull request #3715 from qlyoung/fix-systemd-deps 
tools: fix systemd dependency graph
 2019-02-11 07:50:16 +01:00
Donald Sharp
494247b58c zebra: Update zserv debug messages to give a bit more useful info 
When we schedule a packet for future handling, list the packet
type so that we can see what we are getting with debugs.

Also note which client and how many packets we received from that
client.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-10 11:48:14 -05:00
Donald Sharp
e52c192504 bgpd: Remove unused bgp_debug_count function 
This function was not used anywhere, remove it from the system.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-09 18:22:01 -05:00
Donald Sharp
97c6009d49
Merge pull request #3760 from patrasar/RP_configure_inconsistent_addr_mask 
pimd: reject inconsistent address/mask "ip pim rp command"
 2019-02-08 07:37:43 -05:00
Donald Sharp
e6ee7eb9e3
Merge pull request #3761 from patrasar/fix_refresh_oil_timer 
pimd: Don't refersh the oif_creation timer if S,G already present
 2019-02-08 07:31:12 -05:00
Sarita Patra
6b44b40141 pimd: reject inconsistent address/mask "ip pim rp command" 
Issue: Configure "ip pim rp x.x.x.x 225.0.0.0/4".
Show running config shows "ip pim rp x.x.x.x 224.0.0.0/4"
This is mis-leading.

Root-cause: Internally 225.0.0.0/4 is getting converted to
224.0.0.0/4 group mask, since the prefix length is 4.

Fix: Restrict the user to configure inconsistent group address
mask by throughing a cli error "Inconsistent address and mask".

Signed-off-by: Sarita Patra <saritap@vmware.com>
 2019-02-08 01:35:21 -08:00
Sarita Patra
d23756e938 pimd: Don't refersh the oif_creation timer if S,G already present 
Issue: Shut the RP interface in the router RP. LHR will get to know
RP becomes not-reachable, so it send a prune towards the RP. On
receiving the prune, RP clear the (*, G) entry, but (S, G) should
not get removed if present.
Now no-shut the RP interface in the router RP. LHR will send a (*, G)
join towards the RP. On receiving join FRR create the (*, G) entry.
Along with this, it also add the interface(join received) in the OIL
of (S, G) and also refresh the (S, G) timer.

Fix: Dont refresh the timer for S, G or (*, G), if the flag for the
channel OIL is PIM_OIF_FLAG_PROTO_ANY.

Signed-off-by: Sarita Patra <saritap@vmware.com>
 2019-02-07 23:50:12 -08:00
Donald Sharp
aef69c4fea
Merge pull request #3752 from mjstapp/fix_wq_static_func 
libs: remove useless static work_queue_free helper
 2019-02-07 17:24:06 -05:00
Russ White
1632290b3f
Merge pull request #3745 from chiragshah6/evpn_dev1 
EVPN advertise svi ip as macip route changes via config command
 2019-02-07 14:36:46 -05:00
Mark Stapp
6b097e3379 libs: remove useless static work_queue_free helper 
Collapse the old static free function into the actual public
function that was using it (and the only user of it.)

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-02-07 13:54:50 -05:00
David Lamparter
b7777b57c4
Merge pull request #3722 from donaldsharp/static_recursive 
Zebra fixes
 2019-02-07 19:22:29 +01:00
David Lamparter
e7f0060c12
Merge pull request #3744 from mjstapp/wq_deprecated_api 
libs: remove deprecated workqueue api
 2019-02-07 18:52:27 +01:00
David Lamparter
b736a7be6f
Merge pull request #3748 from donaldsharp/sharp_nht_addition 
Sharp cleanups and new cli
 2019-02-07 18:48:48 +01:00
David Lamparter
9dd8587ded
Merge pull request #3749 from rtrlib/2019-02-07-bugfix-master 
RPKI bug fixes
 2019-02-07 18:44:04 +01:00
Marcel Röthke
222487feb5 bgpd: fix crash when trying to remove non-existing rpki cache 
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
 2019-02-07 17:26:11 +01:00
Marcel Röthke
745ae9c088 bgpd: fix "show rpki cache-server" for ssh caches 
Fix #3662

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
 2019-02-07 17:26:11 +01:00
Donald Sharp
86da53ab0e sharpd: Add 'sharp data nexthop' data dump 
Add some basic data dumping about what we have watched
from the vty/vtysh cli for nexthops.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-07 10:14:17 -05:00
Donald Sharp
f59e641827 sharpd: Add 'sharp data route" dump command 
When you are using the install/remove routes command, the
output goes to a log file.  This command allows for ease
of dump of timing information from the vty or vtysh.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-07 10:14:17 -05:00
Donald Sharp
547dc6429c sharpd: Move route global variables into the global data structure 
Clean up the route global variables into a global data structure.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-07 10:14:17 -05:00
Donald Sharp
d21f1a930f sharpd: Add start of global data structures 
We have a bit of a mess with globals in the sharp daemon.
Let's start formalizing it a bit.  Future commits will
take advantage of this, as that we need to have the ability
to start dumping stats about commands we have issued.

These changes will be useful for debugging and understanding
what is going on.

Signed-off-by: Donald sharp <sharpd@cumulusnetworks.com>
 2019-02-07 09:35:49 -05:00
Donald Sharp
a60ffbc985 sharpd: Allow nhop tracking to specify connected 
Allow the sharp daemon to specify whether or not a watched
nexthop should be connected or not.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-07 09:35:49 -05:00
Donald Sharp
ecc4d697cd lib: MTYPE_PREFIX_FLOWSPEC should not be exposed by memory.h 
This MTYPE should be owned by prefix.c as a STATIC for the file.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-07 09:35:49 -05:00
Chirag Shah
278e26de8e zebra: advertise svi ip as macip route changes 
In Asymmetric and symetric routing scenario in EVPN
where each VTEP pair having different set of addresses
for the SVIs.
This knob allows reachability (ping connectivity) of
SVI IPs and resolve ARP resoultion VTEPs across racks.

This knob should not be used when same SVI IPs configured
on VTEPs across racks or when advertise default gateway
is configured.

Ticket:CM-23782
Testing Done:
Bring up EVPN symmetric routing topology with different
SVI IPs on different VTEPs. Enable advertise svi ip
at each VTEP, remote VTEPs installs arp entry for
SVI IPs via EVPN type-2 route exchange.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2019-02-06 19:57:53 -08:00
Chirag Shah
24864e4497 bgpd: advertise svi ip as macip config cmd 
Ticket:CM-23782

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2019-02-06 19:57:47 -08:00
Chirag Shah
a80161574c bgpd: advertise svi ip as macip zebra parse api 
Ticket:CM-23782

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2019-02-06 19:57:40 -08:00
Chirag Shah
fc08a52fee lib: advertise svi ip as macip opcode 
This change is used to send configue changes for
advertise svi address as macip (type-2) route.

Ticket:CM-23782

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
 2019-02-06 19:57:00 -08:00
Quentin Young
efbf903d61 tools: fix systemd dependency graph 
Currently our systemd dependencies look something like this (example
from vanilla Debian 9):

$ systemctl list-dependencies frr
frr.service
● ├─system.slice
● └─sysinit.target
  ...

$ systemctl list-dependencies --reverse frr
frr.service
● └─network-online.target
●   └─apt-daily.service

Note that sysinit.target does not depend on any network* service or
target.

In other words, unless there is a service that requires
network-online.service, even if FRR is enabled it will not be started.
Therefore network-online.target is the wrong unit to have in WantedBy=,
as it is not always started.

This patch updates our service file so that it is properly started by
the system when enabled, delayed until networking is up, and if possible
delayed until after NetworkManager, systemd-networkd or any other
networking configuration manager has finished performing its tasks -
i.e. after network-online.target.

After these changes our new dependency graph looks like this:

$ systemctl list-dependencies frr
frr.service
● ├─system.slice
● │ └─networking.service
● ├─network.target
● └─sysinit.target
  ...

$ systemctl list-dependencies --reverse frr
frr.service
● └─multi-user.target
●   └─graphical.target

This way, FRR will be started by multi-user.target (just like most
applications), but delayed until after networking has been configured.

In the same stroke, this should also fix issues on systems that do not
provide "networking.service" (such as CentOS 7).

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@diac24.net>
 2019-02-06 19:47:43 +00:00
Mark Stapp
49f36252d6 libs: remove deprecated workqueue api 
Remove deprecated api from workqueue module.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
 2019-02-06 14:13:21 -05:00
Donald Sharp
4634d02cfd
Merge pull request #3684 from mjstapp/dplane_pw 
zebra: async dataplane for pseudowires
 2019-02-05 18:41:12 -05:00
Rafael Zalamena
c0a0dbb01b
Merge pull request #3737 from qlyoung/doc-move-topotest-to-devdocs 
doc: move topotests docs to developers guide
 2019-02-05 20:32:14 -02:00
Donald Sharp
e625a783ed zebra: Do not display recursive nexthops as installed 
Recursive nexthops should not be marked as installed

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-05 15:21:26 -05:00
Donald Sharp
6c47d39902 zebra: Fix multiple levels of static recursion 
Allow the nexthop-check code to figure out recursive static routes
in a logical manner.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-05 15:21:26 -05:00
Emanuele Di Pascale
77d9c92609 lib: add hooks for external logging function 
Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
 2019-02-05 20:55:04 +01:00
Quentin Young
370c8e079f doc: move topotests docs to developers guide 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2019-02-05 19:25:16 +00:00
Russ White
c9b046adda
Merge pull request #3693 from chiragshah6/ospf_vrf_dev 
ospfd: address CVE-2017-3224
 2019-02-05 11:25:30 -05:00
Donald Sharp
9f3a86d3e6
Merge pull request #3518 from rgirada/routemap_3090 
libd: Implemented a cli "show route-map-unused" to track all unused rou…
 2019-02-05 11:13:22 -05:00
Russ White
5dd91bc84f
Merge pull request #3733 from donaldsharp/meta_queue_nht_game_over_man_game_over 
zebra: NHT was being run at least 2 times and missreporting data
 2019-02-05 11:06:42 -05:00
Russ White
f2445bf70d
Merge pull request #3727 from qlyoung/fix-signed-printspec-bgp-as 
bgpd: use correct specifier to print asn
 2019-02-05 11:05:53 -05:00
Russ White
67395d4222
Merge pull request #3725 from donaldsharp/eigrp_metric 
Eigrp metric
 2019-02-05 10:55:02 -05:00
Russ White
b8f248ab6f
Merge pull request #3730 from donaldsharp/send_information 
Send information
 2019-02-05 10:53:50 -05:00
Russ White
37a5432422
Merge pull request #3688 from chiragshah6/evpn_dev 
zebra: EVPN probe local inactive neigh/arp entry upon mac mobility
 2019-02-05 10:48:33 -05:00
Russ White
0848547352
Merge pull request #3679 from chiragshah6/evpn_dev2 
zebra: reinstate bgp evpn remote route on local evpn route delete
 2019-02-05 10:47:35 -05:00
Renato Westphal
d8fd1e099a
Merge pull request #3732 from qlyoung/fix-missing-backtic-doc 
doc: fix missing backtick
 2019-02-05 13:10:59 -02:00
Donald Sharp
46a4e3455b zebra: NHT was being run at least 2 times and missreporting data 
With the data plane changes that were made, we are now running
nexthop tracking 2 times.  Once at the end of meta-queue insertion
and once at the end of receiving a bunch of data from the dataplane.

The Addition of the data plane code caused flags to not be set
fully for the resolved routes( since we do not know the answer yet ),
This in turn caused the nexthop tracking run after the meta-queue
to think that the route was not `good`.  This would cause it to
tell all interested parties that there was no nexthop.

After the dataplane insertion we are also no running nht code.
This was re-figuring out the nexthop correctly and also
correctly reporting to interested parties that there was a path again.

Example:
donna.cumulusnetworks.com(config)# do show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, f - failed route

K>* 0.0.0.0/0 [0/103] via 10.50.11.1, enp0s3, 00:06:47
S>* 4.5.6.7/32 [1/0] via 192.168.209.1, enp0s8, 00:04:47
C>* 10.50.11.0/24 is directly connected, enp0s3, 00:06:47
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:06:47
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:06:47
donna.cumulusnetworks.com(config)# ip route 4.5.6.7/32 192.168.210.1
donna.cumulusnetworks.com(config)# do show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, f - failed route

K>* 0.0.0.0/0 [0/103] via 10.50.11.1, enp0s3, 00:07:06
S>* 4.5.6.7/32 [1/0] via 192.168.209.1, enp0s8, 00:00:04
  *                  via 192.168.210.1, enp0s9, 00:00:04
C>* 10.50.11.0/24 is directly connected, enp0s3, 00:07:06
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:07:06
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:07:06
donna.cumulusnetworks.com(config)#

Log files for sharp, which is watching 4.5.6.7:
2019/02/04 15:20:54.844288 SHARP: Received update for 4.5.6.7/32
2019/02/04 15:20:54.844820 SHARP: Received update for 4.5.6.7/32
2019/02/04 15:20:54.844836 SHARP: 	Nexthop 192.168.209.1, type: 2, ifindex: 3, vrf: 0, label_num: 0
2019/02/04 15:20:54.844853 SHARP: 	Nexthop 192.168.210.1, type: 2, ifindex: 4, vrf: 0, label_num: 0

As you can see we have received an update with no nexthops( invalid route )
and a second update immediately after it with 2 nexthops.

What's the big deal you say?  Well we have code in other daemons that reacts
to not having a path for a nexthop.  In BGP this will cause us to tear
down the peer.  In staticd we'll remove the recursively resolved route.
In pim we'll remove all paths to the mroute.  This is not desirable.

The fix is to remove the meta-queue run of nexthop tracking.

While running after data plane notice of routes to handle is not ideal
we will be fixing this in the future with the nexthop group code, which
should know what nexthops are affected by a nexthop group change.

Fixed code debug code:
donna.cumulusnetworks.com(config)# do show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, f - failed route

K>* 0.0.0.0/0 [0/103] via 10.50.11.1, enp0s3, 00:00:46
S>* 4.5.6.7/32 [1/0] via 192.168.209.1, enp0s8, 00:00:02
C>* 10.50.11.0/24 is directly connected, enp0s3, 00:00:46
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:00:46
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:00:46
donna.cumulusnetworks.com(config)# ip route 4.5.6.7/32 192.168.210.1
donna.cumulusnetworks.com(config)# do show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, f - failed route

K>* 0.0.0.0/0 [0/103] via 10.50.11.1, enp0s3, 00:00:59
S>* 4.5.6.7/32 [1/0] via 192.168.209.1, enp0s8, 00:00:02
  *                  via 192.168.210.1, enp0s9, 00:00:02
C>* 10.50.11.0/24 is directly connected, enp0s3, 00:00:59
C>* 192.168.209.0/24 is directly connected, enp0s8, 00:00:59
C>* 192.168.210.0/24 is directly connected, enp0s9, 00:00:59

2019/02/04 15:26:20.656395 SHARP: Received update for 4.5.6.7/32
2019/02/04 15:26:20.656440 SHARP: 	Nexthop 192.168.209.1, type: 2, ifindex: 3, vrf: 0, label_num: 0
2019/02/04 15:26:33.688251 SHARP: Received update for 4.5.6.7/32
2019/02/04 15:26:33.688322 SHARP: 	Nexthop 192.168.209.1, type: 2, ifindex: 3, vrf: 0, label_num: 0
2019/02/04 15:26:33.688329 SHARP: 	Nexthop 192.168.210.1, type: 2, ifindex: 4, vrf: 0, label_num: 0

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-05 09:17:02 -05:00
Donald Sharp
ee56831894 pimd: Pim is not respecting the move of an interface from old->new vrf 
PIM needed to be updated to move to the new vrf.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-05 09:13:30 -05:00
Donald Sharp
22761baa25 lib: Send interface request after initial hello 
Ask for all interface information after we have connected
to zebra and sent the initial hello.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-05 09:13:30 -05:00
Donald Sharp
a8a20c4e3c zebra: Remove zclient->idinfo restrictions 
The restricting of data about interfaces was both inconsistent
in application and allowed protocol developers to get into states where
they did not have the expected data about an interface that they
thought that they would.  These restrictions and inconsistencies
keep causing bugs that have to be sorted through.

The latest iteration of this bug was that commit:
f20b478ef3

Has caused pim to not receive interface up notifications( but
it knows the interface is back in the vrf and it knows the
relevant ip addresses on the interface as they were changed
as part of an ifdown/ifup cycle ).

Remove this restriction and allow the interface events to
be propagated to all clients.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2019-02-05 09:13:30 -05:00
Renato Westphal
3524352154
Merge pull request #3698 from donaldsharp/netlink_is_serious_business 
Netlink is serious business
 2019-02-05 11:52:33 -02:00