Commit Graph

19209 Commits

Author SHA1 Message Date
Mark Stapp
f9dfa64797
Merge pull request #6209 from donaldsharp/true_false
bgpd: bools use `true/false` not `TRUE/FALSE`
2020-04-13 12:17:19 -04:00
Donald Sharp
cded3b7232 bgpd: bools use true/false not TRUE/FALSE
Who knows where these values were coming from.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-13 08:08:48 -04:00
Donald Sharp
a55fc28786
Merge pull request #6199 from opensourcerouting/bfdd-improvements
bfdd: misc code improvements and fixes
2020-04-12 20:28:35 -04:00
Donald Sharp
6b7ec8b3f7
Merge pull request #6204 from opensourcerouting/fix-eigrp-neighbor
yang: use the correct type for EIGRP neighbors
2020-04-12 20:25:26 -04:00
Renato Westphal
e2a56663c0 yang: use the correct type for EIGRP neighbors
Fixes #6193.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-04-12 00:12:54 -03:00
Renato Westphal
66c79a36ea
Merge pull request #6181 from volta-networks/fix_isisd_no_metric_style
isisd: fix two 'no X' commands
2020-04-11 23:29:28 -03:00
Donald Sharp
eb728e0746
Merge pull request #6027 from sarav511/vrfloop
pimd: crash while finding primary address.
2020-04-10 14:02:28 -04:00
Quentin Young
293d5cb3c0
Merge pull request #6176 from NaveenThanikachalam/memleaks
bgpd: Fixes for memory leaks.
2020-04-10 13:55:52 -04:00
Rafael Zalamena
259b64ebb5 bfdd: use standard log macros
Remove old log_* macros and standardize on FRR's logging infrastructure.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-04-10 11:06:22 -03:00
Russ White
4aa0f5cb16
Merge pull request #6189 from vivek-cumulus/unequal_cost_multipath_fixes
Unequal cost multipath fixes
2020-04-10 09:03:50 -04:00
Rafael Zalamena
4caf638833 bfdd: fix transmission timer calculation
According to the RFC 5880 the transmission time should be mandated by
the slowest system.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-04-09 17:46:02 -03:00
Rafael Zalamena
bfea10110c bfdd: initialize packet data with zeroes
Lets avoid garbage data on packets by zeroing the packet before setting
the fields/flags.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-04-09 17:44:56 -03:00
Rafael Zalamena
b88113ef73 bfdd: remove BFD_*_FLAG macros
Lets use what FRR provide us instead of implementing a new macros.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2020-04-09 16:54:11 -03:00
Donatas Abraitis
43086e6a56
Merge pull request #6124 from kuldeepkash/bgp_basic_functionality
tests: Adding new test suite bgp_as_allow_in
2020-04-09 15:59:49 +03:00
Kuldeep Kashyap
afee014eda tests: Added new tests to bgp-basic-functionality-topo1
1. Added 2 new test cases to bgp-basic-functionality-topo1
2. Enhanced 2 tests to run for both static routes and network advvertise command

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-04-09 09:23:59 +00:00
Kuldeep Kashyap
089f79edd4 tests: Adding new test suite bgp_as_allow_in
1. Added 5 test cases to verify BGP AS-allow-in behavior in FRR
2. Enhanced framework to support BGP AS-allow-in config(lib/bgp.py)
3. Added API in bgp.py to verify BGP RIB table(lib/bgp.py)

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-04-09 09:10:21 +00:00
Donatas Abraitis
fdf44b9038
Merge pull request #6125 from kuldeepkash/bgp-communities
tests: Adding new test suite bgp_communities_topo1
2020-04-09 11:49:43 +03:00
Naveen Thanikachalam
74a630b606 bgpd: Fixes for memory leaks.
This commit addresses the memory leaks when certain BGP JSON
show commands are executed

Signed-off-by: NaveenThanikachalam <nthanikachal@vmware.com>
2020-04-08 20:27:49 -07:00
vivek
3b0c17e1d4 bgpd: Trigger EVPN type-5 injection upon link-bandwidth change
Ensure that upon a link-bandwidth change - for e.g., due to change in
the number of multipaths - EVPN type-5 route injection is triggered.
In the absence of this, the proper link-bandwidth is not updated in
EVPN type-5 routes originated by the router.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
2020-04-08 19:12:09 -07:00
vivek
87b42e3b22 bgpd: Fix overflow in bandwidth calc
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
2020-04-08 19:12:00 -07:00
David Lamparter
2ee1e4b1ba
Merge pull request #6175 from ton31337/fix/avoid_same_type_typecasting
*: Do not cast to the same type
2020-04-08 22:44:53 +02:00
Donald Sharp
c189a11d7f
Merge pull request #6185 from opensourcerouting/build-assorted-20200408
assorted build fixes
2020-04-08 13:29:45 -04:00
Donald Sharp
52cd71d73b
Merge pull request #6186 from ton31337/fix/no_magic_numbers_community
bgpd: Use COMMUNITY_SIZE instead of just 4
2020-04-08 13:28:56 -04:00
Renato Westphal
ff4e6ca785
Merge pull request #6041 from donaldsharp/wang_a_yump
Wang a yump
2020-04-08 13:33:17 -03:00
Donatas Abraitis
11400e739e bgpd: Use COMMUNITY_SIZE instead of just 4
Easier to maintain and read.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-04-08 18:09:25 +03:00
Renato Westphal
d50b4fe718
Merge pull request #6128 from donaldsharp/more_static_routes_tests
tests: Add a couple more static route tests
2020-04-08 11:59:15 -03:00
David Lamparter
4c015942b1 build: fix git detection for worktrees
When using additional git worktrees, .git is not a directory.

Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-08 16:30:12 +02:00
David Lamparter
261e765345 yang/embedmodel.py: create output dir if needed
For builds with separate build directory, just to be on the safe side.

Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-08 16:30:10 +02:00
David Lamparter
d32ee243af tests: fix parallel build race
If we're building with a separate build directory, these two build
targets can fail in case their output directory hasn't been created by
some other target that may or may not have run earlier.

Signed-off-by: David Lamparter <equinox@diac24.net>
2020-04-08 16:27:59 +02:00
Donald Sharp
cfe9a58785 tests: Add tests to rip and ripngd to show func works
Add some basic tests to show that network and passive-interface
commands work with interface names in rip and ripngd.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-08 10:18:31 -04:00
Donald Sharp
f7688027d8 yang: Temp change interface type to string to allow configuration
Temporarily change the interface types in rip and ripng to
strings to allow us to work, since the yang uplift to 1.0
is proving difficult.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com>
2020-04-08 10:18:31 -04:00
Donatas Abraitis
ff8b039ecf tools: Add coccinelle script to catch typecasts to same type
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-04-08 17:15:10 +03:00
Donatas Abraitis
c4efd0f423 *: Do not cast to the same type
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2020-04-08 17:15:06 +03:00
David Lamparter
c0d4a6d852
Merge pull request #5928 from xThaid/rt_link_cleanup
zebra: make common function for RTM_NEWNEIGH calls
2020-04-08 15:38:46 +02:00
Russ White
99cc5fafeb
Merge pull request #5917 from Spantik/ospf_redis
Zebra: Default route distribute handling.
2020-04-08 09:35:56 -04:00
Donald Sharp
337dcbb913 tests: Add a couple more static route tests
Add a couple more tests to static route installation
Do some very very basic work to make sure that they are working
the way we want.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2020-04-08 09:07:17 -04:00
Kuldeep Kashyap
38c3547ac8 tests: Adding new test suite bgp_communities_topo1
1. Added 1 test case to verify NO-ADVERTISE Community functionality
2. Enhanced bgp.py to exclude routers from verification, if doesn't have bgp config

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-04-08 12:27:23 +00:00
Kuldeep Kashyap
b7250ecfdc tests: Added new tests to bgp-basic-functionality-topo1
1. Added 2 new test cases to bgp-basic-functionality-topo1
2. Enhanced 2 tests to run for both static routes and network advvertise command

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-04-08 12:21:26 +00:00
Kuldeep Kashyap
9d450273df tests: Adding new test suite bgp_as_allow_in
1. Added 5 test cases to verify BGP AS-allow-in behavior in FRR
2. Enhanced framework to support BGP AS-allow-in config(lib/bgp.py)
3. Added API in bgp.py to verify BGP RIB table(lib/bgp.py)

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2020-04-08 12:21:26 +00:00
Olivier Dugeon
63ffd0ea20
Merge pull request #6166 from volta-networks/fix_isis_lsp_timers
isisd, yang: unified lsp-timers command
2020-04-08 10:00:03 +02:00
Renato Westphal
c446af503e
Merge pull request #6180 from mjstapp/fix_bgp_ecomm_sa
bgpd: clean up SA warning in bgp_ecommunity.c
2020-04-07 23:00:06 -03:00
Renato Westphal
eb61cd22e8
Merge pull request #6174 from volta-networks/fix_lm_async_log
zebra: minor fix to label manager log
2020-04-07 22:59:09 -03:00
Renato Westphal
9a38dcbe40
Merge pull request #6183 from qlyoung/doc-isis-lsp-mtu-knob
doc: document lsp-mtu knob for IS-IS
2020-04-07 22:44:42 -03:00
Quentin Young
83d98a8b6e doc: document lsp-mtu knob for IS-IS
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2020-04-07 20:11:18 -04:00
Emanuele Di Pascale
fd506bbb4d isisd: fix two 'no X' commands
for some reason, when issuing a 'no metric-style' command we were
setting the metric-style to narrow, even though the default is
actually wide. Use NULL to avoid similar problems in the future.

Likewise, the 'no is-type' command was still trying to implement
the old logic of applying a different default for the first area.
In practice this had no effect because the value would now be the
same in both cases, but it's better to remove useless code anyway.

Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
2020-04-07 21:57:08 +02:00
Santosh P K
14fe366eab Zebra: Default route distribute handling.
When default route is requested from client, default
route is sent to client if present. When route gets
deleted then delete is sent to clients.

Signed-off-by: Santosh P K <sapk@vmware.com>
2020-04-07 10:12:14 -07:00
Quentin Young
4ce8c005ce
Merge pull request #6178 from opensourcerouting/debian-backprop
feed debian/ changes back into master
2020-04-07 13:03:21 -04:00
Mark Stapp
83ac8d129a bgpd: clean up SA warning in bgp_ecommunity.c
Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-04-07 12:56:43 -04:00
Quentin Young
d9dc3b67a9
Merge pull request #6179 from ton31337/fix/typecast_to_biger_sizes
tools: Add coccinelle script to catch typecasts to larger sizes
2020-04-07 12:42:38 -04:00
Stephen Worley
f3fafda474
Merge pull request #6097 from mjstapp/fix_nhg_cli_dups
lib: support replacement in the nexthop-group cli
2020-04-07 12:14:44 -04:00