Commit Graph

13145 Commits

Author SHA1 Message Date
David Lamparter
ef57f35f41 zebra: add comment about Linux ifdown handling
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-23 12:42:06 +02:00
Philippe Guibert
212df1de28 zebra: remove kernel routes that are suppressed
on some cases, kernel routes are not selected, because the kernel
suppressed it without informing the netlink layer that the route has
been suppressed ( for instance, when an interface goes down, the route
never goes back when interface goes up again). This commit intends to
suppress that entry from zebra.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-17 23:01:10 +02:00
Donald Sharp
b9ea408385
Merge pull request #3192 from lkrishnamoor/evpn_route_server
bgpd: Route Server support for evpn address-family
2018-10-17 14:38:31 -04:00
Donald Sharp
a60c10c0ed
Merge pull request #3194 from opensourcerouting/bugfix/isis-misc
Bugfix: IS-IS fragmentation issues
2018-10-17 14:38:16 -04:00
Lakshman Krishnamoorthy
a6627c993e bgpd: Route Server support for evpn address-family
Signed-off-by: Lakshman Krishnamoorthy lkrishnamoor@vmware.com
2018-10-16 17:44:57 -07:00
Christian Franke
d07067ba45 isisd: adjust lsp size to area->lsp_size before packing
IS-IS would ignore any area lsp-mtu setting configured after initial
creation of the LSP since move to the new tlv serialized/deserializer.

Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-16 19:35:54 +02:00
Christian Franke
dc84cf1494 isisd: Unlink LSP fragments from LSP0 on lsp_destroy
isisd would crash when lsp fragments aged out, since they got freed
correctly, but were not removed from LSP0's linked list of fragments.

Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2018-10-16 19:35:54 +02:00
Quentin Young
4a99c191c9
Merge pull request #3188 from opensourcerouting/bgp-snmp-fix-rename
bgpd: fix missed info->path rename in snmp
2018-10-16 13:18:34 -04:00
David Lamparter
a9a0989b79 bgpd: fix missed info->path rename in snmp
Signed-off-by: David Lamparter <equinox@diac24.net>
2018-10-16 18:17:26 +02:00
Donald Sharp
f3a1b29d41
Merge pull request #3157 from pguibert6WIND/doc_expanded
doc: inform user that expanded communities can not be used in set mode
2018-10-16 11:52:22 -04:00
Renato Westphal
d725199ad9
Merge pull request #3179 from donaldsharp/vni_cmp
bgpd: The l2vni list compare function does not sort
2018-10-15 22:51:03 -03:00
Renato Westphal
7a4ea61dc9
Merge pull request #3181 from qlyoung/frr-sss-indent
tools: reindent frr
2018-10-15 22:46:38 -03:00
Donald Sharp
ce1677906e bgpd: Ensure that evpn_vtep_ip_cmp actually returns useful data
The evpn_vtep_ip_cmp function must return positive and negative
numbers for when we are doing sorted linked list inserts.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-15 11:48:03 -04:00
Quentin Young
25e87a8fdc tools: reindent frr
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2018-10-15 15:45:36 +00:00
Donald Sharp
644657850a bgpd: The l2vni list compare function does not sort
The purpose of adding a l2vni as an sorted list is
shot in the foot when the l2vni compare function only
returns 0 or 1.  This will cause subtle crashes when
we add sorted and we end up with multiple list node pointing
to the same thing.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-15 11:41:39 -04:00
Quentin Young
89678afd0d
Merge pull request #3178 from vincentbernat/fix/json-route-ipv6
bgpd: fix IPv6 next-hop field name for routes in JSON
2018-10-15 11:34:52 -04:00
Vincent Bernat
aa0a10fca2 bgpd: fix IPv6 next-hop field name for routes in JSON
This may break existing clients but the original name contains two
errors.

Signed-off-by: Vincent Bernat <vincent@bernat.ch>
2018-10-15 15:08:37 +02:00
Philippe Guibert
47f47873d6 doc: inform user that expanded communities can not be used in set mode
Expanded communities can not be used in route-map set actions.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-15 15:01:52 +02:00
Donald Sharp
c9e3c7bfb2
Merge pull request #3172 from opensourcerouting/bfd-mhop-lookup
bfdd: fix multi hop hash lookup
2018-10-14 18:04:22 -04:00
Rafael Zalamena
2055ea0969 bfdd: fix multi hop hash lookup
Use the proper multi hop hash for matching multi hop peers.

Spotted by Dmitrii Turlupov.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
2018-10-14 15:39:55 +02:00
Russ White
79e8a97c1a
Merge pull request #3024 from ton31337/fix/validate_route-map
bgpd: Check if route-map really exists before applying to the peer
2018-10-14 08:48:48 -04:00
Russ White
97dc689417
Merge pull request #3142 from donaldsharp/bgp_peerhash
Bgp peerhash
2018-10-12 16:55:50 -04:00
Russ White
5d3a8c513f
Merge pull request #3134 from donaldsharp/bum_flooding
Bum flooding control for BGP and Zebra
2018-10-12 16:52:21 -04:00
Russ White
cf875a1449
Merge pull request #3168 from adharkar/frr-bgp_json
bgpd: BGP JSON new fields
2018-10-12 16:48:08 -04:00
Russ White
13e911db5f
Merge pull request #3167 from chiragshah6/ospfv3_dev
ospf6d: fix ospf6 crash in inp lsa processing
2018-10-12 15:55:59 -04:00
Donald Sharp
b0ecf336f3
Merge pull request #3137 from opensourcerouting/feature/isis-bfd
Feature: BFD for IS-IS
2018-10-12 13:58:26 -04:00
Chirag Shah
beabf870d7 ospf6d: fix ospf6 crash in inp lsa processing
Use ospf6_prefix_same for comparing two exact same prefix
to determine ECMP for a route.
ospf6_route_cmp expects two different prefix rather
being exactly same.

Ticket:CM-22630
Testing Done:
performed ECMP of intra network prefix route via
sending same route via different available
ospf6 paths.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
2018-10-12 09:56:09 -07:00
Christian Franke
d04f9fbf57 isisd: Fix license header of bfd code 2018-10-12 18:56:07 +02:00
Christian Franke
5489eb4563 isisd: Address code-style warnings 2018-10-12 16:45:32 +02:00
Donald Sharp
fd06964433 bgpd: Add '[no] flood <disable|head-end-replication>'
Add the '[no] flood <disable|head-end-replication>' command
to the l2vpn evpn afi/safi sub commands for bgp.  This command
when entered as 'flood disable' will turn off type 3 route
generation for the transmittal of the type 3 route necessary
for BUM replication on the remote VTEP.  Additionally it will
turn off the BUM handling via the new zebra command,
ZEBRA_VXLAN_FLOOD_CONTROL.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-11 20:27:28 -04:00
Donald Sharp
fbac9605a7 lib, zebra: Allow the specification of BUM flooding
Allow the modification of whether or not we will allow
BUM flooding on the vxlan bridge.  To do this allow
the upper level protocol to specify via the ZEBRA_VXLAN_FLOOD_CONTROL
zapi message.

If flooding is disabled then BUM traffic will not be forwarded
to other VTEP's.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2018-10-11 20:22:19 -04:00
Donald Sharp
eaae6204a9
Merge pull request #3140 from vishaldhingra/b_2802
zebra : VRF aware route map in zebra
2018-10-11 20:18:57 -04:00
Ameya Dharkar
37d4e0dfab bgpd: BGP JSON new fields
1. "show bgp ipv4 json"
  - Added "network" field which displays a prefix in 'prefix/prefixlen' format.

2. "show bgp ipv6 json"
  - Added "network" field which displays a prefix in 'prefix/prefixlen' format.
  - JSON does not have "prefix", "prefixLen" fields which are present in IPv4
    command. Added these fields as they are useful.

3. "show bgp ipv4/ipv6 neighbor <neighbor_addr> advertised-routes json"
  - Added "network" field.

4. "show bgp ipv4/ipv6 summary json"
  - Added "pfxSnt" for peers. This count is obtained from corresponding
    update_subgroup.

5. "show bgp neighbor json"
  - Added "sentPrefixCounter"

Signed-off-by: Ameya Dharkar <adharkar@vmware.org>
2018-10-11 15:35:21 -07:00
vishaldhingra
7cf16e19c5 zebra: vrf aware routmap is missing in Zebra #2802(Part 4 of 4)
The new cli for show output

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:49:34 -07:00
vishaldhingra
214e5c2679 zebra: vrf aware routmap is missing in Zebra #2802(Part 3 of 4)
The cli changes to allow this to work.

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:48:23 -07:00
vishaldhingra
6d53d7b1af zebra: vrf aware routmap is missing in Zebra #2802(Part 2 of 4)
Function parameter replacement of using zvrf instead of vrf_id

Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:46:55 -07:00
vishaldhingra
ac6eebce50 zebra: vrf aware routmap is missing in Zebra #2802(Part 1 of 4)
Work to handle the route-maps, namely the header changes in zebra_vrf.h
 and the mapping of using that everywhere

 Signed-off-by: vishaldhingra vdhingra@vmware.com
2018-10-11 10:44:55 -07:00
Lou Berger
b3c8d34291
Merge pull request #3032 from donaldsharp/bgp_info
`struct bgp_info` to `struct bgp_path_info`
2018-10-11 09:17:31 -04:00
Donatas Abraitis
1de2762153 bgpd: Check if route-map really exists before applying to the peer
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
2018-10-11 10:56:12 +03:00
Donald Sharp
8f7bfe318b
Merge pull request #3153 from adharkar/frr-scount
bgpd: Incorrect sent prefix count for a split subgroup
2018-10-10 15:42:20 -04:00
Ameya Dharkar
0ab7b206a6 bgpd: Incorrect sent prefix count for a split subgroup
When a subgroup splits to form a new subgroup because of policy changes
for a peer, new subgroup copies adj out(state about advertised routes)
from the parent subgroup. At the same time, it should also copy
scount(advertised prefix count) to the new subgroup for the count to be
in sync with the adj_out for the subgroup.

Signed-off-by: Ameya Dharkar <adharkar@vmware.org>
2018-10-10 11:34:40 -07:00
Quentin Young
fa8875b922
Merge pull request #3155 from opensourcerouting/building_instructions
doc: update building instructions
2018-10-10 14:18:45 -04:00
Quentin Young
3f815a1ed1
Merge pull request #3159 from pguibert6WIND/doc_draft_bgp
doc: fix warning of doc compilation with bgp draft
2018-10-10 14:15:15 -04:00
Renato Westphal
e7fb64387c
Merge pull request #3154 from donaldsharp/bgp_mem_lem
Bgp mem issue with martian address interface strings
2018-10-10 13:08:28 -03:00
Renato Westphal
dde90f1e7c doc: simplify build instructions
Remove all --enable-xxx configuration flags for features that are enabled
by default.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Renato Westphal
345c140ec2 doc: update build instructions for Debian 9
The instruction to checkout to the stable/3.0 branch doesn't belong
here.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Renato Westphal
9580f50deb doc: remove LibXML from the list of dependencies
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2018-10-10 11:14:37 -03:00
Donald Sharp
8a7599cd27
Merge pull request #3145 from pguibert6WIND/ipv6nexthop
bgpd: in case nexthop is ipv6, set nh attribute flag in mpls vpn case
2018-10-10 10:08:01 -04:00
Philippe Guibert
75cd35c697 bgpd: in case nexthop is ipv6, set nh attribute flag in mpls vpn case
In mpls vpn import/export, the nexthop attribute should also be
recognised for ipv6 too.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-10 13:13:09 +02:00
Philippe Guibert
49606d5872 doc: fix warning of doc compilation with bgp draft
Some draft ietf are not handle by :rfc: keyword. A workaround is
proposed, like it has been done for flowspec.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
2018-10-10 11:50:38 +02:00