proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-24 13:21:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
25,157 Commits 4 Branches 191 Tags 125 MiB
e17e248b2a
Commit Graph

25157 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael Zalamena
e17e248b2a topotests: reduce convergence check frequency 
Check for convergence less frequently to reduce resources usage.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:41 -03:00
Rafael Zalamena
4000805713 topotests: skip daemons without configuration 
Lets not start daemons without configurations.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:36 -03:00
Rafael Zalamena
20ec1f7038 topotests: remove code that checks for version 
We version the tests with FRR so we no longer need to check for version.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:25 -03:00
Rafael Zalamena
0a5b9d7158 topotests: use new OSPFv3 interface area syntax 
The old one is not VRF aware and is being deprecated.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:38:17 -03:00
Rafael Zalamena
582bf957fd topotests: reduce MSDP topology 
Meanwhile we don't get all MSDP features (MSDP route validation via BGP
AS Path as described in RFC 4611 Section 2), kill one of the links of
the topology to avoid intermittent test failures due to different
traffic route.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
 2021-08-06 10:35:45 -03:00
Mark Stapp
6696b16bf0
Merge pull request #9302 from ton31337/fix/comments 
bgpd: Fix misleading comments for some parts
 2021-08-05 14:39:38 -04:00
Donald Sharp
5dbd69cc9f
Merge pull request #9023 from idryzhov/static-nb 
staticd: simplify the northbound code
 2021-08-05 09:38:00 -04:00
Donatas Abraitis
639caccfeb bgpd: Fix misleading comments for some parts 
Mostly just retrun => return and misleading comments at all.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-08-05 16:29:52 +03:00
Mark Stapp
5f10f7804f
Merge pull request #9050 from LabNConsulting/chopps/reset-parallel 
Chopps/reset parallel
 2021-08-04 16:17:30 -04:00
Sri Mohana Singamsetty
08d7be0f4d
Merge pull request #9261 from vivek-cumulus/fix_evpn_quick_flap 
bgpd: Handle quick flaps of an EVPN prefix properly
 2021-08-04 12:44:37 -07:00
Mark Stapp
27649e64f2
Merge pull request #9291 from donaldsharp/fix_long_sleep 
tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway
 2021-08-04 12:54:25 -04:00
Donald Sharp
22e135b451
Merge pull request #8182 from mjstapp/topotest_start_tgen 
tests: make the topogen object available when starting daemons
 2021-08-04 08:48:06 -04:00
Donald Sharp
1c7cad9be8 tests: Remove sleep(200) from bgp-evpn-overlay-index-gateway 
Remove a 200 second sleep from bgp-evpn-overlay-index-gateway.
There does not seem to be any evidence that this is needed
and I cannot make the test fail without it.

Fixes: #9035
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2021-08-04 08:05:12 -04:00
Donald Sharp
5504fee4a3
Merge pull request #9085 from mobash-rasool/pim-upst-4 
pimd: memory leak fix and issue fix
 2021-08-03 21:21:14 -04:00
Donald Sharp
761704b370
Merge pull request #9092 from rgirada/rmap 
ospfd: OSPF hello packets not sent with configured hello timer
 2021-08-03 21:18:21 -04:00
Donald Sharp
3e18e550ed
Merge pull request #9108 from opensourcerouting/ospf6d-range-fixes 
ospf6d: fix argument processing in the "area ... range" command
 2021-08-03 21:15:12 -04:00
Russ White
efadadc1b6
Merge pull request #9264 from ak503/nhrp_fix 
nhrp: fix display of nhs command.
 2021-08-03 13:42:48 -04:00
Russ White
67831eeebb
Merge pull request #9164 from pguibert6WIND/flowspec_vrflite_shortcut 
bgpd: flowspec redirect vrf uses vrf table instead of allocated table id
 2021-08-03 09:31:17 -04:00
Russ White
cdc549b51a
Merge pull request #9191 from idryzhov/rip-auth 
ripd: fix authentication key length
 2021-08-03 09:29:09 -04:00
Russ White
11093fc905
Merge pull request #9231 from idryzhov/zebra-rmap-set-src 
zebra: remove checks for src address existence when using "set src"
 2021-08-03 09:22:18 -04:00
Russ White
f61a950acf
Merge pull request #9239 from idryzhov/ospf-passive-fix 
ospfd: fix "no ip ospf passive" command
 2021-08-03 09:21:14 -04:00
Russ White
f041fe620d
Merge pull request #9243 from ton31337/fix/revert_db0e636dc45f9bd2c76528a8368332c56f2c8f1e 
bgpd: Revert a couple of BGP dampening related commits
 2021-08-03 09:20:16 -04:00
Russ White
26d7f8b285
Merge pull request #9249 from ton31337/fix/dont_capability 
bgpd: Use strict AS4 capability when processing parsing/generating pkts
 2021-08-03 09:14:27 -04:00
Russ White
1358f9d10a
Merge pull request #9259 from opensourcerouting/moar-json 
*: can't get enough JSON
 2021-08-03 09:13:12 -04:00
Dmitrii Turlupov
7a807a20d9 nhrp: fix display of nhs command. 
Before:
ip nhrp nhs dynamicnbma 192.168.1.1

After:
ip nhrp nhs dynamic nbma 192.168.1.1

Signed-off-by: Dmitrii Turlupov <dturlupov@factor-ts.ru>
 2021-08-03 14:10:54 +03:00
Russ White
04cfc0a3a8
Merge pull request #9056 from askorichenko/test-dont-capability 
bgpd: Clear capabilities field when resetting a bgp neighbor
 2021-08-03 06:59:56 -04:00
Christian Hopps
35c4c991f0 tests: reset router configs in parallel 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-08-03 09:07:49 +00:00
Christian Hopps
269a822be4 tests: dump the actual json values to log 
Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-08-03 09:07:49 +00:00
Donatas Abraitis
71c06f610f
Merge pull request #9258 from mjstapp/fix_rule_strlcpy 
zebra: use strlcpy in dplane_rule_init
 2021-08-03 09:12:38 +03:00
vivek
9146341f06 bgpd: Handle quick flaps of an EVPN prefix properly 
When an EVPN prefix flaps too quickly such that the new advertisement
is received prior to the full processing of the prior withdraw, we may
get into a state where the route doesn't get imported properly into
MAC or IP VRFs. Ensure that we do the route import in such cases.

Suggested-by: Sri Mohana Singamsetty <msingamsetty@vmware.com>
Suggested-by: Ameya Dharkar <adharkar@vmware.com>
Signed-off-by: Vivek Venkatraman <vivek@nvidia.com>
 2021-08-02 22:06:28 -07:00
Renato Westphal
488599bfa2
Merge pull request #9232 from idryzhov/interface-node-cleanup 
*: cleanup interface node installation
 2021-08-02 21:13:29 -03:00
Renato Westphal
58e2857d23 lib: add "json" option to "show ip[v6] prefix-list" 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2021-08-02 17:19:45 -03:00
Renato Westphal
c15dc24f79 zebra: add "json" option to "show interface" 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2021-08-02 17:19:45 -03:00
Renato Westphal
856ed18ae9 lib: add "json" option to "show route-map" 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2021-08-02 16:05:44 -03:00
Renato Westphal
068ab9018b lib: add "json" option to "show ip[v6] access-list" 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2021-08-02 16:05:44 -03:00
Renato Westphal
b15e836067 bgpd: add "json" option to "show bgp as-path-access-list" 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
 2021-08-02 15:53:02 -03:00
Mark Stapp
bc86b347db zebra: use strlcpy in dplane_rule_init 
Use strlcpy for safety in dplane rule init api.

Signed-off-by: Mark Stapp <mjs.ietf@gmail.com>
 2021-08-02 12:35:50 -04:00
Donald Sharp
b22928a117
Merge pull request #9255 from ton31337/fix/bgp_max_packet_size_no_capabilities 
bgpd: Set extended msg size only if we advertised and received capability
 2021-08-02 12:11:24 -04:00
Igor Ryzhov
1f74d96c41 zebra: remove checks for src address existence when using "set src" 
1. This check is absolutely useless. Nothing keeps user from deleting
   the address right after this check.
2. This check prevents zebra from correctly reading the user config with
   "set src" because of a race with interface startup (see #4249).
3. NO OPERATIONAL DATA USAGE ON VALIDATION STAGE.

Fixes #7319.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
 2021-08-02 18:35:30 +03:00
Igor Ryzhov
72928fa1aa
Merge pull request #9238 from leonshaw/fix/netns-delete 
lib, zebra: Preserve user-configured VRF on netns deletion
 2021-08-02 18:12:19 +03:00
Quentin Young
41d3d77496
Merge pull request #8982 from dlqs/lua-func-stack 2021-08-02 13:51:35 +00:00
Mark Stapp
08bbca7511
Merge pull request #9211 from donaldsharp/revert_logic_changes 
lib: prevent crash in make check in some situations
 2021-08-02 08:34:55 -04:00
Donatas Abraitis
8d976b0e2b bgpd: Set extended msg size only if we advertised and received capability 
If we don't advertise any capabilities (dont-capability-negotiate), we
shouldn't set msg size to 65k only if received this capability from another
peer.

Before:

```
~/frr# vtysh -c 'show ip bgp update-group' | grep 'Max packet size'
    Max packet size: 65535
```

After:

```
~/frr# vtysh -c 'show ip bgp update-group' | grep 'Max packet size'
    Max packet size: 4096
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-08-02 09:34:43 +03:00
Philippe Guibert
7afeaffa12 bgpd: flowspec redirect vrf uses vrf table instead of allocated table id 
Until now, when bgp flowspec entry action was to redirect to a vrf, a
default route was installed in a specific table. that route was a vrf
route leak one. The process can be simplified, as vrf-lite already
has a table identifier. Actually, because policy routing is used to
redirect traffic to a defined table (with ip rule command), use
the table identifier of the VRF.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2021-08-01 14:38:13 +02:00
Donatas Abraitis
ecec984b2f tests: Check if BGP connection established if using no capabilities adv 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-08-01 09:58:26 +03:00
Donatas Abraitis
8cff42add5 bgpd: Use strict AS4 capability when processing parsing/generating pkts 
PeerA sets `dont-capability-negotiate` for PeerB. It does not send any
capabilities to PeerB. This leads to situation when PeerA received AS4 cap,
while it doesn't send AS4 to PeerB and tries parsing AS_PATH using 32bits.

[GTTPK-RX2GP][EC 33554436] Malformed AS path from 192.168.0.2, length is 4
[SM0KX-WXMGK] bgp_attr_malformed: attributes: , origin ?
[P7TRR-4J6XT][EC 33554487] 192.168.0.2: Attribute AS_PATH, parse error - treating as withdrawal
[WX70K-6XXVF][EC 33554454] 192.168.0.2 rcvd UPDATE with errors in attr(s)!! Withdrawing route.
[Z2KFR-ZGJC8] 192.168.0.2 rcvd UPDATE w/ attr: , origin ?
[P9VY3-5B6NX] 192.168.0.2 rcvd UPDATE wlen 0 attrlen 80 alen 73
[QMZ79-K2DH7][EC 33554454] 192.168.0.2 [Error] Update packet error (wrong prefix length 64 for afi 1)
[P9SYB-54XRZ][EC 33554454] 192.168.0.2 [Error] Error parsing NLRI
[V1CHF-JSGRR] %NOTIFICATION: sent to neighbor 192.168.0.2 3/10 (UPDATE Message Error/Invalid Network Field) 0 bytes
[HTHRX-GQYGJ][EC 33554454] bgp_process_packet: BGP UPDATE receipt failed for peer: 192.168.0.2

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
 2021-08-01 09:56:48 +03:00
Donald Sharp
a76301c11c
Merge pull request #9244 from LabNConsulting/chopps/fix-bgp-list-test 
tests: add early interface config for topojson and fix test
 2021-07-31 21:37:22 -04:00
Donatas Abraitis
41a6c1a32a
Merge pull request #9246 from mjstapp/fix_doc_bgp_colons 
doc: fix bgp user doc colons
 2021-07-31 20:16:39 +03:00
Christian Hopps
845b234a8d tests: add early interface config for topojson and fix test 
- A more general fix for the bgp listener test which requires interfaces be
configured in the kernel when the bgpd daemons are launched.

Signed-off-by: Christian Hopps <chopps@labn.net>
 2021-07-31 14:09:24 +00:00
David Lamparter
00908959ed
Merge pull request #9228 from LabNConsulting/chopps/scapy-sendpkt 
tests: add scapy_sendpkt.py util, replace arping use with it
 2021-07-31 12:09:40 +02:00