Commit Graph

32367 Commits

Author SHA1 Message Date
Mark Stapp
d8f0a8eb47
Merge pull request #13851 from opensourcerouting/fix/use_zclient_sync_for_table_manager
bgpd: Use synchronous Zebra client for table manager
2023-06-27 08:54:46 -04:00
Donatas Abraitis
53785cdd43
Merge pull request #13628 from kuldeepkash/uplink_mcast_tests
tests: Add multicast-pim-multi-uplink test suite
2023-06-27 13:34:17 +03:00
Donatas Abraitis
a21d361169
Merge pull request #13672 from zmw12306/AE_zero
babeld: add AE!=0 check when type is 7 or 10.
2023-06-27 13:18:20 +03:00
Donatas Abraitis
4199f032e5
Merge pull request #13722 from fdumontet6WIND/color_extcomm
bgpd,lib,yang: add colored extended communities support
2023-06-27 13:03:22 +03:00
Donatas Abraitis
f018e3cdcf
Merge pull request #13857 from anlancs/doc-wrong-code
doc: Fix one syntax error for code block
2023-06-27 12:56:47 +03:00
Donatas Abraitis
edf6d1917c bgpd: Guard zlog_debug for table manager when the connection is successful
We shouldn't use unguarded zlog_debug().

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-27 09:32:07 +03:00
Donatas Abraitis
ec3d30f55d bgpd: Use zlog_err when can't connect to table manager (zebra)
If this an error, we should use zlog_err, not zlog_info as this is literally
not an information, but an error.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-27 09:29:52 +03:00
anlan_cs
4e8737b269 doc: Fix one syntax error for code block
The code block doesn't work due to special thing in front of it.
So, just make it work.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
2023-06-27 13:51:40 +08:00
Donald Sharp
dee79c33a4
Merge pull request #13804 from LabNConsulting/aceelindem/ospf6d-config-callbacks
ospf6d: Add config callbacks to suppress hellos during config load.
2023-06-26 14:59:13 -04:00
Donald Sharp
766852e95c
Merge pull request #13802 from LabNConsulting/aceelindem/ospfd-config-callbacks
ospfd: Add config callbacks and suppress hello during config load.
2023-06-26 14:58:03 -04:00
Donatas Abraitis
787c61e03c bgpd: Use synchronous Zebra client for table manager
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-26 17:43:40 +03:00
Francois Dumontet
fc44787211 doc: extcommunity color
Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
2023-06-26 14:27:27 +02:00
Francois Dumontet
442e2edcfa bgpd: add functions related to srte_color management
Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
2023-06-26 14:27:27 +02:00
Francois Dumontet
9ec092c6a2 tests: add bgp colored extended community test
Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
2023-06-26 14:27:27 +02:00
Francois Dumontet
b80ebc2d8c bgpd: add colored extended communities support
add support of color extended community, conforming to RFC 9012.
This extended community will be added to the existing one, RT,SOO
and Node Target. The configuration will be made through the
route-map service.

find above a configuration example:

router bgp 65001
 bgp router-id 192.168.1.1
 no bgp ebgp-requires-policy
 no bgp network import-check
 neighbor 192.168.1.2 remote-as external
 neighbor 192.168.1.3 remote-as external
 neighbor 192.168.1.4 remote-as external
 address-family ipv4 unicast
  network 10.10.10.10/24 route-map rmap
  exit-address-family
!
  route-map rmap permit 10
   set extcommunity color 55555 200
  exit

Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
2023-06-26 14:27:27 +02:00
Donatas Abraitis
4262dc3bd8
Merge pull request #13771 from mjstapp/opaque_notify
lib, zebra, sharpd: add notifications for ZAPI opaque message registration events
2023-06-26 13:08:52 +03:00
Donatas Abraitis
9d9555fb7d
Merge pull request #13848 from LabNConsulting/chopps/clang-format-tweak
tools: less aggressive settings for clang-format
2023-06-26 12:55:10 +03:00
Jafar Al-Gharaibeh
9580580c7b
Merge pull request #13839 from LabNConsulting/chopps/nofiltermodule
staticd: remove unused YANG module
2023-06-25 23:54:57 -05:00
Kuldeep Kashyap
e3122819e9 tests: Add multicast-pim-multi-uplink-topo3 suite
Added 4 new test cases to verify multicast PIM
uplink(8 uplink) functionality.

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2023-06-26 09:30:04 +05:30
Kuldeep Kashyap
e350fb986e tests: Add multicast-pim-multi-uplink-topo2 suite
Added 4 new test cases to verify multicast PIM
uplink(8 uplink) functionality.

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
2023-06-26 09:30:04 +05:30
Christian Hopps
ab06853c25 tools: less aggressive settings for clang-format
- Reports were that the current settings were choosing to extend beyond 80
columns too often. This change makes that more expensive but still tries
very hard to not break before first open parenthesis of function calls.

Signed-off-by: Christian Hopps <chopps@labn.net>
2023-06-25 22:06:12 -04:00
Donatas Abraitis
356d0eca24
Merge pull request #13845 from LabNConsulting/aceelindem/isis-config-end-error-log
isisd: Log error when config-end timeout occurs.
2023-06-24 23:35:58 +03:00
Donatas Abraitis
9410a6aec7
Merge pull request #13844 from LabNConsulting/aceelindem/bgp-config-callback-log
bgpd: Add config-end timeout error log message.
2023-06-24 23:22:56 +03:00
Donatas Abraitis
ab2f93463e
Merge pull request #13822 from SaiGomathiN/regF
pim, pim6d: pimreg interface is not getting added in a certain scenario
2023-06-24 23:22:10 +03:00
Acee
119dc48bb7 isisd: Log error when config-end timeout occurs.
Signed-off-by: Acee <aceelindem@gmail.com>
2023-06-24 13:43:03 -04:00
Acee
ee679e506e bgpd: Add config-end timemout error log message.
Signed-off-by: Acee <aceelindem@gmail.com>
2023-06-24 13:29:24 -04:00
Christian Hopps
632440683f staticd: remove unused YANG module
Signed-off-by: Christian Hopps <chopps@labn.net>
2023-06-23 13:17:32 -04:00
Mark Stapp
f6700b3491 sharpd: support opaque zapi notifications
Add cli and support to sharpd to exercise the zapi opaque
'notification' features.

Signed-off-by: Mark Stapp <mjs@labn.net>
2023-06-23 08:57:37 -04:00
Mark Stapp
de1a9ce0a7 zebra: support notifications for opaque ZAPI messages
Allow zapi clients to register to be notified when a server
for an  opaque message type is present. Zebra maintains these
notification registrations in the same data structures that it
uses for opaque message handling.

Signed-off-by: Mark Stapp <mjs@labn.net>
2023-06-23 08:57:37 -04:00
Mark Stapp
06647109ab lib: add notifications for opaque zapi messages
Add a new notification zapi message type. A zapi client
that uses opaque messages can register to be notified
when a server for an opaque type is present.

Signed-off-by: Mark Stapp <mjs@labn.net>
2023-06-23 08:57:37 -04:00
Mark Stapp
ef8e3ac02c lib, zebra: include source client zapi info in opaque messages
Include the sending zapi client info (proto, instance, and
session id) in each opaque zapi message. Add opaque 'init'
apis for clients who want to encode their opaque data inline,
into the zclient's internal stream buffer. Use these init apis
in the TE/link-state lib code, instead of hand-coding the
zapi opaque header info.

Signed-off-by: Mark Stapp <mjs@labn.net>
2023-06-23 08:27:42 -04:00
Acee
4e410167c0 ospf6d: Add config callbacks to suppress hellos during config load. Add bgpd/isisd message.
Signed-off-by: Acee <aceelindem@gmail.com>
2023-06-23 07:48:02 -04:00
Acee
c6e3af3013 ospfd: Add config callbacks and suppress hello during config load.
Signed-off-by: Acee <aceelindem@gmail.com>
2023-06-23 07:20:35 -04:00
Donatas Abraitis
3cbc7150bb
Merge pull request #13545 from idryzhov/remove-bond-slave
zebra: remove ZEBRA_IF_BOND_SLAVE interface type
2023-06-23 11:01:19 +03:00
Jafar Al-Gharaibeh
0951530abc
Merge pull request #13823 from LabNConsulting/aceelindem/workflow-coverity-typo
doc: Fix typo in previous Coverity workflow doc commit.
2023-06-22 13:32:09 -05:00
Jafar Al-Gharaibeh
499eae6c6b
Merge pull request #13795 from LabNConsulting/chopps/mgmt-lock-cleanup
mgmt lock simplification
2023-06-22 13:31:27 -05:00
Donatas Abraitis
4fa21aaae0
Merge pull request #13824 from LabNConsulting/chopps/update-clang-format
tools: import latest linux clang-format config w/ FRR mods
2023-06-22 14:07:23 +03:00
Christian Hopps
2615fefaa9 tools: import latest linux clang-format config w/ FRR mods
We modify the following from Linux Style:

    AlignEscapedNewlines: Left -> Right
    AlignTrailingComments: false -> true
    AlignConsecutiveMacros: false -> true
    ForEachMacros (replace linux with ours)

Don't break a string into multi-string-fragments

    PenaltyBreakString: 200

Allow going past the ColumnLimit to keep function arguments aligned
with the open parenthesis.

    PenaltyBreakBeforeFirstCallParameter: 200

Signed-off-by: Christian Hopps <chopps@labn.net>
2023-06-22 00:56:04 -04:00
Mark Stapp
6e1204c62a
Merge pull request #13825 from sri-mohan1/srib-ripng
ripngd: changes for code maintainability
2023-06-21 16:27:01 -04:00
mobash-rasool
d94c373266
Merge pull request #13731 from cyberstorm-mauritius/cid1519841
vrrp: check return value for turning off multicast for v6
2023-06-21 23:15:41 +05:30
sri-mohan1
3a40f78305 ripngd: changes for code maintainability
these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
2023-06-21 22:39:13 +05:30
Donatas Abraitis
fd8a8b7596
Merge pull request #13797 from sri-mohan1/srib-ripng
ripngd: changes for code maintainability
2023-06-21 17:00:00 +03:00
Russ White
be4cfbd2b8
Merge pull request #13790 from pguibert6WIND/set_aspath_exclude
bgpd: add 'set as-path exclude all' command
2023-06-21 08:48:21 -04:00
Mark Stapp
b20acd03f1
Merge pull request #13780 from opensourcerouting/fix/use_sync_zapi_for_labels
bgpd: Use synchronous way to get labels from Zebra
2023-06-21 07:49:07 -04:00
Acee Lindem
f8831ce197 doc: Fix typo in previous Coverity workflow doc commit.
Signed-off-by: Acee Lindem <aceelindem@gmail.com>
2023-06-21 07:11:10 -04:00
Sai Gomathi N
fce0f28bf3 pim, pim6d: pimreg interface is not getting added in a certain scenario
Problem:
When ipv6 pim configuration is removed from the IIF on FHR node,
if we wait for RST timer to expire and then add the ipv6 pim configuration on the IIF again,
it is seen that pimreg is not getting added due to which null register wont be sent,
the register flag state also remains NO_INFO forever instead of RegPrune.
The reason for this is, when RST timer expires and IIF is unknown for the (S,G) upstream,
the FHR state is not reset due to which when the RP becomes reachable,
upstream state changes from NotJoined to Join but the register suppress timer could not be started
since we see there is no change in FHR state.

Fix:
When the Register Timer expires and the reg state is set to PIM_REG_NOINFO,reset the FHR flag,
so that when the RP becomes reachable can be because of config change or RP not reachable,
it is able to resume its duty.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
2023-06-21 03:46:58 -07:00
Donatas Abraitis
52dde8747b zebra: Ignore non GR-aware zclient handling for BGP
This is for synchronous client (label/table manager) - aka session_id == 1.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-20 20:50:40 +03:00
Donatas Abraitis
257a0e0688 bgpd: Do not initialize global variable zclient_sync to NULL
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-20 20:50:40 +03:00
Donatas Abraitis
20c2c8787a zebra: Show session id when printing an error when the client disconnects
Before:

```
2023/06/18 22:00:42 ZEBRA: [VXKFG-8SJRV][EC 4043309121] Client 'bgp' encountered an error and is shutting down.
2023/06/18 22:00:42 ZEBRA: [VXKFG-8SJRV][EC 4043309121] Client 'bgp' encountered an error and is shutting down.
```

After:

```
2023/06/18 22:06:44 ZEBRA: [N5M5Y-J5BPG][EC 4043309121] Client 'bgp' (session id 0) encountered an error and is shutting down.
2023/06/18 22:06:44 ZEBRA: [N5M5Y-J5BPG][EC 4043309121] Client 'bgp' (session id 1) encountered an error and is shutting down.
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-20 20:50:40 +03:00
Donatas Abraitis
cf8a749934 bgpd: Reuse bgp_zebra_label_manager_ready() helper function
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2023-06-20 20:50:40 +03:00