proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-28 19:43:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
29,123 Commits 4 Branches 191 Tags 125 MiB
d335feeff8
Commit Graph

29123 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Donald Sharp
d335feeff8
Merge pull request #11682 from opensourcerouting/frr-format-gcc-12 
tools/gcc-plugins: make GCC 12 compatible
 2022-07-27 11:44:39 -04:00
Donald Sharp
528d3d87bf
Merge pull request #11689 from opensourcerouting/fix/port_for_unnumbered 
bgpd: Allow setting custom port for unnumbered sessions
 2022-07-27 11:42:09 -04:00
Donatas Abraitis
c41e93720a bgpd: Reset BGP sessions when changing the port 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-07-27 11:44:07 +03:00
Donatas Abraitis
a3aecc99d5 bgpd: Allow setting custom port for BGP unnumbered peers 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-07-27 11:36:15 +03:00
Martin Winter
8d4abfc9b9
Merge pull request #11164 from kuldeepkash/pim_v6 2022-07-27 10:05:25 +02:00
Donatas Abraitis
6310965c21
Merge pull request #11681 from donaldsharp/valgrind_issues 
pimd: Fix a couple coverity issues with mtracebis_netlink.c
 2022-07-27 10:51:25 +03:00
Donatas Abraitis
4a16d62977
Merge pull request #11678 from donaldsharp/valgrind_me 
Valgrind me
 2022-07-27 10:29:29 +03:00
David Lamparter
3d3ed1afb2 tools/gcc-plugins: make GCC 12 compatible 
check_function_arguments_recurse() has received a new function argument
in GCC 12.  Fill it in and add a compatibility wrapper.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
 2022-07-26 15:38:16 -04:00
Donald Sharp
3816a65da3 pimd: Fix a couple coverity issues with mtracebis_netlink.c 
Coverity is complaining that buf has not been initialized.
It has and coverity appears to be confused so let's help it
find the initialization.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-26 13:45:27 -04:00
Christian Hopps
594936dd0a
Merge pull request #11679 from donaldsharp/fix_compilation_bgp_vty 
bgpd: Remove newlines from zlog, they are not allowed
 2022-07-26 12:48:40 -04:00
Donald Sharp
cbdecd685c tests: Fixup more missing pytestmark annotations 
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-26 12:41:53 -04:00
Donald Sharp
1cf42d6a00 zebra: Fix lost memory on lsp free 
When cleaning up memory associated with a lsp the
nhlfe is lost in some cases.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-26 12:41:11 -04:00
Donald Sharp
62bf6b4200 bgpd: Fixup pbr rule changes that were missed 
In commit: d70a31a3ef

the Zapi ZEBRA_RULE_ADD message was modified but
the bgp version was not updated appropriately and
when zebra received the message it did not properly
read it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-26 12:41:11 -04:00
Donald Sharp
1af6e82b81 bgpd: Remove newlines from zlog, they are not allowed 
commit: a486300b26
introduced newlines in zlog_XX messaging.  Not allowed.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-26 10:06:38 -04:00
Russ White
2ade1c0059
Merge pull request #11582 from liwg06/master 
bgpd: Fixup some MAC address token cli syntax
 2022-07-26 09:20:45 -04:00
Russ White
3bf3144517
Merge pull request #11523 from pguibert6WIND/bgp_no_retain 
Bgp no retain
 2022-07-26 08:50:59 -04:00
Donald Sharp
749cf3c23d
Merge pull request #11674 from opensourcerouting/fix/cleanup_subgrpoup_hash_on_update_group_delete 
bgpd: Cleanup subgroup hash when we delete/merge a subgroup
 2022-07-25 16:50:03 -04:00
Donatas Abraitis
4d28080cb1 bgpd: Rename baa_new/baa_free/etc functions to be human-readable 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-07-25 16:45:06 +03:00
Donatas Abraitis
e92cf867a6 bgpd: Cleanup subgroup hash when we delete/merge a subgroup 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-07-25 10:20:28 +03:00
Kuldeep Kashyap
dab5ff0030 tests: [PIMv6] Add test_multicast_pimv6_static_rp suite 
Adding supporting multicast PIMv6 static rp test
suite.

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2022-07-23 21:28:40 -07:00
Kuldeep Kashyap
e13f9c4f31 tests: [PIMv6] APIs for multicast PIMv6 config 
Enhanced few exsiting PIM APIs to support both
IPv4 and IPv6 configuration. Added few new APIs
for PIMv6. Tested all existing tests with new
API changes.

Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
 2022-07-23 21:28:35 -07:00
Donald Sharp
9c24c1580a
Merge pull request #11666 from opensourcerouting/fix/memory_leak_for_regexp_bgp_aspath 
bgpd: Free memory for as-path filter if regexp is wrong
 2022-07-23 07:40:30 -04:00
Donatas Abraitis
8fc5cba9f8
Merge pull request #11661 from donaldsharp/bnc_debugs 
bgpd: LL peers need bnc's per peer
 2022-07-23 13:11:32 +03:00
Donatas Abraitis
3a3a57cb8c
Merge pull request #11656 from donaldsharp/some_memory 
Some memory
 2022-07-23 13:10:59 +03:00
Donatas Abraitis
f4837b4bf8
Merge pull request #11669 from Chromico/master 
topotests: Drop static route
 2022-07-23 13:10:43 +03:00
Chromico
668289897b topotests: Drop static route 
Signed-off-by: Nathan Mangar <nathan@thundergear.io>
 2022-07-23 01:47:26 +04:00
Donald Sharp
ff6db1027f bgpd: Make sure hdr length is at a minimum of what is expected 
Ensure that if the capability length specified is enough data.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-22 13:56:54 -04:00
Donald Sharp
81e6f2c376
Merge pull request #11652 from pguibert6WIND/path_fini 
pathd: add a zebra stop handler
 2022-07-22 13:22:37 -04:00
Donald Sharp
49efc80d34 isisd: Ensure rcap is freed in error case 
unpack_tlv_router_cap allocates memory that in the error
case is not being freed.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-22 13:17:58 -04:00
Donald Sharp
d2aeac3870 ospfclient: Ensure ospf_apiclient_lsa_originate cannot accidently write into stack 
Even though OSPF_MAX_LSA_SIZE is quite large and holds the upper bound
on what can be written into a lsa, let's add a small check to ensure
it is not possible to do a bad thing.

This wins one of the long standing bug awards.  2003!

Fixes: #11602
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-22 13:17:58 -04:00
Donatas Abraitis
e88307cf3c bgpd: Free memory for as-path filter if regexp is wrong 
Before:

```
$ vtysh -c 'sh memory bgpd | include Temporary'; echo ; for x in $(seq 1 1000); do vtysh -c 'conf' -c 'bgp as-path access-list belekas permit wrong' >/dev/null; done; vtysh -c 'sh memory bgpd | include Temporary'
Temporary memory              :       19 variable       504       22       656
Temporary memory              :     1019 variable     24504     1023     24656
```

After:

```
$ vtysh -c 'sh memory bgpd | include Temporary'; echo ; for x in $(seq 1 1000); do vtysh -c 'conf' -c 'bgp as-path access-list belekas permit wrong' >/dev/null; done; vtysh -c 'sh memory bgpd | include Temporary'
Temporary memory              :       19 variable       504       22       656
Temporary memory              :       19 variable       504       24       680
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-07-22 17:43:45 +03:00
Rafael Zalamena
b8443f7ad3
Merge pull request #11565 from pguibert6WIND/bfd_vrf_lite_support 
bfdd: allow l3vrf bfd sessions without udp leaking
 2022-07-22 14:12:17 +00:00
Donald Sharp
efb6140a9b
Merge pull request #11662 from opensourcerouting/fix/call_hooks_when_replacing_asfilter 
bgpd: Call a hook when as-path filter is replaced
 2022-07-22 09:48:25 -04:00
Donald Sharp
35aae5c9bc bgpd: LL peers need bnc's per peer 
FRR should create a bnc per peer.  Not have
one's that write over others.  Currently when
FRR has multiple Interface based peering, BGP wa
creating a single BNC.  This is insufficient in that
we were accidently overwriting the one LL with other
data.  This causes issues when there are multiple and
there is weird starting issues with those interfaces
that you are peering over.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-22 09:09:39 -04:00
Donatas Abraitis
f709b31b88 bgpd: Call a hook when as-path filter is replaced 
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
 2022-07-22 14:16:02 +03:00
Philippe Guibert
97413ed778 topotests: add bfd_vrflite_topo1 test 
This tests checks that there are no errors when receiving BFD
packets over the various linux vrf interfaces. For example, if
an incoming packet is received by the wrong socket, a VRF
mismatch error would occur, and BFD flapping would be observed.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2022-07-22 08:49:52 +02:00
Philippe Guibert
e6d4113660 pathd: add a zebra stop handler 
This handler code is used to stop zebra related contexts.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
 2022-07-22 08:39:06 +02:00
Donatas Abraitis
fcc48b4f9e
Merge pull request #11658 from Jafaral/up-rel8.3 
debian, redhat: updating changelog for new release
 2022-07-22 08:26:23 +03:00
Donatas Abraitis
eed5b70f94
Merge pull request #11657 from donaldsharp/why_timer 
convert thread_cancel to THREAD_OFF
 2022-07-22 08:26:08 +03:00
Jafar Al-Gharaibeh
4ca513bb8a debian, redhat: updating changelog for new release 
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
 2022-07-21 18:11:04 -05:00
mobash-rasool
cb6c39645f
Merge pull request #11654 from donaldsharp/fixup_macros 
*: frr_with_mutex change to follow our standard
 2022-07-21 19:10:41 +05:30
Donald Sharp
2783a6921c ldpd: Convert thread_cancel to THREAD_OFF 
Just convert all uses of thread_cancel to THREAD_OFF

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:30:50 -04:00
Donald Sharp
fa935aa7e8 isisd: Convert thread_cancel to THREAD_OFF 
Just convert all uses of thread_cancel to THREAD_OFF

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:30:50 -04:00
Donald Sharp
146bcb9b92 zebra: Convert thread_cancel to THREAD_OFF 
Just convert all uses of thread_cancel to THREAD_OFF

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:30:50 -04:00
Donald Sharp
b8551584ee lib, vrrpd: Use THREAD_ARG 
Don't auto set the thread->arg pointer.  It is private
and should be only accessed through the THREAD_ARG pointer.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:30:50 -04:00
Donald Sharp
c3aaa89a44 bgpd: Convert thread_cancel to THREAD_OFF and use THREAD_ARG 
Just convert all uses of thread_cancel to THREAD_OFF.  Additionally
use THREAD_ARG instead of t->arg to get the arguement.  Individual
files should never be accessing thread private data like this.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:30:49 -04:00
Donald Sharp
fa5806c318 bgpd: Remove various macros that overlap THREAD_OFF 
Let's just use THREAD_OFF consistently in the code base
instead of each daemon having a special macro that needs to
be looked at and remembered what it does.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:27:36 -04:00
Donald Sharp
69ec2ecbea ripngd: Convert thread_cancel to THREAD_OFF 
Just convert all uses of thread_cancel to THREAD_OFF

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:27:35 -04:00
Donald Sharp
546c8d78e7 ripngd: Remove various macros that overlap THREAD_OFF 
Let's just use THREAD_OFF consistently in the code base
instead of each daemon having a special macro that needs to
be looked at and remembered what it does.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:27:35 -04:00
Donald Sharp
f6499a7608 ripd: Convert thread_cancel to THREAD_OFF 
Just convert all uses of thread_cancel to THREAD_OFF

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
 2022-07-21 08:27:35 -04:00