Commit Graph

21958 Commits

Author SHA1 Message Date
Renato Westphal
d20b14bcd7 yang, isisd: add LFA nodes, NB skeleton callbacks and CLI commands
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-11-24 20:15:52 -03:00
Renato Westphal
2866b11911 isisd: rename the "debug isis ti-lfa" command to make it more generic
Rename "debug isis ti-lfa" to "debug isis lfa". Having different
debug guards for different kinds of LFA (classic, remote and TI-LFA)
doesn't make sense since all LFA solutions share code to certain
extent.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-11-24 20:15:51 -03:00
Renato Westphal
35f70ed3f9 isisd: move and rename the infinity metric constants
Those constants are also useful in contexts other than LDP-IGP
Synchronization (e.g. the upcoming LFA work will need them). Move
them to a more general header to reflect that.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-11-24 20:15:51 -03:00
Renato Westphal
6dfb7f5961 isisd: consult locally configured MSD when computing TI-LFA repair paths
Do not attempt to install a TI-LFA backup nexthop if its number of
labels exceeds the locally configured MSD (Maximum Stack Depth). The
idea is to prevent forward-plane installation failures before they
happen. The MSD check should also allow the "show isis fast-reroute
summary" command (not implemented yet) to display the actual
protection coverage provided by TI-LFA, which might not be 100%
if the MSD isn't big enough.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2020-11-24 20:15:51 -03:00
Quentin Young
2784d2c7d2
Merge pull request #7475 from eololab/add-more-parameters-for-crosscompilation
build: add more precious variables for cross-compilation
2020-11-24 11:44:29 -05:00
Donald Sharp
7b1d13bb1f
Merge pull request #7560 from opensourcerouting/fix_topotest_logs
topotests: Fix logging by redirecting it to correct file
2020-11-24 11:30:14 -05:00
Donatas Abraitis
9bcab3130b
Merge pull request #7577 from donaldsharp/datacenter_stuff
Datacenter stuff
2020-11-24 10:02:39 +02:00
Donatas Abraitis
0064614626
Merge pull request #7592 from mjstapp/fix_restore_topo_scale
tests: restore route scale test to 1M routes
2020-11-24 10:01:36 +02:00
Mark Stapp
d13964a914 tests: restore route scale test to 1M routes
Restore the scale topotest config to use 1M routes.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
2020-11-23 16:53:43 -05:00
Quentin Young
a3014b9ac7
Merge pull request #7223 from idryzhov/fix-vtysh-view-node
vtysh: fix execution of commands from the view node
2020-11-23 13:36:41 -05:00
Donatas Abraitis
4f3e4669f0
Merge pull request #7565 from vishaldhingra/bgp_nb
bgpd: sh running config is not considering values provided via -e for max-paths
2020-11-21 22:19:53 +02:00
Donald Sharp
4c73df7a61
Merge pull request #7580 from ckishimo/bit-Nt
ospfd: fix NSSA translate-always
2020-11-21 11:36:01 -05:00
Donald Sharp
b54fe98fcd
Merge pull request #7581 from mboehn/master
doc: add bpgd --listenon implies --no_kernel
2020-11-21 11:33:28 -05:00
Mathias Bøhn Grytemark
c17537f9fe doc: add bpgd --listenon implies --no_kernel
The bgpd --listenon option implies --no_kernel. This commit makes note
of that in the documentation.

Signed-off-by: Mathias Bøhn Grytemark <mathias@grytemark.no>
2020-11-21 13:50:43 +01:00
Igor Ryzhov
88c7120070 vtysh: fix node for "show yang operational-data"
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-21 15:15:45 +03:00
Igor Ryzhov
a5eb3b0dde vtysh: fix execution of commands from the view node
We should not prepend "do" when executing commands from the view node,
because view node doesn't support "do" shortcut.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-21 15:15:45 +03:00
ckishimo
a987fe6b25 ospfd: fix NSSA translate-always
When an ABR NSSA router is configured to be ALWAYS the translator:
  r22(config-router)# area 1 nssa translate-always

It will advertise this condition in the type-1 LSA setting the Nt
bit, taking over the translator role from r33

  r22# show ip ospf
     We are an ABR and always an NSSA Translator.
  r33# show ip ospf
     We are an ABR, but not the NSSA Elected Translator.

However when the command above is removed:
  r22(config-router)# no area 1 nssa translate-always

the bit Nt needs to be cleared otherwise we end up with no translator
in the area
  r22# show ip ospf
     We are an ABR, but not the NSSA Elected Translator.
  r33# show ip ospf
     We are an ABR, but not the NSSA Elected Translator.

This PR forces the ABR to send a type-1 LSA with the Nt bit updated
according to the translator role

Signed-off-by: ckishimo <carles.kishimoto@gmail.com>
2020-11-21 04:13:17 -08:00
Mark Stapp
1499b13794
Merge pull request #7576 from donaldsharp/rpki_stuff
bgpd: Cleanup rpki indentation
2020-11-20 15:07:44 -05:00
Donald Sharp
50121ac041 bgpd: Remove restriction on certain connection types under HAVE_CUMULUS
Current code when we are establishing a peering relationship when
under the HAVE_CUMULUS block will dissallow v4/v6 connections if
we do not have v4/v6 addresses applied.  This restriction is
a bit harsh and should be allowed but warned against.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-20 13:47:14 -05:00
Donald Sharp
98cc8dd473 vtysh: Start deprecation cycle for address-family evpn
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-20 13:47:14 -05:00
Donald Sharp
64aaa92dff
Merge pull request #7574 from idryzhov/fix-quit
vtysh: send quit command to watchfrr
2020-11-20 13:00:56 -05:00
Quentin Young
e4cc866f0a
Merge pull request #7551 from mjstapp/fix_doc_no_index
doc: don't index 'no' forms of commands
2020-11-20 12:15:31 -05:00
Martin Winter
ed827751d3
topotests: Fix logging by redirecting it to correct file
Fix lib to start loggin to correct daemon file on startup
Fix bgp-auth tests for the logging changes
Fixes Issue # 7545

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2020-11-20 17:48:49 +01:00
Igor Ryzhov
5772415bd3 vtysh: send quit command to watchfrr
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-20 17:42:39 +03:00
Donald Sharp
708b805361 bgpd: Cleanup rpki indentation
Rework a couple functions to allow the indentation to be a bit
cleaner.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
2020-11-20 08:44:25 -05:00
Donald Sharp
2332790973
Merge pull request #7569 from patrasar/pim_coverity_fix
pimd: Fix SA issues found in Coverity Scan
2020-11-20 07:40:06 -05:00
vdhingra
00908b7a8a bgpd: sh running config is not considering values provided via -e for max-paths
problem
1. run the bgp with -e1 option
2. c t
   router bgp 100
3. show running config
    !
     address-family ipv6 multicast
      maximum-paths 1
      maximum-paths ibgp 1
     exit-address-family
    !
address families should not dump maximum-paths if there
value is same as value provided at run time.

fix
if the maxpaths_ebgp value is same as multipath_num global
object, don't dump maximum-paths.

Signed-off-by: vishaldhingra <vdhingra@vmware.com>
2020-11-20 02:32:18 -08:00
Sarita Patra
e1d1e95123 pimd: Fix SA issues found in Coverity Scan
Signed-off-by: Sarita Patra <saritap@vmware.com>
2020-11-20 01:47:04 -08:00
Donatas Abraitis
a1477006f9
Merge pull request #7562 from donaldsharp/python_fixes
tests: Fix common_config.py issues
2020-11-20 09:37:58 +02:00
Donald Sharp
e1b89f023b
Merge pull request #7559 from ckishimo/translator
ospfd: fix NSSA translator
2020-11-19 19:33:59 -05:00
Donald Sharp
22d7226542
Merge pull request #7546 from mjstapp/limit_fds
lib: add startup-time option to limit fds used
2020-11-19 19:28:57 -05:00
Donald Sharp
c0b76cfe11
Merge pull request #7568 from idryzhov/fix-naming
lib: fix local variable shadowing global one
2020-11-19 19:25:56 -05:00
Donald Sharp
cf36334c6f
Merge pull request #7544 from andylemin/master
bgpd: added bmp read check to detect broken sessions
2020-11-19 19:24:42 -05:00
Donald Sharp
0f7e34f86c
Merge pull request #7564 from pguibert6WIND/fix_typo_topotest
doc: topotest json typo error
2020-11-19 18:36:48 -05:00
Quentin Young
c14dba6241 Revert "debian: Merge various debian changelogs in debian/changelog"
This reverts commit da3a39ff6a.
2020-11-19 17:12:42 -05:00
Quentin Young
439be082d3 Revert "debian: Adjust tarsource.sh to use native debian/changelog"
This reverts commit 4ffb9a4c9d.
2020-11-19 17:12:41 -05:00
Quentin Young
1b8a899da3 Revert "debian: Update tools/build-debian-package.sh to use git-buildpackage"
This reverts commit 63c0c8ed89.
2020-11-19 17:12:40 -05:00
Quentin Young
fb0b3592ca Revert "debian: Remove the changelog-auto automation in favor of dch"
This reverts commit cace1d9bf1.
2020-11-19 17:12:40 -05:00
Quentin Young
2013e82a89 Revert "debian: Remove now obsolete tarsource.sh script"
This reverts commit bc304e08ea.
2020-11-19 17:12:38 -05:00
Quentin Young
5aa63f6aa6 Revert "debian: Update the tools/build-debian-package.sh to be example build script"
This reverts commit c950a7f214.
2020-11-19 17:12:27 -05:00
Igor Ryzhov
62b439624b lib: fix local variable shadowing global one
start_config and end_config are already used as function names in DEFUN,
so the current naming is a little bit confusing. Let's use different
names for arguments.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-20 00:53:34 +03:00
Ondřej Surý
c950a7f214 debian: Update the tools/build-debian-package.sh to be example build script
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:11 +01:00
Ondřej Surý
bc304e08ea debian: Remove now obsolete tarsource.sh script 2020-11-19 21:30:08 +01:00
Ondřej Surý
cace1d9bf1 debian: Remove the changelog-auto automation in favor of dch
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:06 +01:00
Ondřej Surý
63c0c8ed89 debian: Update tools/build-debian-package.sh to use git-buildpackage
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:30:02 +01:00
Ondřej Surý
4ffb9a4c9d debian: Adjust tarsource.sh to use native debian/changelog
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:29:59 +01:00
Ondřej Surý
da3a39ff6a debian: Merge various debian changelogs in debian/changelog
Signed-off-by: Ondřej Surý <ondrej@sury.org>
2020-11-19 21:29:45 +01:00
Mark Stapp
38a0ce9146
Merge pull request #7566 from ton31337/fix/topotests_bgp_ebgp_requires_policy
tests: Add more descriptive error messages and increase timeouts
2020-11-19 13:32:56 -05:00
Mark Stapp
b3ec3c3cb9
Merge pull request #7424 from donaldsharp/config_commands
lib, sharpd, vtysh: When reading a file in for config send start/end …
2020-11-19 12:40:50 -05:00
Donald Sharp
cac886dd53
Merge pull request #6145 from patrasar/pim_nb_code_upstream
pimd: northbound backend code
2020-11-19 11:03:00 -05:00