proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-16 10:38:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
11,816 Commits 4 Branches 191 Tags 125 MiB
d1b21b9616
Commit Graph

11816 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
paco
d1b21b9616
pimd: return check (Coverity 1465490) 
Unless someone intentionally changes MCAST_ALL_ROUTERS ("224.0.0.2") with a
wrong IP, this should never fail, so the fix is using "(void)" at the left
of the function call, as an explicit way of indicating we discard the
return value on purpose.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-26 19:34:04 +02:00
Renato Westphal
b2e020256e
Merge pull request #2549 from pacovn/Coverity_1452317_Explicit_null_dereferenced 
ldpd: null check (Coverity 1452317)
 2018-06-26 10:55:08 -03:00
Renato Westphal
ec45d6c140
Merge pull request #2552 from qlyoung/remove-defun-deprecated 
Remove DEFUN_DEPRECATED
 2018-06-26 10:25:00 -03:00
Jafar Al-Gharaibeh
347e3c3d5f
Merge pull request #2548 from pacovn/Coverity_1453456_Unchecked_return_value_from_library 
lib: check return value (Coverity 1453456)
 2018-06-25 17:30:31 -04:00
paco
e339d7c04d
lib: check return value (Coverity 1453456) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 20:20:24 +02:00
Jafar Al-Gharaibeh
c356b7e68f
Merge pull request #2546 from pacovn/Coverity_1465491_Untrusted_value_as_argument_2 
pimd: untrusted argument (2) (Coverity 1465491)
 2018-06-25 12:53:26 -04:00
Jafar Al-Gharaibeh
2b94866707
Merge pull request #2530 from pacovn/Coverity_1399295_Out-of-bounds_read 
Coverity 1399295 out of bounds read
 2018-06-25 12:46:57 -04:00
Jafar Al-Gharaibeh
91609fe00b
Merge pull request #2536 from pacovn/Coverity_1470150_Dereference_null_return_value 
lib: null check (Coverity 1470150)
 2018-06-25 12:43:31 -04:00
Jafar Al-Gharaibeh
6bb6f26c4e
Merge pull request #2550 from pacovn/Coverity_1399284_Dereference_null_return_value 
ospfd: null check (Coverity 1399284)
 2018-06-25 12:40:02 -04:00
Jafar Al-Gharaibeh
d2722bf362
Merge pull request #2544 from pacovn/Coverity_1468510_Dereference_null_return_value 
ospf6d: null check (Coverity 1468510)
 2018-06-25 12:39:17 -04:00
Quentin Young
61cdcbdc02 lib: remove DEFUN_DEPRECATED 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-25 16:38:53 +00:00
Quentin Young
f07e1c4fe4 bgpd: remove DEFUN_DEPRECATED usage 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-25 16:38:48 +00:00
Jafar Al-Gharaibeh
433b146e25
Merge pull request #2543 from pacovn/Coverity_1399304_Out-of-bounds_access 
ospfd: out-of-bounds access (Coverity 1399304 1399286)
 2018-06-25 12:38:44 -04:00
Jafar Al-Gharaibeh
d4e2ab91cd
Merge pull request #2541 from pacovn/Coverity_1221445_1221448_Out-of-bounds_access 
ospfd: OoB access (Coverity 1221445 1221448)
 2018-06-25 12:37:57 -04:00
Quentin Young
20d8a28413 *: remove deprecated 'log trap' commands 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
 2018-06-25 16:35:34 +00:00
paco
d94023d85c
pimd: untrusted argument (2) (Coverity 1465491) 
Additional fix over 18e994a043 (PR #2457)

Previous correction was not enough for fixing the Coverity warning. Now we
ensure we don't overflow the buffer.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:37:48 +02:00
paco
162dbe419d
ospfd: null check (Coverity 1399284) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:18:17 +02:00
paco
13f0e43443
ospfd: OoB access (Coverity 1399304 1399286) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 17:07:31 +02:00
paco
0ef34ac51a
ldpd: null check (Coverity 1452317) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 16:47:15 +02:00
paco
bacd094053
ospf6d: null check (Coverity 1468510) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 13:09:34 +02:00
paco
c23bc38a9f
ospfd: OoB access (Coverity 1221445 1221448) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-25 11:22:20 +02:00
paco
74e7158c06
lib: null check (Coverity 1470150) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-22 23:03:24 +02:00
Jafar Al-Gharaibeh
3a743cb7ec
Merge pull request #2520 from donaldsharp/privs_smivs 
lib: Fix privs when using HAVE_CAPABILITIES
 2018-06-22 14:19:13 -05:00
Quentin Young
5caa3ad34f
Merge pull request #2512 from pacovn/Coverity_1399200_Unchecked_return_value_from_library 
vtysh: return value check (Coverity 1399200)
 2018-06-22 14:11:09 -04:00
paco
0961ea934f
ripd: out-of-bounds read (Coverity 1399295) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-22 19:16:52 +02:00
Lou Berger
ec446a4673
Merge pull request #2449 from donaldsharp/lib_delayed_read 
Lib delayed read
 2018-06-22 13:13:05 -04:00
paco
1a40fad568
vtysh: return value check (Coverity 1399200) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-22 00:01:42 +02:00
Quentin Young
0a8990d5f8
Merge pull request #2501 from pacovn/infer_unused1 
bgpd isisd ldpd lib ospfd pimd: redundancy (infer, grouped)
 2018-06-21 15:12:33 -04:00
Quentin Young
7c25948eca
Merge pull request #2505 from pacovn/Coverity_1143220_Argument_cannot_be_negative 
tools: return check (2) (Coverity 1143220)
 2018-06-21 15:02:31 -04:00
Quentin Young
390cc01007
Merge pull request #2511 from pacovn/Coverity_1452287_et_al_Explicit_null_dereferenced 
ldpd, lib: null check (Coverity 1452287 and 20 alike)
 2018-06-21 15:00:12 -04:00
Quentin Young
772b852662
Merge pull request #2408 from ajones-rvbd/ajones-issue-2403 
tests: use BUILT_SOURCES in tests/Makefile.am for automake 1.16.1
 2018-06-21 14:43:16 -04:00
Quentin Young
c3fdecefb4
Merge pull request #2502 from pacovn/Coverity_1221459_Use_after_free 
ospf6d: fix use after free (2) (Coverity 1221459)
 2018-06-21 14:38:47 -04:00
Quentin Young
132880ad0a
Merge pull request #2513 from pacovn/Coverity_1455334_et_al_Dereference_null_return_value 
eigrpd: null check (Coverity 1455334 and 4 alike)
 2018-06-21 14:34:56 -04:00
Quentin Young
277781a778
Merge pull request #2518 from pacovn/Coverity_23106_Explicit_null_dereferenced 
bgpd: null check (Coverity 23106)
 2018-06-21 14:24:11 -04:00
Quentin Young
dfc5d40e91
Merge pull request #2519 from pacovn/Coverity_1399238_Logically_dead_code 
bgpd: dead code (Coverity 1399238)
 2018-06-21 14:20:48 -04:00
Quentin Young
1337a02851
Merge pull request #2522 from pacovn/Coverity_1399277_Explicit_null_dereferenced 
lib: null check (Coverity 1399277)
 2018-06-21 14:18:47 -04:00
Quentin Young
cc05c430b3
Merge pull request #2523 from pacovn/Coverity_1455380_Dereference_null_return_value 
bgpd: null check (Coverity 1455380)
 2018-06-21 14:17:58 -04:00
paco
990f4f9112
bgpd: null check (Coverity 1455380) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 18:51:52 +02:00
paco
d1f92e454c
lib: null check (Coverity 1399277) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 17:35:38 +02:00
Donald Sharp
38e72ffa9a sharpd: Does not need any special priv's 
Remove the unnecessary privs that we were requesting
for the sharp daemon.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 11:28:16 -04:00
paco
d87ff2ddf4
bgpd: dead code (Coverity 1399238) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 17:22:55 +02:00
Donald Sharp
8e04538cae lib: Fix privs when using HAVE_CAPABILITIES 
If your daemon does not need any special privileges
and you are compiling with HAVE_CAPABILIES, the
zprivs->change pointer will end up NULL due
to the way zprivs_caps_init.  So as a check
let's add a NULL check for zprivs->change
and set it to a function that will do nothing.

This change prevents a crash if you raise privileges
when your daemon needs no special privileges.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 11:22:51 -04:00
Renato Westphal
aa74131957
Merge pull request #2510 from donaldsharp/extended_ack 
zebra: Add extended Ack error parsing to FRR
 2018-06-21 12:16:53 -03:00
paco
e8a3a0a030
bgpd: null check (Coverity 23106) 
Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 15:58:51 +02:00
paco
7edb6aa583
spf6d: fix use after free (2) (Coverity 1221459) 
Previous fix was incomplete, as calling ospf6_lsa_unlock() frees 'req' but
it does not put it to zero, so it was called ospf6_lsdb_remove() afterwards
even being 'req' already freed.

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 15:18:13 +02:00
Donald Sharp
29516b7cc3 include: add netlink.h to our build system 
For compilation on platforms that do not have the
linux headers installed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 08:07:30 -04:00
Donald Sharp
5d307d5d3a zebra: Add extended Ack error parsing to FRR 
Add code to request and read in extended ack information
to provide a bit more context of what went wrong when
a failure is detected in the kernel.

Example of a failed delete:
Jun 20 21:19:25 robot zebra[11878]: Extended Error: Invalid prefix for given prefix length
Jun 20 21:19:25 robot zebra[11878]: netlink-cmd (NS 0) error: Invalid argument, type=RTM_DELROUTE(25), seq=8, pid=4078403400
Jun 20 21:19:25 robot zebra[11878]: 0:4.3.2.0/24: Route Deletion failure

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
 2018-06-21 08:07:30 -04:00
paco
0bf75bd5c9
eigrpd: null check (Coverity 1455334 and 4 alike) 
Coverity issues fixed with this commit:

1455334 1455335 1455336 1455337 1455339

Signed-off-by: F. Aragon <paco@voltanet.io>
 2018-06-21 14:02:33 +02:00
Donald Sharp
eab268594a
Merge pull request #2504 from pacovn/Coverity_23110_Dereference_after_null_check 
ospfd: null check (Coverity 23110)
 2018-06-21 07:30:21 -04:00
Donald Sharp
50f08ff26a
Merge pull request #2507 from pacovn/Coverity_1436344_1451361_Dereference_after_null_check 
bgpd, lib: null check (Coverity 1436344, 1451361)
 2018-06-21 07:29:51 -04:00